Received-SPF: pass (google.com: domain of linux-kernel+bounces-19336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <486973921f89f70bcc5d42501eeca3fd105be2c4.camel@perches.com>
Subject: Re: [HID Patchsets for Samsung driver v2 2/6] HID: Samsung : Fix
 the checkpatch complain.
From: Joe Perches <joe@perches.com>
To: Sandeep C S <sandeep.cs@samsung.com>, Jiri Kosina <jikos@kernel.org>, 
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: gaudium.lee@samsung.com, ih0923.kim@samsung.com,
 suhyun_.kim@samsung.com,  jitender.s21@samsung.com, junwan.cho@samsung.com,
 linux-input@vger.kernel.org,  linux-kernel@vger.kernel.org
Date: Mon, 08 Jan 2024 02:21:10 -0800
In-Reply-To: <20240108091917.1552013-3-sandeep.cs@samsung.com>
References: <20240108091917.1552013-1-sandeep.cs@samsung.com>
	 <CGME20240108091959epcas5p2559b779424e2fb7c7e268d1b24612b4f@epcas5p2.samsung.com>
	 <20240108091917.1552013-3-sandeep.cs@samsung.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-01-08 at 14:49 +0530, Sandeep C S wrote:
> Warning found by checkpatch.pl script.
[]
> diff --git a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
[]
> @@ -67,20 +67,17 @@ static __u8 *samsung_irda_report_fixup(struct hid_dev=
ice *hdev, __u8 *rdesc,
>  		rdesc[178] =3D 0x08;
>  		rdesc[180] =3D 0x06;
>  		rdesc[182] =3D 0x42;
> -	} else
> -	if (*rsize =3D=3D 203 && rdesc[192] =3D=3D 0x15 && rdesc[193] =3D=3D 0x=
0 &&
> +	} else if (*rsize =3D=3D 203 && rdesc[192] =3D=3D 0x15 && rdesc[193] =
=3D=3D 0x0 &&
>  			rdesc[194] =3D=3D 0x25 && rdesc[195] =3D=3D 0x12) {
>  		samsung_irda_dev_trace(hdev, 203);
>  		rdesc[193] =3D 0x1;
>  		rdesc[195] =3D 0xf;
> -	} else
> -	if (*rsize =3D=3D 135 && rdesc[124] =3D=3D 0x15 && rdesc[125] =3D=3D 0x=
0 &&
> +	} else if (*rsize =3D=3D 135 && rdesc[124] =3D=3D 0x15 && rdesc[125] =
=3D=3D 0x0 &&
>  			rdesc[126] =3D=3D 0x25 && rdesc[127] =3D=3D 0x11) {
>  		samsung_irda_dev_trace(hdev, 135);
>  		rdesc[125] =3D 0x1;
>  		rdesc[127] =3D 0xe;
> -	} else
> -	if (*rsize =3D=3D 171 && rdesc[160] =3D=3D 0x15 && rdesc[161] =3D=3D 0x=
0 &&
> +	} else if (*rsize =3D=3D 171 && rdesc[160] =3D=3D 0x15 && rdesc[161] =
=3D=3D 0x0 &&
>  			rdesc[162] =3D=3D 0x25 && rdesc[163] =3D=3D 0x01) {
>  		samsung_irda_dev_trace(hdev, 171);
>  		rdesc[161] =3D 0x1;

For this block, I think a rewrite using memcmp would be clearer.
Something like:
---
 drivers/hid/hid-samsung.c | 34 +++++++++++++++-------------------
 1 file changed, 15 insertions(+), 19 deletions(-)

diff --git a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
index cf5992e970940..cd84fb5e68f69 100644
--- a/drivers/hid/hid-samsung.c
+++ b/drivers/hid/hid-samsung.c
@@ -58,33 +58,29 @@ static inline void samsung_irda_dev_trace(struct hid_de=
vice *hdev,
 static __u8 *samsung_irda_report_fixup(struct hid_device *hdev, __u8 *rdes=
c,
 		unsigned int *rsize)
 {
-	if (*rsize =3D=3D 184 && rdesc[175] =3D=3D 0x25 && rdesc[176] =3D=3D 0x40=
 &&
-			rdesc[177] =3D=3D 0x75 && rdesc[178] =3D=3D 0x30 &&
-			rdesc[179] =3D=3D 0x95 && rdesc[180] =3D=3D 0x01 &&
-			rdesc[182] =3D=3D 0x40) {
+	if (*rsize =3D=3D 184 &&
+	    !memcmp(&rdesc[175], "\x25\x40\x75\x30\x95\x01", 6) &&
+	    rdesc[182] =3D=3D 0x40) {
 		samsung_irda_dev_trace(hdev, 184);
 		rdesc[176] =3D 0xff;
 		rdesc[178] =3D 0x08;
 		rdesc[180] =3D 0x06;
 		rdesc[182] =3D 0x42;
-	} else
-	if (*rsize =3D=3D 203 && rdesc[192] =3D=3D 0x15 && rdesc[193] =3D=3D 0x0 =
&&
-			rdesc[194] =3D=3D 0x25 && rdesc[195] =3D=3D 0x12) {
+	} else if (*rsize =3D=3D 203 &&
+		   !memcmp(&rdesc[192], "\x15\x00\x25\x12", 4)) {
 		samsung_irda_dev_trace(hdev, 203);
-		rdesc[193] =3D 0x1;
-		rdesc[195] =3D 0xf;
-	} else
-	if (*rsize =3D=3D 135 && rdesc[124] =3D=3D 0x15 && rdesc[125] =3D=3D 0x0 =
&&
-			rdesc[126] =3D=3D 0x25 && rdesc[127] =3D=3D 0x11) {
+		rdesc[193] =3D 0x01;
+		rdesc[195] =3D 0x0f;
+	} else if (*rsize =3D=3D 135 &&
+		   !memcmp(&rdesc[124], "\x15\x00\x25\x11", 4)) {
 		samsung_irda_dev_trace(hdev, 135);
-		rdesc[125] =3D 0x1;
-		rdesc[127] =3D 0xe;
-	} else
-	if (*rsize =3D=3D 171 && rdesc[160] =3D=3D 0x15 && rdesc[161] =3D=3D 0x0 =
&&
-			rdesc[162] =3D=3D 0x25 && rdesc[163] =3D=3D 0x01) {
+		rdesc[125] =3D 0x01;
+		rdesc[127] =3D 0x0e;
+	} else if (*rsize =3D=3D 171 &&
+		   !memcmp(&rdesc[160], "\x15\x00\x25\x01", 4)) {
 		samsung_irda_dev_trace(hdev, 171);
-		rdesc[161] =3D 0x1;
-		rdesc[163] =3D 0x3;
+		rdesc[161] =3D 0x01;
+		rdesc[163] =3D 0x03;
 	}
 	return rdesc;
 }