Received-SPF: pass (google.com: domain of linux-kernel+bounces-19372-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: David Laight <David.Laight@ACULAB.COM>
To: 'Dmitry Torokhov' <dmitry.torokhov@gmail.com>, Arnd Bergmann
	<arnd@arndb.de>
CC: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linus Torvalds
	<torvalds@linux-foundation.org>
Subject: RE: [PATCH] asm-generic: make sparse happy with odd-sized
 put_unaligned_*()
Thread-Topic: [PATCH] asm-generic: make sparse happy with odd-sized
 put_unaligned_*()
Thread-Index: AQHaQfo/rBE9iMqwLUOx80/L8Ll8bLDPvnqw
Date: Mon, 8 Jan 2024 11:03:22 +0000
Message-ID: <12d88da48f6947ab86a845e8d02319ff@AcuMS.aculab.com>
References: <ZZuTTRCUFqWzA1y-@google.com>
In-Reply-To: <ZZuTTRCUFqWzA1y-@google.com>
Accept-Language: en-GB, en-US
Precedence: bulk
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

From: Dmitry Torokhov
> Sent: 08 January 2024 06:17
>=20
> __put_unaligned_be24() and friends use implicit casts to convert
> larger-sized data to bytes, which trips sparse truncation warnings when
> the argument is a constant:
>=20
>   CC [M]  drivers/input/touchscreen/hynitron_cstxxx.o
>   CHECK   drivers/input/touchscreen/hynitron_cstxxx.c
> drivers/input/touchscreen/hynitron_cstxxx.c: note: in included file (thro=
ugh
> arch/x86/include/generated/asm/unaligned.h):
> ./include/asm-generic/unaligned.h:119:16: warning: cast truncates bits fr=
om constant value (aa01a0
> becomes a0)
> ./include/asm-generic/unaligned.h:120:20: warning: cast truncates bits fr=
om constant value (aa01
> becomes 1)
> ./include/asm-generic/unaligned.h:119:16: warning: cast truncates bits fr=
om constant value (ab00d0
> becomes d0)
> ./include/asm-generic/unaligned.h:120:20: warning: cast truncates bits fr=
om constant value (ab00
> becomes 0)
>=20
> To avoid this let's mask off upper bits explicitly, the resulting code
> should be exactly the same, but it will keep sparse happy.

Maybe someone should fix sparse?
I have seen a compiler generate two explicit masks with 0xff
followed by a byte write for:
=09*p =3D (char)(x & 0xff);
but I expect modern gcc is ok.

> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401070147.gqwVulOn-lkp@i=
ntel.com/
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  include/asm-generic/unaligned.h | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>=20
> diff --git a/include/asm-generic/unaligned.h b/include/asm-generic/unalig=
ned.h
> index 699650f81970..a84c64e5f11e 100644
> --- a/include/asm-generic/unaligned.h
> +++ b/include/asm-generic/unaligned.h
> @@ -104,9 +104,9 @@ static inline u32 get_unaligned_le24(const void *p)
>=20
>  static inline void __put_unaligned_be24(const u32 val, u8 *p)
>  {
> -=09*p++ =3D val >> 16;
> -=09*p++ =3D val >> 8;
> -=09*p++ =3D val;
> +=09*p++ =3D (val >> 16) & 0xff;
> +=09*p++ =3D (val >> 8) & 0xff;
> +=09*p++ =3D val & 0xff;
>  }

What happens if you implement the as (eg):
=09*p =3D val >> 16;
=09put_unaligned_be16(p + 1, val);
I think that should generate better code.
And it may stop sparse bleating.

=09David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1=
PT, UK
Registration No: 1397386 (Wales)