Received-SPF: pass (google.com: domain of linux-kernel+bounces-19443-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <52ac2f13-6439-490f-98a6-79f79b9897e9@huawei.com>
Date: Mon, 8 Jan 2024 19:37:23 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] hwtracing: hisi_ptt: Move type check to the beginning of
 hisi_ptt_pmu_event_init()
Content-Language: en-US
To: Yang Jihong <yangjihong1@huawei.com>, <yangyicong@hisilicon.com>,
	<jonathan.cameron@huawei.com>, <alexander.shishkin@linux.intel.com>,
	<linux-kernel@vger.kernel.org>
References: <20240108112024.3514498-1-yangjihong1@huawei.com>
From: Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <20240108112024.3514498-1-yangjihong1@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/1/8 19:20, Yang Jihong wrote:
> When perf_init_event() calls perf_try_init_event() to init pmu driver,
> searches for the next pmu driver only when the return value is -ENOENT.
> Therefore, hisi_ptt_pmu_event_init() needs to check the type at the
> beginning of the function.
> Otherwise, in the case of perf-task mode, perf_try_init_event() returns
> -EOPNOTSUPP and skips subsequent pmu drivers, causes perf_init_event() to
> fail.
> 

Maybe

Fixes: ff0de066b463 ("hwtracing: hisi_ptt: Add trace function support 
for HiSilicon PCIe Tune and Trace device")

It fixes my non hw event issue(perf list hw), thanks.

> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
> ---
>   drivers/hwtracing/ptt/hisi_ptt.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
> index a991ecb7515a..24a1f7797aeb 100644
> --- a/drivers/hwtracing/ptt/hisi_ptt.c
> +++ b/drivers/hwtracing/ptt/hisi_ptt.c
> @@ -995,6 +995,9 @@ static int hisi_ptt_pmu_event_init(struct perf_event *event)
>   	int ret;
>   	u32 val;
>   
> +	if (event->attr.type != hisi_ptt->hisi_ptt_pmu.type)
> +		return -ENOENT;
> +
>   	if (event->cpu < 0) {
>   		dev_dbg(event->pmu->dev, "Per-task mode not supported\n");
>   		return -EOPNOTSUPP;
> @@ -1003,9 +1006,6 @@ static int hisi_ptt_pmu_event_init(struct perf_event *event)
>   	if (event->attach_state & PERF_ATTACH_TASK)
>   		return -EOPNOTSUPP;
>   
> -	if (event->attr.type != hisi_ptt->hisi_ptt_pmu.type)
> -		return -ENOENT;
> -
>   	ret = hisi_ptt_trace_valid_filter(hisi_ptt, event->attr.config);
>   	if (ret < 0)
>   		return ret;