Received-SPF: pass (google.com: domain of linux-kernel+bounces-19515-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
CC: <suzuki.poulose@arm.com>, <wangkefeng.wang@huawei.com>,
	<yangyicong@hisilicon.com>, <alexander.shishkin@linux.intel.com>,
	<jonathan.cameron@huawei.com>, <john.garry@huawei.com>,
	<mathieu.poirier@linaro.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] hwtracing: hisi_ptt: Move type check to the beginning
 of hisi_ptt_pmu_event_init()
To: Yang Jihong <yangjihong1@huawei.com>
References: <20240108121906.3514820-1-yangjihong1@huawei.com>
From: Yicong Yang <yangyicong@huawei.com>
Message-ID: <fd4037ad-59df-d3e2-0fe9-bde0182ce79f@huawei.com>
Date: Mon, 8 Jan 2024 20:29:09 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240108121906.3514820-1-yangjihong1@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Hi Jihong,

On 2024/1/8 20:19, Yang Jihong wrote:
> When perf_init_event() calls perf_try_init_event() to init pmu driver,
> searches for the next pmu driver only when the return value is -ENOENT.
> Therefore, hisi_ptt_pmu_event_init() needs to check the type at the
> beginning of the function.
> Otherwise, in the case of perf-task mode, perf_try_init_event() returns
> -EOPNOTSUPP and skips subsequent pmu drivers, causes perf_init_event() to
> fail.
> 
> Fixes: ff0de066b463 ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device")
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>

Thanks for fixing this:

Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>

> ---
> 
> Changes since v1:
>  - Add fixes tag.
> 
>  drivers/hwtracing/ptt/hisi_ptt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
> index a991ecb7515a..24a1f7797aeb 100644
> --- a/drivers/hwtracing/ptt/hisi_ptt.c
> +++ b/drivers/hwtracing/ptt/hisi_ptt.c
> @@ -995,6 +995,9 @@ static int hisi_ptt_pmu_event_init(struct perf_event *event)
>  	int ret;
>  	u32 val;
>  
> +	if (event->attr.type != hisi_ptt->hisi_ptt_pmu.type)
> +		return -ENOENT;
> +
>  	if (event->cpu < 0) {
>  		dev_dbg(event->pmu->dev, "Per-task mode not supported\n");
>  		return -EOPNOTSUPP;
> @@ -1003,9 +1006,6 @@ static int hisi_ptt_pmu_event_init(struct perf_event *event)
>  	if (event->attach_state & PERF_ATTACH_TASK)
>  		return -EOPNOTSUPP;
>  
> -	if (event->attr.type != hisi_ptt->hisi_ptt_pmu.type)
> -		return -ENOENT;
> -
>  	ret = hisi_ptt_trace_valid_filter(hisi_ptt, event->attr.config);
>  	if (ret < 0)
>  		return ret;
>