Received-SPF: pass (google.com: domain of linux-kernel+bounces-19584-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 8 Jan 2024 13:05:34 +0000
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Ira Weiny <ira.weiny@intel.com>
CC: Dan Williams <dan.j.williams@intel.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>, Shiju Jose <shiju.jose@huawei.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>, "Davidlohr Bueso" <dave@stgolabs.net>,
	Dave Jiang <dave.jiang@intel.com>, "Alison Schofield"
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, Ard
 Biesheuvel <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v5 2/9] cxl/events: Promote CXL event structures to a
 core header
Message-ID: <20240108130534.000022f5@Huawei.com>
In-Reply-To: <20231220-cxl-cper-v5-2-1bb8a4ca2c7a@intel.com>
References: <20231220-cxl-cper-v5-0-1bb8a4ca2c7a@intel.com>
	<20231220-cxl-cper-v5-2-1bb8a4ca2c7a@intel.com>
Organization: Huawei Technologies Research and Development (UK) Ltd.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

On Wed, 20 Dec 2023 16:17:29 -0800
Ira Weiny <ira.weiny@intel.com> wrote:

> UEFI code can process CXL events through CPER records.  Those records
> use almost the same format as the CXL events.
> 
> Lift the CXL event structures to a core header to be shared in later
> patches.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
As a side note, seems we need some updates in here for 3.1 additions. Job
for another day.

One trivial comment on 'extra' docs that will probably bit rot.

Otherwise
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> new file mode 100644
> index 000000000000..1c94e8fdd227
> --- /dev/null
> +++ b/include/linux/cxl-event.h
> @@ -0,0 +1,100 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _LINUX_CXL_EVENT_H
> +#define _LINUX_CXL_EVENT_H
> +
> +/*
> + * CXL event records; CXL rev 3.0

That version number is nearly guaranteed to bit rot.  I'd just
not mention it here and keep the versioning local to
the particular entries (where it is currently repeated).


> + *
> + * Copyright(c) 2023 Intel Corporation.
> + */