Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1610841rdb; Mon, 8 Jan 2024 05:06:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IE90MdoQaNM11Os19ZY4nvZIThIptcUaoopeIYGllBmLZrjQJQSImn7jt9IEtGe1uRqehmg X-Received: by 2002:a17:903:41ce:b0:1d3:7f26:b3b0 with SMTP id u14-20020a17090341ce00b001d37f26b3b0mr4665580ple.104.1704719185616; Mon, 08 Jan 2024 05:06:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704719185; cv=none; d=google.com; s=arc-20160816; b=zLtwH4lxg6ineirdTg9nJclALy6nS0l8fAQ2rCOI4ej/1uuF3HJM9v5hBSwUGPGh+S XR+8m5ojecJ+Dz5fRNLHiOvo+6dRI5UHSQsqAuaU1b6q66wzMvMb57RM1Ukq7nkryaFw 1Jk4pgbjMOJABUXZrqsdL29lt1txvHcjzMPoou8m6zPJT6lFi3V161Cewww1tBjmSLdN f2c2GdedNJvuXoY6ALJd8KJ/hyl9oX2zffnzY4RfNhZamHTyRfq2/jxmoHhBvAeWmG8R 4xIVRNwSgPiSFnK6zaA/dSirjAzWUThr63UMfM5JEEHatvMdDe3KHD0peg1B8TwFOEzZ pmsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=MSX3nYbKAInL2lO53hdL7SWj/GcywMaxIpVqkN2c9ew=; fh=qaYm4b6GKYlZ0T3gtLZ7fjEfCEC8jMv5XzYe6fOhw1Y=; b=Tma6doXIB21oiHmjrFwdoj/mb6IK87jYD5N2fOU7rYxE9B6ppjycK3IfsLASWJINZI o43hjLIfZImi8urUo9rpMMVdRy2V4ECzCVqK+fWzrgzNnI5AP+MuNI0eHuEKGh3lB98D IzvWOYF4kjVURjuEbgJGtDaT2ayMT0X97OPTOCZ7LhWztC+ST13OJH4YZySyszU0AHyJ RHRbQ7B/TwKFjbC+VizecmEGOvErGcWERfJ0oQkww0kjtfMFXmBHzo/mxS+mQF39Pqjf mq9h1VcFbUz5NNlIBaBk8SC6ZhfnT4R1kryvwjFKsv6KmAUh2L9kYsu264lMuHkPAFuy Z5gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IzuFINww; spf=pass (google.com: domain of linux-kernel+bounces-19585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19585-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id q23-20020a170902edd700b001d0791ce87bsi5915159plk.181.2024.01.08.05.06.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 05:06:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IzuFINww; spf=pass (google.com: domain of linux-kernel+bounces-19585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19585-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DD963B220A3 for ; Mon, 8 Jan 2024 13:06:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 712A441743; Mon, 8 Jan 2024 13:06:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IzuFINww" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98D8E41747 for ; Mon, 8 Jan 2024 13:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704719158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MSX3nYbKAInL2lO53hdL7SWj/GcywMaxIpVqkN2c9ew=; b=IzuFINwwUXwxG283bH8YqBQ3vopCik+eq0HrkedmVnR6zSKwub1JGhWa20UqmOEzId04O0 ey/kzlGvBb7r/kdZNC0dv5YtcSdZ5mSccjvcKoeqCSI6nRlH8v6aT5ZYgIOxVLDda4pro+ pVMM5ptVsaVRxhQ9rwDxyup6MWx7VE0= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-8sjBaB5NP0ST_T423Fq0_g-1; Mon, 08 Jan 2024 08:05:52 -0500 X-MC-Unique: 8sjBaB5NP0ST_T423Fq0_g-1 Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-6dbfdb1ce00so2478638a34.3 for ; Mon, 08 Jan 2024 05:05:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704719151; x=1705323951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MSX3nYbKAInL2lO53hdL7SWj/GcywMaxIpVqkN2c9ew=; b=w8Tlbh9v6xXntW6iUFoSQizdcRRuqQX8wHZXa5LgC7c0fL4Gy1SgJUkC70Fmcdrx1X Bbig+v1fw+KVpFOMjtm8f9Yf//S5kz3LAy4J0W9X6nAdHW5sXKN4IUk/jJRLl3hL6aPg Q9fiO9zVGRNcOkCAMnx9wgXxrh4pgKibcBqyH5iLbAfvytZdE/sAOao3VVNWaRBX/yq1 DKkRyMx9zXT9grlkKwwf4qzcabH7RrI8VkqZIBNfYFLXJMebq/StAcl6y9DlJpg8jwfn PTHp0GDqUs4/W0lSRmBpRJiYkEoDTZtDoqZf8vz0VwjZ4Lu8H3JaFpocCmj1uD/knDiE TEdA== X-Gm-Message-State: AOJu0Yx0YpGmjclOsFawkGC3jnWxoF0CraQu5yRKVD1IZoXzkXRVfU12 tFqk12QUyZsMOReMvjscBkEJlZtLpEW1tPcQ0I0jGV8l/ch+kZuz47R2+XUqrva27TNbrMc9CF4 3xLu0gDb0Bzh1mQVv2n9vGh8ifjoaAg448tinGgeq/dm4dx8B X-Received: by 2002:a9d:7542:0:b0:6dd:ddd8:51e5 with SMTP id b2-20020a9d7542000000b006ddddd851e5mr145284otl.43.1704719151065; Mon, 08 Jan 2024 05:05:51 -0800 (PST) X-Received: by 2002:a9d:7542:0:b0:6dd:ddd8:51e5 with SMTP id b2-20020a9d7542000000b006ddddd851e5mr145268otl.43.1704719150318; Mon, 08 Jan 2024 05:05:50 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240104193303.3175844-1-seanjc@google.com> <20240104193303.3175844-8-seanjc@google.com> In-Reply-To: <20240104193303.3175844-8-seanjc@google.com> From: Paolo Bonzini Date: Mon, 8 Jan 2024 14:05:38 +0100 Message-ID: Subject: Re: [GIT PULL] KVM: x86: SVM changes for 6.8 To: Sean Christopherson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 4, 2024 at 8:33=E2=80=AFPM Sean Christopherson wrote: > > A few minor fixes and cleanups, along with feature "enabling" for flush-b= y-ASID > to play nice with newer versions of VMware Workstation that require it. > > The following changes since commit e9e60c82fe391d04db55a91c733df4a017c28b= 2f: > > selftests/kvm: fix compilation on non-x86_64 platforms (2023-11-21 11:5= 8:25 -0500) > > are available in the Git repository at: > > https://github.com/kvm-x86/linux.git tags/kvm-x86-svm-6.8 > > for you to fetch changes up to 72046d0a077a8f70d4d1e5bdeed324c1a310da8c: > > KVM: SVM: Don't intercept IRET when injecting NMI and vNMI is enabled (= 2023-11-30 12:51:22 -0800) Pulled, thanks. Paolo > ---------------------------------------------------------------- > KVM SVM changes for 6.8: > > - Revert a bogus, made-up nested SVM consistency check for TLB_CONTROL. > > - Advertise flush-by-ASID support for nSVM unconditionally, as KVM alway= s > flushes on nested transitions, i.e. always satisfies flush requests. = This > allows running bleeding edge versions of VMware Workstation on top of = KVM. > > - Sanity check that the CPU supports flush-by-ASID when enabling SEV sup= port. > > - Fix a benign NMI virtualization bug where KVM would unnecessarily inte= rcept > IRET when manually injecting an NMI, e.g. when KVM pends an NMI and in= jects > a second, "simultaneous" NMI. > > ---------------------------------------------------------------- > Sean Christopherson (4): > Revert "nSVM: Check for reserved encodings of TLB_CONTROL in nested= VMCB" > KVM: nSVM: Advertise support for flush-by-ASID > KVM: SVM: Explicitly require FLUSHBYASID to enable SEV support > KVM: SVM: Don't intercept IRET when injecting NMI and vNMI is enabl= ed > > arch/x86/kvm/svm/nested.c | 15 --------------- > arch/x86/kvm/svm/sev.c | 7 +++++-- > arch/x86/kvm/svm/svm.c | 18 ++++++++++++++++-- > 3 files changed, 21 insertions(+), 19 deletions(-) >