Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1613712rdb; Mon, 8 Jan 2024 05:11:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IFX7tlAcZu3QeWiiQ39c9CtgGa77buotrjSjmZ8PT9FB3q4o4OqUycANRaWLA6UcIqm/oMR X-Received: by 2002:aa7:800d:0:b0:6d9:b896:5e9b with SMTP id j13-20020aa7800d000000b006d9b8965e9bmr4017418pfi.60.1704719474669; Mon, 08 Jan 2024 05:11:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704719474; cv=none; d=google.com; s=arc-20160816; b=djJdWL4C/jNn3cX/LjvgLKlaZj2LR/V0ZqBBYS1lTA6bglmNhvOChWik1nFCVMsRsn u73rVBDLEL0EsJ3OOh//2hNqY4QJBWgXaNIgepDbbLXmj5PlSne6sZteEu6qieoos4mk vL5MU2UL2qIM9JnU9IK7UX+313CrkS38yDc0xKMywopK86Y+DK8k8/WzECSOPY8X9W6D LRvxDtSdrGKWd0UjaASL2+Z6ocEiItOzix8h8WK2S5BCMg7AT25QFlbc1OCZUi/daPAn 6bAbSMSO1g3mnIztYETF80NUZNyld3TQjWHPgcp8VVJJ5uAxC5pl7OlACVNeGQRt6/7s e/2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=VcTVB2Iqshb4RYIhqfZS5dp7wziOHA1zpUm3JxbuyhE=; fh=AMQPRQprTslEcjl3jv01hG7gjPUEpIFK5ln7biL5sfM=; b=VGSUwYyBQvXxgVOTQBqbdPJfEXYU5pPDFxLYsaWfu4ZbNFreBfA4TQ8rKCtctkI5mf V9Nzi5H3Y4cJqGs7I45AtuH9kwHhfuap7+aq7C/cpXaodM1yx4/Ps6mUmsuH1Fz5cygl CgD1MK4zAFTB96OnGcZ5vSGdHdvNqaPfGaML+cfAyQ8W4YKhnLZt3IIj0iRMSv2p3Hoj bKBlXps5ZdiT8Cf38HX7Auy3HGxOz4HYJcw6hUFXOgRyvKQ0qn/0GnRiEzp68NKvol0Y 6GkOz+VdVR0FVCeTpS1RO8wgatLtFbsyWGNCSDmKHYEOCp5ob5JblNzJyS+Rzl9v1SRd WanQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=TSpRTgSG; spf=pass (google.com: domain of linux-kernel+bounces-19592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19592-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id m21-20020a6562d5000000b005cdaa1686e9si5869379pgv.755.2024.01.08.05.11.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 05:11:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=TSpRTgSG; spf=pass (google.com: domain of linux-kernel+bounces-19592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19592-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 63B68B21FDD for ; Mon, 8 Jan 2024 13:11:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5134844C7F; Mon, 8 Jan 2024 13:10:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TSpRTgSG" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D16641208; Mon, 8 Jan 2024 13:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704719442; x=1736255442; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wb4zIKFOfFxBuDXZB8HXoCbo185XhuliuaB2tqVha7U=; b=TSpRTgSGn9WKTavlBp9WLGrSeziPftaZe6RDcGzFxxBcTlBvJXnt5ZTM hLH7B/xuq1OJf5sL0S3DxCUVIuqdF0AF4STB+6qAeGNW7y26YMdaL3P6M H0KG8N2ImPB1eju9vFbfmjyOkYO7pQRe8J1y8WFqrzxamL6lQAODRs+GT 5mYmRxIZgSwgUg/IxatmW8JmIdeyc1a5oUQGtz8omv+utfE1ZkQ8tfJJu AFCrpLNQCZy9ykK30X+tWaJKvTcRvw+KnyST4dq6HurFMdl2yoFtY6sTW tHhZtwzCv+xC6jxizhf+CCxa5HJ7UVaq8dsPxNYK62+/2oZ5xjyKCtIa8 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="462166788" X-IronPort-AV: E=Sophos;i="6.04,341,1695711600"; d="scan'208";a="462166788" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2024 05:10:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="954626861" X-IronPort-AV: E=Sophos;i="6.04,341,1695711600"; d="scan'208";a="954626861" Received: from ddraghic-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.251.212.53]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2024 05:10:36 -0800 Received: by box.shutemov.name (Postfix, from userid 1000) id 3DF8310498C; Mon, 8 Jan 2024 16:10:34 +0300 (+03) Date: Mon, 8 Jan 2024 16:10:34 +0300 From: kirill.shutemov@linux.intel.com To: mhklinux@outlook.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, luto@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, thomas.lendacky@amd.com, ardb@kernel.org, jroedel@suse.de, seanjc@google.com, rick.p.edgecombe@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 2/3] x86/mm: Regularize set_memory_p() parameters and make non-static Message-ID: <20240108131034.rm3kxtptguiai57a@box.shutemov.name> References: <20240105183025.225972-1-mhklinux@outlook.com> <20240105183025.225972-3-mhklinux@outlook.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240105183025.225972-3-mhklinux@outlook.com> On Fri, Jan 05, 2024 at 10:30:24AM -0800, mhkelley58@gmail.com wrote: > From: Michael Kelley > > set_memory_p() is currently static. It has parameters that don't > match set_memory_p() under arch/powerpc and that aren't congruent > with the other set_memory_* functions. There's no good reason for > the difference. > > Fix this by making the parameters consistent, and update the one > existing call site. Make the function non-static and add it to > include/asm/set_memory.h so that it is completely parallel to > set_memory_np() and is usable in other modules. > > No functional change. > > Signed-off-by: Michael Kelley Acked-by: Kirill A. Shutemov -- Kiryl Shutsemau / Kirill A. Shutemov