Received-SPF: pass (google.com: domain of linux-kernel+bounces-19604-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 8 Jan 2024 09:18:49 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Oliver Upton <oliver.upton@linux.dev>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>, ankita@nvidia.com,
	maz@kernel.org, suzuki.poulose@arm.com, yuzenghui@huawei.com,
	will@kernel.org, alex.williamson@redhat.com, kevin.tian@intel.com,
	yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org,
	gshan@redhat.com, linux-mm@kvack.org, aniketa@nvidia.com,
	cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com,
	vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com,
	jhubbard@nvidia.com, danw@nvidia.com, mochs@nvidia.com,
	kvmarm@lists.linux.dev, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	james.morse@arm.com
Subject: Re: [PATCH v3 2/2] kvm: arm64: set io memory s2 pte as normalnc for
 vfio pci devices
Message-ID: <20240108131849.GG50406@nvidia.com>
References: <20231208164709.23101-1-ankita@nvidia.com>
 <20231208164709.23101-3-ankita@nvidia.com>
 <ZXicemDzXm8NShs1@arm.com>
 <20231212181156.GO3014157@nvidia.com>
 <ZXoOieQN7rBiLL4A@linux.dev>
 <ZXsjv+svp44YjMmh@lpieralisi>
 <ZXszoQ48pZ7FnQNV@linux.dev>
 <ZYQ7VjApH1v1QwTW@arm.com>
 <ZZhpt8vdlnOP7i82@linux.dev>
 <ZZvWzyNb1V29-H85@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZZvWzyNb1V29-H85@arm.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jeATqOI0WJw9XRA58JpP7wHzHZj35fK1Z39aLQs4RZojfiejnI2KrP71+Hqp?=
 =?us-ascii?Q?iFlEXqr9+AebV+C/guc4r9eqb4q/8E8qDbbLOjtLml+AzdWtICJh0g3wky76?=
 =?us-ascii?Q?XoiWHI9Pzi39Dddz9CrLv7m1YKxqIh5k+7Ct3XpBXsTa06NDVMR75i5Vu4k2?=
 =?us-ascii?Q?wN6R+dZ798xZVQQrB3VFGeiqP7XDY6i5IV6A4AYHFNRXObLNij4PUjznjhr2?=
 =?us-ascii?Q?BGJ2KIvQlwkBWZicwYBUAl/p1zc9FFXyWvu8Jkl/I90EbMCf4nQ3rL5NfUHm?=
 =?us-ascii?Q?T0VyGMatHOcjOn7pRjf/P7P3YvGSaG5OqObM2B1C8cYSBh5NESYOnBWIDj3H?=
 =?us-ascii?Q?rTboNrwQieYkDPWna0IaaEevaQZKpuJF+EUuKNv7sKDESHOd07T3xRnvd0vz?=
 =?us-ascii?Q?ql7jmEFWhJw3h44ENF22R8v+tdRSetAsiei3U/8a48DpLxXw5nwKb7a6KQ/9?=
 =?us-ascii?Q?i9zW4czP6rx5tU0PuxuENxO4T/sbsUbcyUEyb13IlhKZSp4OyUzeWy528Atv?=
 =?us-ascii?Q?qBmrOzdaC6979V6vsAa9l5SeocFEPW6H/Any0Kr5iNNAAPyqM2HfaHqkRti8?=
 =?us-ascii?Q?XGVF+T9dN+lWKFWkuWIuEgf8KBJA+6YXlw3MrqD7I3Pr1+GFffH4Pg9XuwR7?=
 =?us-ascii?Q?otr5XX+dC7p1Uh0IDT3121Uj6T/QphSBekF/NQEWMRVyXp4siSu0Iec4Dfnw?=
 =?us-ascii?Q?FvUtsWmdfy5YscEUaIJmO4LsJnsCX9JCVR9VR6Mh29/TrcFYNpFnnNp697K8?=
 =?us-ascii?Q?5D/eeaA+HiKvSj70KkKr3wcw/LayjPLXkWkccYYsmW5jvT+g/XYuw5ezVrGd?=
 =?us-ascii?Q?7p8D24QBELKQ5IAfsR/Tt1eluvaASaokSlTslYUJafcp7vXrRzld2culuNux?=
 =?us-ascii?Q?KSfIf+C3t7H80io5yigFFd+Qr93BCHZcEGY/cokb3ojszvXaO0rwnUf5tUKW?=
 =?us-ascii?Q?3vi1IrWXxPbRgv1YtgEy9moyUsF+Y4f92U3MR3aF1/zfdspHCd/mM7ceahXC?=
 =?us-ascii?Q?TebgH5mxgxXAc7mkCTDtmvsMpLbWZo3jaGg/aJ83E4/83+Y+8UwRtt3ahjJ+?=
 =?us-ascii?Q?Y13OmfQzTqYSYU4Jqn4y5JnInt2MwEHjfAr233hfSI+6F4OmUaMKYmKeasn6?=
 =?us-ascii?Q?ACdJKYMY75+dDKQTVUSoiliTCTpVI2k1kUWbn5tehugIGPM7+qh4/9e4GxJD?=
 =?us-ascii?Q?sWI+hndoRPxFGgFjG+isqhfIELkA7GGxAshVw6owPTevn1sh1fcA7ciJksji?=
 =?us-ascii?Q?2mb6qzmXWPhkYhje/f/t/8Ik72EgIHCsa/ZG1UPckPj7lM5W05xH1xWPBCwV?=
 =?us-ascii?Q?Qe5N3SaezISKQOK6kJ6UmfBD37BUWrHFCwU9aDpFHwYermcU0etCfVbQv34y?=
 =?us-ascii?Q?OjRyZbWqOjHkd2LEJ9Zt546BhTEKEQYn4rVAyGK5Yga0PYtMxsimIyqL1Zr0?=
 =?us-ascii?Q?2QjPkqlxXIosOYc57m/2X54CTLkGck+JJv+TrprErJ8V3Kpz323qlEGOkm0y?=
 =?us-ascii?Q?WBwySqGFqp6/KzyZZIQpV887OeGPqwsSj39HRORi4r7kxvo3yOTtKjt6WV/+?=
 =?us-ascii?Q?XYxUtrpZ6RxHykYlBTQ=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cf764f7-a2e0-467d-26a3-08dc104c5a56
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 13:18:50.0863
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VIllbjkq9USLBvXFmFJZvzOXvDdCr8BGePN3NnmkBC+s393yA5V4khh4g3FK0WZg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8349

On Mon, Jan 08, 2024 at 11:04:47AM +0000, Catalin Marinas wrote:

> If we want to keep this decision strictly in user space, we can do it
> with some ioctl(). The downside is that the host kernel now puts more
> trust in the user VMM, so my preference would be to keep this in the
> vfio driver. Or we can do both, vfio-pci allows the relaxation, the VMM
> tells KVM to go for a more relaxed stage 2 via an ioctl().

What is the point? We'd need a use case for why the VMM should have
the ability to create a more restrictive MMIO mapping.

I can't think of one.

So I'd go the other way, if someday we find out we need more
restrictive then the VMM should ask for more restrictive (not weirdly
ask for less restrictive)

Jason