Received-SPF: pass (google.com: domain of linux-kernel+bounces-19620-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Feedback-ID: ifd194980:Fastmail
References: <20240108032233.4280-1-garyrookard@fastmail.org>
 <20240108032233.4280-2-garyrookard@fastmail.org>
 <897a8bb4-a1d7-46ab-96cf-fd5ba447d2d8@moroto.mountain>
User-agent: mu4e 1.10.8; emacs 29.1
From: Gary Rookard <garyrookard@fastmail.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com,
 linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: rtl8192e: rename variable is40MHz
Date: Mon, 08 Jan 2024 08:22:59 -0500
In-reply-to: <897a8bb4-a1d7-46ab-96cf-fd5ba447d2d8@moroto.mountain>
Message-ID: <87edesvtrx.fsf@fastmail.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Dan Carpenter <dan.carpenter@linaro.org> writes:

> On Sun, Jan 07, 2024 at 10:22:29PM -0500, Gary Rookard wrote:
>> Coding style issue, checkpatch avoid CamelCase,
>> rename it. is40MHz -> is_40mhz
>>=20
>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>> ---
>>  drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>=20
>> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging=
/rtl8192e/rtl819x_HTProc.c
>> index 6d0912f90198..1b1cb9514028 100644
>> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
>> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
>> @@ -87,36 +87,36 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device =
*ieee, u8 mcs_rate)
>>  {
>>  	struct rt_hi_throughput *ht_info =3D ieee->ht_info;
>>=20=20
>> -	u8	is40MHz =3D (ht_info->cur_bw_40mhz) ? 1 : 0;
>> +	u8	is_40mhz =3D (ht_info->cur_bw_40mhz) ? 1 : 0;
>
> This should be is_40MHz.  It's metric.  M means Mega.  m means milli.
>
> regards,
> dan carpenter
=2D-
Okay, stupid me didin't give it to much thought that way,
...wow there's more that way then just mine
Good catch!
Regards,
Gary

=2D-=20
Sent with my mu4e on Void GNU/Linux.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJNBAEBCAA3FiEE1kC7bOvmQRqDVDSVKPZpkA66T0EFAmWb+IIZHGdhcnlyb29r
YXJkQGZhc3RtYWlsLm9yZwAKCRAo9mmQDrpPQfB2D/wMrp1lzEC55gNvoPeTt0SU
APGp93g3eBBubhjei5ZjQ9k6qEQ5NvGdp8GruqR09AOjEADDnicItzDUVcx6G7IQ
r4dMqJe8OzFCv4vGv6TTfD/XxT3w9qj0fbDILJ7O7SAHb5xtKVXDLt0aPkIhk+iV
uPwoCWZ/pxTwOIGQTq4vAnhBEDw7TUYX/PZ+NOOUp6P2QfPaIvz7/woZA0vYSEnY
TsgGQoHE5PQzplSS7jXdJINoSiq7hIugpOixBo06Qw1M8QBN2haNsr+26CRgHyMI
4SG7nuLjbJ32MrA8Q22Vr6r2LLMzss+kkIPcVwRidWLm3dZCsRxqgLEMWfLLpMT+
TVmtKsM8I6e51mFFPJKNXm3BgQZmeCqfnpoN313wxJ+PyLthnc6mQO0+ZerlsLCx
RJOWDH+CQeJxm0DP9CPDbGAu8gQfl6TDMYRfU9bPNq85rYghg8aSCbuWXKyt4zSD
0i7xkW9GfSR5Iwi2IWxCYWWcB84GKtu10QLJb+o2NR6GhbNJMwPYU+ivjTCdBh2E
iLukcfv8GkK7Da/GMa1knyLh7i1R8Hls9QxsyHgGdxqJHPhDB9gDQLtC8/Cy73eH
GcOYY/CQxQscMxqxYLAOG0U3+Vj9I1t2W2UpVXu2xNA6YIMi8og+/Fq8vGhl4lhY
V89LSUKBcXEw4naf7/s9tA==
=rPq8
-----END PGP SIGNATURE-----
--=-=-=--