Received-SPF: pass (google.com: domain of linux-kernel+bounces-19628-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 8 Jan 2024 08:37:33 -0500
From: Mohammed Billoo <mab.kernel@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>, Marek Vasut <marex@denx.de>,
	Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>,
	Biju Das <biju.das.jz@bp.renesas.com>, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-ads1015: Use correct pga upper bound
Message-ID: <ZZv6nV+BxJFF7Nx9@system76-pc.localdomain>
References: <20240106174836.1086714-1-mab.kernel@gmail.com>
 <20240107161524.7dc72a3f@jic23-huawei>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240107161524.7dc72a3f@jic23-huawei>

> Seems correct, but I'm curious - did you see an actual problem with
> setting the value to 6?  From my reading of the ads1115 datasheet
> 6 and 7 should be functionally identical to 5.

Hi Jonathan,

No, the behavior was fine. When I was trying to adjust the voltage range via the
pga setting, I noticed that the implementation didn't match the comment in the binding
for the max value.