Received-SPF: pass (google.com: domain of linux-kernel+bounces-19637-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240108072253.30183-1-qiujingbao.dlmu@gmail.com>
 <93695e92-233d-460c-a6bd-882b30f1dea8@linaro.org> <CAJRtX8T-88x=AeRhOVJP=1ccvOZa-nS4cDEjpSykTxFMRupKZg@mail.gmail.com>
 <7af6c688-3d3e-4cd5-bbd6-4ca323d7edde@linaro.org> <CAJRtX8QzDQjMCqXw9BnWPFt5FT3qr9=95F1rpwz_795AF9oSAA@mail.gmail.com>
 <c4d1a68a-815f-4585-b600-9b2e049791c9@linaro.org>
In-Reply-To: <c4d1a68a-815f-4585-b600-9b2e049791c9@linaro.org>
From: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
Date: Mon, 8 Jan 2024 21:42:47 +0800
Message-ID: <CAJRtX8TTtPJkfQXSCiwLrFon8SFpyS0Hxi_Pc9Wro=fk66W8Tg@mail.gmail.com>
Subject: Re: [PATCH v5 0/1] dt-bindings: riscv: sophgo: add RTC for CV1800
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com, robh+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, 
	paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, 
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 8, 2024 at 5:28=E2=80=AFPM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 08/01/2024 10:11, Jingbao Qiu wrote:
> > On Mon, Jan 8, 2024 at 5:06=E2=80=AFPM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 08/01/2024 10:00, Jingbao Qiu wrote:
> >>> On Mon, Jan 8, 2024 at 4:02=E2=80=AFPM Krzysztof Kozlowski
> >>> <krzysztof.kozlowski@linaro.org> wrote:
> >>>>
> >>>> On 08/01/2024 08:22, Jingbao Qiu wrote:
> >>>>> Real Time Clock (RTC) is an independently powered module
> >>>>> within the chip, which includes a 32KHz oscillator and
> >>>>> a Power On Reset/POR submodule. It can be used for time
> >>>>> display and timed alarm generation.
> >>>>>
> >>>>> Power On Reset/POR submodule only using register resources
> >>>>> so it should be empty. The 32KHz oscillator only provides
> >>>>> pulses for RTC in hardware.
> >>>>>
> >>>>>
> >>>>> Changes since v4:
> >>>>> - remove POR dt-bindings because it empty
> >>>>> - remove MFD dt-bindings because SoC does
> >>>>>   not have MFDs
> >>>>> - add syscon attribute to share registers
> >>>>>   with POR
> >>>>>
> >>>>> v4: https://lore.kernel.org/all/20231229090643.116575-1-qiujingbao.=
dlmu@gmail.com/
> >>>>>
> >>>>> Changes since v3:
> >>>>> - temporarily not submitting RTC driver code
> >>>>>   waiting for communication with IC designer
> >>>>
> >>>> Hm, why?
> >>>>
> >>>> We do not need bindings if nothing matches to them. If this binding =
is
> >>>> for other upstream open-source project, please provide references.
> >>>>
> >>>> See also:
> >>>> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devic=
etree/bindings/submitting-patches.rst#L61
> >>>>
> >>>
> >>> Hi!
> >>>
> >>> There is a function in the RTC driver code used to calibrate the
> >>> clock, which is define in the datasheet.
> >>> However, Alexandre Belloni raised concerns that clock calibration
> >>> should be done using GPS or similar
> >>> methods, rather than using other clock sources. I think what he said
> >>> makes sense. So it is necessary
> >>> to communicate with IC designers.
> >>>
> >>> link: https://lore.kernel.org/all/202312271350242a208426@mail.local/
> >>
> >> Sure, this I get, but why sending bindings alone? There is no user of =
them.
> >>
> >
> > Thank you for your patient reply.
> > May I ask if this user refers to driver code or DTS?
>
> Anything. Any user.
>

Thank you for your suggestion. I will include DTS or all of it in the
next version.

Best regards,
Jingbao Qiu