Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1634576rdb; Mon, 8 Jan 2024 05:51:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IH9gUu0OMwwFpevUXe7Z+Px4IzODoCZ6dfGR2jhCOI19u6Mf9QBQfOW9dPA30mXunLu7RzZ X-Received: by 2002:a50:d705:0:b0:554:4ad0:f4a6 with SMTP id t5-20020a50d705000000b005544ad0f4a6mr2024015edi.13.1704721869791; Mon, 08 Jan 2024 05:51:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704721869; cv=none; d=google.com; s=arc-20160816; b=EhhWa75i3sDQ6a3zqPGbNIe+8PahzzJ44FNupr99Lu6JL82saBGR01vgJ24SeQb1iV VQ0QEbZqJjvXoQWIP7+Z0bN7IK4e4JMFMpUp6ewq1Giw0ABLzy6+sSnkchW4SIOAiGIK s6Z9wtN3YuSOKSr8wE6evDpAjJeWprCcdver4HZCU9kARpK6F/g1Nbqb9No8UWmhw+sk Be0DhXikCFQlYDHE+NyDSN+XsmqbmC3f4z/CV5RbVTIzaxPwOcquM19Z0MmSWRX9f1HR ASvLhsmIVHNLjOmkgsV1rRg7dGlI5pbxWfVKEvwiZzEYxeKfZ4h797ZDIq8TymW34Y37 QC1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IMoMvb9scX3hSPn85HFoM80PBcRksMLJGosthKdKK2M=; fh=oG7bweP8IWaFLtRAWiiDNwM/Uy9ksCy4A8hSxbvLJdk=; b=QbdpNVEP9wpr6lJHUdO4Kk+fitVeLu6zhA2Hza6UrFnNZpsqznnahyiYVMeu0zug3d MPMmFiOSR7hvAKL8chErfNudmoXG0LV1QhZu1YlspOGbuIuryAfa+XSwYNXNEBN5CjAZ mJUcJwHR7C2GHR1pSbS5N0IQKn+Dc2LgjXHUb6L7y1id1q1TUjTjmKHPYK1xs9GNFVcp 2i6PBm859IRwbMflDmuL0K0gqCJjUt1Amdcq+GZfgPThSoGhGMm7rbRMcsAKvIG8cRkD npYP+/8QZRZqlJbxHirvVMt/0fkl5iToDHtfNR26iUStZg/c+JijL9Z1vaVw/6AJ0Lav /y4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="H/5qxa2K"; spf=pass (google.com: domain of linux-kernel+bounces-19649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19649-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id t7-20020a056402524700b0055637946487si3372520edd.235.2024.01.08.05.51.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 05:51:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="H/5qxa2K"; spf=pass (google.com: domain of linux-kernel+bounces-19649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19649-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8B1421F2330B for ; Mon, 8 Jan 2024 13:51:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 120A945BE8; Mon, 8 Jan 2024 13:49:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="H/5qxa2K" X-Original-To: linux-kernel@vger.kernel.org Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F40604776B; Mon, 8 Jan 2024 13:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=IMoMvb9scX3hSPn85HFoM80PBcRksMLJGosthKdKK2M=; b=H/5qxa2K/VCzBB6dRHUwn+H31o d4VdKzFIFF9jfRpcATe59ZZj/9H2Sgm07nySFurYE84T+vN3Na8BLzv79KL4gHapKMALpHzxKPrlS LvQPszBFegf6SIW/g1iWIn1I32FUJ9+TeaPYyPX8EROJKstUXYPz5EOKGXHj+zZ2aLA8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rMpzy-004dzf-OL; Mon, 08 Jan 2024 14:49:02 +0100 Date: Mon, 8 Jan 2024 14:49:02 +0100 From: Andrew Lunn To: Dimitri Fedrau Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Stefan Eichenberger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 net-next 1/5] net: phy: Add BaseT1 auto-negotiation constants Message-ID: References: <20240108093702.13476-1-dima.fedrau@gmail.com> <20240108093702.13476-2-dima.fedrau@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240108093702.13476-2-dima.fedrau@gmail.com> On Mon, Jan 08, 2024 at 10:36:56AM +0100, Dimitri Fedrau wrote: > Added constants for advertising 100BT1 and 1000BT1 in register BASE-T1 > auto-negotiation advertisement register [31:16] (Register 7.515) > > Signed-off-by: Dimitri Fedrau > > Reviewed-by: Andrew Lunn Sorry, more nit-picking :-( Signed-off-by, Reviewed-by:, Fixes: etc should all be together. No blanks lines between them. And Signed-off-by: comes last. Given the missing statics, it looks like you will need to repost in two weeks times. Andrew