Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1637085rdb; Mon, 8 Jan 2024 05:56:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSR8F/2NbihwpPd8we6q0e7fUzq7p01Ew7eXlf5XPhPm44Pp92MSe9AOAcbTzdXEcCB9ag X-Received: by 2002:a25:5f44:0:b0:db7:dacf:6fc9 with SMTP id h4-20020a255f44000000b00db7dacf6fc9mr1572410ybm.81.1704722181990; Mon, 08 Jan 2024 05:56:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704722181; cv=none; d=google.com; s=arc-20160816; b=BFmj1zSs4dzqZH1U8qNjRjcXHwvg8pzP9pd76OCb6t5kNw713F6xlGApOk95z6nxwQ lYL8m09jqyk5f1pVfpIeIItzik9vcv9B+CvuJLpYrNrx9IIATQR917OJ6RZEyDhyRqLB XIi/Jr+yRRMGpeYZzKYMCYVyXc21BXX9Uh7U1KUCVoTmeWRmZs/ybmbryrBFWXmrhFA+ HkGG8nLjPSWGy4v+ml2GnXLEeeZuPOlN0EDiGxuwETfUL1Dumq3FNuViF/eSCNk4Q4cG 9Bzw8C5Eh+1Te0vGO93tS5gjpldtgwHioaoBPnWglLv2uaxDjtIscWHRy/kWS0dzA5kw ONrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:from:content-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:cc:to:references :in-reply-to:organization:dkim-signature; bh=3cwOcp1MFrryPduML1Amlp6Emi0Gczn0iuACZPucAo0=; fh=hJi8rcqavC/8P1ByTEKmkvOgZuG0cq95evuRQFHl7fM=; b=jRjIO5JNbmM5tUcMwjZz5zfV6nJw2l5zTNzjMQxZZ7+ZJQ7y8xkII6KphsDSrd/CLI 5QwwhJBA6565D6KD/r08mSzmxpTuiR6qCZMmJz2sKbgHAx7SbVJSBcu9ZeDklpduEqRy CZ+UWCSsGoiMbm9tITNFctPAGNj0jm5jh7D/RQVZlDMd4SpmHZXWoAPYtzYS4Xg2y3Jf eOCSpkjkIfT53CMtLZp9WMcMaqksyf+LB38fgSWgTld0pVOrNS+OnHHlNzekP0U1TMlo 2NR1CwfLe7q5bnTVCIst6fz0vVcuHu6gv7wTqOKXBPOAzFn8IkQQy+1T7SsTt0411HsX CSTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HRDlQNCx; spf=pass (google.com: domain of linux-kernel+bounces-19656-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19656-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u38-20020a05622a19a600b0041cbafcc5a9si7858893qtc.636.2024.01.08.05.56.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 05:56:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19656-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HRDlQNCx; spf=pass (google.com: domain of linux-kernel+bounces-19656-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19656-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BE2251C21518 for ; Mon, 8 Jan 2024 13:56:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9659546524; Mon, 8 Jan 2024 13:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HRDlQNCx" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64A0446553 for ; Mon, 8 Jan 2024 13:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704722161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3cwOcp1MFrryPduML1Amlp6Emi0Gczn0iuACZPucAo0=; b=HRDlQNCxqH/N8XC5fUxd9eZSuYahQb+/WIzpOFUr6bLrz3twE0E5CwTWtqa1ZDvMaVShzN HQR+Suqhe65TAanu2UehluJbPfm/Yt6EAwjPFU5vDadVFMUj/9B52SzkLDH5DA9qq5YI1k hT2yCQMdbXVPbMY7v2XFc2zhr0Bf1Ys= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-atEy6GbmOziBnIbtdvJL3w-1; Mon, 08 Jan 2024 08:55:58 -0500 X-MC-Unique: atEy6GbmOziBnIbtdvJL3w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C356B29AA389; Mon, 8 Jan 2024 13:55:57 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id F419240C6EB9; Mon, 8 Jan 2024 13:55:56 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 In-Reply-To: <20240108101404.19818-1-duminjie@vivo.com> References: <20240108101404.19818-1-duminjie@vivo.com> To: Minjie Du Cc: dhowells@redhat.com, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v1] netfs: use kfree_sensitive() instend of kfree() in fscache_free_volume() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1522541.1704721959.1@warthog.procyon.org.uk> From: David Howells Date: Mon, 08 Jan 2024 13:55:56 +0000 Message-ID: <1522761.1704722156@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 You sent this twice - I replied to the other post. But this is an unnecessary use of kfree_sensitive() as the key is made public. David