Received-SPF: pass (google.com: domain of linux-kernel+bounces-19677-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <ed28cb13-12b7-42f1-8a44-48454b629d1b@nvidia.com>
Date: Mon, 8 Jan 2024 08:09:19 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2] PCI/MSI: Fix MSI hwirq truncation
To: Vidya Sagar <vidyas@nvidia.com>, bhelgaas@google.com,
 rdunlap@infradead.org, ilpo.jarvinen@linux.intel.com, tglx@linutronix.de,
 jiang.liu@linux.intel.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 treding@nvidia.com, jonathanh@nvidia.com, kthota@nvidia.com,
 mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20240105134339.3091497-1-vidyas@nvidia.com>
 <20240108120522.1368240-1-vidyas@nvidia.com>
Content-Language: en-US
From: Shanker Donthineni <sdonthineni@nvidia.com>
In-Reply-To: <20240108120522.1368240-1-vidyas@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cVJQa3F0YkdRWW9UQnNsNEtRU1dsVlJJL2VPR0x1ZkRNb01HT1J6U2Q4cFRM?=
 =?utf-8?B?aGptb1l1WXdBeUJvYXdXQWpVMkJyYTRZT1hUYTlTZ2tydVQvVmN4UWJEMW9V?=
 =?utf-8?B?UFFZc3JjV1dVZ091emJIVUpXYmpNWitTQzZwWWRxekNvY1RxbHRHbkpIV2Jm?=
 =?utf-8?B?MzZZVmswSXB1STFVcFVmU2k1bDRZelJxT1dWQ1cvQmVDdHR4cm93dUhiSzR5?=
 =?utf-8?B?TzA2aWRWeDlnQmxvdENoWCt4K0xvdDQrMXBkTzcwckUzQ2NkTk1nbHRFeGpL?=
 =?utf-8?B?cms4emFwbFVad25YQjd2OGlnV0orVEI2RHJQZ05zSnhnQXlnTEVKelhEOVdy?=
 =?utf-8?B?Njg2Y0RXcDZRWmtYVDRWZXFPZ29wL0QvdVpORTY4ZjFFRE10RERsbUxEYjZB?=
 =?utf-8?B?bkJ5OXBpTUxXRXZXVjdUVnd6elJiTVBxTnVSRmpQeFZJRlYyS2s5QzZWZjRn?=
 =?utf-8?B?K3JmajdSNTZXQjBHWXlRRFI4ZEcrajM1bSsvZEEySitEMXU4V3k0YndlcHVv?=
 =?utf-8?B?WjR5R2xOc2NXNWlCYnQ5SFBBekxyUTNWaGNiL0sybnVUZjhjbDQxdmRsR2I2?=
 =?utf-8?B?Z1JGbUd0WmhRNFdaOWc4VGlwL1ZiU1pxZGlEcHY4MmptN0lqekdadzNOMGZ1?=
 =?utf-8?B?ZjBocXk1cHBNOThYVXBWQWdvOW1KZnh1QUl2b2VLZEo1OUlZTmdZL1dJWUM5?=
 =?utf-8?B?ekp5WUJscDRFMHVaNXpITWZIb1l6dTg5dk0wTFBmRXd1UmhsS2h1aGdsN2M3?=
 =?utf-8?B?c3I2RVVWTWdPeGdzdUZudXV3cHp6ZFFVS1pDOGZkV04xWS9SbkVsam1WOFFn?=
 =?utf-8?B?UUZTZWlrTTFaQ0NUcGVkWE80cUJJbnY5eCtWWkFGcE5saS9LOUdJRHFHVEEz?=
 =?utf-8?B?b0dpVTBuQmhRdVd6MXN0N3kvRDhXbGJScTJ1Ulk4NjY5UGQ1aWw0UUVNQTc3?=
 =?utf-8?B?RUxRSW83R1RJRGpvaStuWXZmTFhjeDk1S0JqRGUvMDNSdlU0NXYwcE9NTWhJ?=
 =?utf-8?B?WE9UbzB1UXRXTENQLzlab2YwM3hKdC93ZkxqVytQWmlnRVg4K2lSQUZ2RDhI?=
 =?utf-8?B?NDF1OWZESlNxVEZUcGt6TXNUbGZWTjZ6Ukl4ekhyVFMvQjJ6NzhYcCtVMjFE?=
 =?utf-8?B?TFVLYnJKc3JVTkFHTlplVUIvOG1pVHc3ck05TzFhY1hWS0hXVFFURXp6RUJM?=
 =?utf-8?B?SW4vajFmeVY1dHczeVBNeVIwMGMrL2NTMmJ3Snl2OTB3aldpWFZIaXNBVGNQ?=
 =?utf-8?B?eGZWU0hWY3hXb25ESGRacmJsS0U4bzlvSXl5ZG4rV1BwRDdZRFV1elh3WEJO?=
 =?utf-8?B?ZStWU3dIVlNYZEJSTDRURWU4THNnZlBvV1M3cDNIVDUvVHV5Q2RTN28yVTZr?=
 =?utf-8?B?ZzdKTHd6UzVTSDJyWjVuN3oxNy8zbndVR3k3MTJzbHBPeDd1d2JsdzFUaDdQ?=
 =?utf-8?B?RTc4b290S2pFZ2kzTUhHbzhGR0R5c3NiM2hFNjFLYWxSdGxCSFpjbmFWajdF?=
 =?utf-8?B?bEpKd2ZuR09VdUxnVGk4VmtyYlppcnd6UWtXaDNoSElKM0VSRHNtK0RTVlky?=
 =?utf-8?B?RGVzeWR3cm9NWVR6K0pYMEpRZGVwam5tMFdoUENBVStKV2V5TytLTVRMUXYr?=
 =?utf-8?B?SzJTb21KY0YxcERiMjJtVnViMm41bkVwcWVDT3NYR2ZIaldVZUZkWEJLWXJx?=
 =?utf-8?B?bUhpN0pkSlNTcGlvcm5EcFlXL0VvTEFlOTV5Sm1EVUgxNXRRQ042Ukgra0tX?=
 =?utf-8?B?VTZuZjMrVnFZMURkU3N0Z0Q0bXg3YStod3hPbyszQzZmSXBFTmRFYUJPNzRu?=
 =?utf-8?B?alhldmNSQVN6bk80RWxTVFVYaHJyT3FVS3hGRkl2Z3ZPZzNhcmNqTW5IR3hJ?=
 =?utf-8?B?d0hFcndZenZwdVZyYzFmSWpzakFuMmRWanUvbDltMXA4SlR5UjFQSVNHcUZn?=
 =?utf-8?B?WXR3dEJWQ0Y4d2s3UThhbWIzRTNmUzBhMDErbm84aDNCOEVxUFFBWkQ5dkhl?=
 =?utf-8?B?NEVZK2tob1FCR3FxNEpnR2E1ZjZEUzdrSUl3UENaNXFXOFovYiszV2ltN3dT?=
 =?utf-8?B?WU5hdzFhNXU2emxzL3h6SStHclRwTXZFOS9mSy90V3hvalhXVGxISms0L3Z3?=
 =?utf-8?Q?+dom+JXEVmJrjAnFznFQKv3qg?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 749ef92d-6fe6-4a43-b7a4-08dc10536af1
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5762.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 14:09:24.5310
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sy66cyNnFlTOFnjYwk8eMq3/ti4O4v6PXCimJ8fnLUfeZaBogIcFLoQTC4Jh3UL7uY+rU1FHPJUuPIw0sLX16w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5123

Thanks Vidya.

Tested-By: Shanker Donthineni <sdonthineni@nvidia.com>

-ShankerD

On 1/8/24 06:05, Vidya Sagar wrote:
> While calculating the hwirq number for an MSI interrupt, the higher
> bits (i.e. from bit-5 onwards a.k.a domain_nr >= 32) of the PCI domain
> number gets truncated because of the shifted value casting to u32. This
> for example is resulting in same hwirq number for devices 0019:00:00.0
> and 0039:00:00.0.
> 
> So, cast the PCI domain number to u64 before left shifting it to
> calculate hwirq number.
> 
> Fixes: 3878eaefb89a ("PCI/MSI: Enhance core to support hierarchy irqdomain")
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> V2:
> * Added Fixes tag
> 
>   drivers/pci/msi/irqdomain.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/msi/irqdomain.c b/drivers/pci/msi/irqdomain.c
> index c8be056c248d..cfd84a899c82 100644
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -61,7 +61,7 @@ static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
>   
>   	return (irq_hw_number_t)desc->msi_index |
>   		pci_dev_id(dev) << 11 |
> -		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
> +		((irq_hw_number_t)(pci_domain_nr(dev->bus) & 0xFFFFFFFF)) << 27;
>   }
>   
>   static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,