Received-SPF: pass (google.com: domain of linux-kernel+bounces-19771-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Mon, 8 Jan 2024 07:29:03 -0800
From: Guenter Roeck <linux@roeck-us.net>
To: Aleksa Savic <savicaleksa83@gmail.com>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (gigabyte_waterforce) Mark status report as
 received under a spinlock
Message-ID: <1eb8323b-6c5e-4646-8288-1e58ca7516e7@roeck-us.net>
References: <20231219143620.22179-1-savicaleksa83@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231219143620.22179-1-savicaleksa83@gmail.com>

On Tue, Dec 19, 2023 at 03:36:19PM +0100, Aleksa Savic wrote:
> Through hidraw, userspace can cause a status report to be sent
> from the device. The parsing in waterforce_raw_event() may happen in
> parallel to a waterforce_get_status() call (which resets the completion
> for tracking the report) if it's running on a different CPU where
> bottom half interrupts are not disabled.
> 
> Add a spinlock around the complete_all() call in waterforce_raw_event()
> to prevent race issues.
> 
> Fixes: d5939a793693 ("hwmon: Add driver for Gigabyte AORUS Waterforce AIO coolers")
> Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
> ---
> Does the above make sense? The raw event parsing is a softirq AFAIK and
> presumably could run on a different CPU in parallel to a waterforce_get_status()
> call.
> 
> Appreciate thoughts on this.

I think it does. Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/gigabyte_waterforce.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwmon/gigabyte_waterforce.c b/drivers/hwmon/gigabyte_waterforce.c
> index 1799377fc2f1..85e523775714 100644
> --- a/drivers/hwmon/gigabyte_waterforce.c
> +++ b/drivers/hwmon/gigabyte_waterforce.c
> @@ -276,8 +276,10 @@ static int waterforce_raw_event(struct hid_device *hdev, struct hid_report *repo
>  	priv->duty_input[0] = data[WATERFORCE_FAN_DUTY];
>  	priv->duty_input[1] = data[WATERFORCE_PUMP_DUTY];
>  
> +	spin_lock(&priv->status_report_request_lock);
>  	if (!completion_done(&priv->status_report_received))
>  		complete_all(&priv->status_report_received);
> +	spin_unlock(&priv->status_report_request_lock);
>  
>  	priv->updated = jiffies;
>