Received-SPF: pass (google.com: domain of linux-kernel+bounces-19779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 8 Jan 2024 11:38:18 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yan Zhao <yan.y.zhao@intel.com>, wanpengli@tencent.com,
	kvm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, kraxel@redhat.com, maz@kernel.org,
	joro@8bytes.org, zzyiwei@google.com, yuzenghui@huawei.com,
	olvaffe@gmail.com, kevin.tian@intel.com, suzuki.poulose@arm.com,
	alex.williamson@redhat.com, yongwei.ma@intel.com,
	zhiyuan.lv@intel.com, gurchetansingh@chromium.org,
	jmattson@google.com, zhenyu.z.wang@intel.com, seanjc@google.com,
	ankita@nvidia.com, oliver.upton@linux.dev, james.morse@arm.com,
	pbonzini@redhat.com, vkuznets@redhat.com
Subject: Re: [PATCH 0/4] KVM: Honor guest memory types for virtio GPU devices
Message-ID: <20240108153818.GK50406@nvidia.com>
References: <20240105091237.24577-1-yan.y.zhao@intel.com>
 <20240105195551.GE50406@nvidia.com>
 <ZZuQEQAVX28v7p9Z@yzhao56-desk.sh.intel.com>
 <20240108140250.GJ50406@nvidia.com>
 <ZZwTzsZqx-XSTKma@phenom.ffwll.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZZwTzsZqx-XSTKma@phenom.ffwll.local>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YGzcC6Z6zOpgqZiJ6/a30a/2JPrkmCq6TUDgiXsAOxmkKXE+15KHE0VMVB7n?=
 =?us-ascii?Q?RqvfLK3KEVKOspNChiXxig5ghy0kPbnic2LV8GsVGBUlmZLrAmNLPyJ6sHKD?=
 =?us-ascii?Q?85Q7zQb9GKJUwoct94R6zBEXsc52BbeERDY+AcgE2O+Tj+nQ2t59eXRjWGO2?=
 =?us-ascii?Q?jhWrXcWz5RAbtxfYL6ZrUiuI46Gxe2eJybKZS/yNovI30ZA1Y40QqZCJz+Ti?=
 =?us-ascii?Q?S0E/MslXp05tP47m4OkV5gnohOWp33/0dq25EGR/PB/7hU7WbyhKQXKGYi57?=
 =?us-ascii?Q?qEkgx5Gk286L1Dv4/+rxTRT5CaP70qmXCiSTUZShXstdEBqCy+Lxq9zzCKZ/?=
 =?us-ascii?Q?is0e3F54nabTReW8A4jfRa5A0hYBlrUDTBkfSitodaCQqh9YHEII66uTy3gm?=
 =?us-ascii?Q?RbrY6O35l/3Igf64oO0b93LDKRb8E52oSFnwBZNqTCrBW/7XKSaENdFVAjUc?=
 =?us-ascii?Q?X3onP4GMYYkXikqZFnUW00UWuBsVBgpAM5yNp+Nzjv9qIQ650uq4gB2+yp1U?=
 =?us-ascii?Q?vaLD5L6wI3v6PTUSN3u/ycNSGeXUC16/9SAHn6eMqA3jZsqufW5x3Xn9F3cA?=
 =?us-ascii?Q?w02wyWl+JP33upwBKnzd52iLKdpvSXgbKauNNyc8tWopag4fUhJtdhhL+jjk?=
 =?us-ascii?Q?6dcm4rodTgBXvLBo9YOJcAYI1DPzi01Bx4RFtm9b1g2RLKZtvPVasVNNtVzZ?=
 =?us-ascii?Q?8TwgZGu3WFNxnzd4PiEMpLBLLHBLHwrseI4EpW3MKeHDgYOiCKi0n2ifAd4k?=
 =?us-ascii?Q?eiZZY8emm0rVOloXbin16xz33iJDVSk1q0Xo2oOKHVtl3FIbmkmrtZNgYOZf?=
 =?us-ascii?Q?TQTTErk5MrM7p/oBH4X4MIFGRYQbLk+OULSoSZlKX5zWZ03Y4iucr3gneeaZ?=
 =?us-ascii?Q?hxnOdHWCvtSoQXE5dYdiX515kKXAuDW3CLPALmikAQ4DITU7kw0BtnU6AzYj?=
 =?us-ascii?Q?EyHs1TwHzeuT5fpk3Lmg2CJalxAn/zjKoyCDFybmFATVc5c2AzZ2RGtCZuoA?=
 =?us-ascii?Q?aP8elQlSuPptRMF6GHgK76e4OO9QRDtvHleLyI3PjCGF0vQog6eIdfX4S1g9?=
 =?us-ascii?Q?P+bRpGipW52lYpz/PErjfaoAJdqGPgcb/mFiS1ZWQvffnJ64Suga7a5peNO0?=
 =?us-ascii?Q?VmzsCX+0LjPry0OK4GB5QbJHq25nwv0CY1haQvROn97VusIDbqMMbLRRwZhT?=
 =?us-ascii?Q?YUNuI1iLiTjcRBpV9cywdphwIFF9Qsn3Dkc5qv96Zdr5mQyQ1A6RFeYuynxi?=
 =?us-ascii?Q?XJiUsAgdPdEjqR1MRlrLPhaMmkRW1ZC3DzAGk1u/zaDsN5vw8Xd0E/820Ip+?=
 =?us-ascii?Q?slo95CbERpmlC4w35uvEdNAAENYi0vGJ4/v4nMs9skDUvZrY785WzuH+BEIw?=
 =?us-ascii?Q?eHCc8GOViwuehDRR5W16ZBiyqoKaj5fjbov9e03KouZEpTTuucO8jP3lQL2i?=
 =?us-ascii?Q?pQ+oagcpguG+AEORALZBi+0+apRsAa0Iy0O4pE9f3EvYcF0+MhM5PaQPtF3n?=
 =?us-ascii?Q?SFZaeFr5TZfCwm4oG8dcwqSDtrycNxWsrgd0wLgD0terTu85x10IIjl9VbbX?=
 =?us-ascii?Q?p1dg6oB5dOqyQM/EKiY=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e47bb733-dd7e-4472-81c9-08dc105fd70c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 15:38:19.6827
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BHDJ0IhZDLVjxjvE/1kTpTlzCr5/R+62UCO6RiaPNGGrs0EhbQMMo2AvMawRDeNq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4395

On Mon, Jan 08, 2024 at 04:25:02PM +0100, Daniel Vetter wrote:
> On Mon, Jan 08, 2024 at 10:02:50AM -0400, Jason Gunthorpe wrote:
> > On Mon, Jan 08, 2024 at 02:02:57PM +0800, Yan Zhao wrote:
> > > On Fri, Jan 05, 2024 at 03:55:51PM -0400, Jason Gunthorpe wrote:
> > > > On Fri, Jan 05, 2024 at 05:12:37PM +0800, Yan Zhao wrote:
> > > > > This series allow user space to notify KVM of noncoherent DMA status so as
> > > > > to let KVM honor guest memory types in specified memory slot ranges.
> > > > > 
> > > > > Motivation
> > > > > ===
> > > > > A virtio GPU device may want to configure GPU hardware to work in
> > > > > noncoherent mode, i.e. some of its DMAs do not snoop CPU caches.
> > > > 
> > > > Does this mean some DMA reads do not snoop the caches or does it
> > > > include DMA writes not synchronizing the caches too?
> > > Both DMA reads and writes are not snooped.
> > 
> > Oh that sounds really dangerous.
> 
> So if this is an issue then we might already have a problem, because with
> many devices it's entirely up to the device programming whether the i/o is
> snooping or not. So the moment you pass such a device to a guest, whether
> there's explicit support for non-coherent or not, you have a
> problem.

No, the iommus (except Intel and only for Intel integrated GPU, IIRC)
prohibit the use of non-coherent DMA entirely from a VM.

Eg AMD systems 100% block non-coherent DMA in VMs at the iommu level.

> _If_ there is a fundamental problem. I'm not sure of that, because my
> assumption was that at most the guest shoots itself and the data
> corruption doesn't go any further the moment the hypervisor does the
> dma/iommu unmapping.

Who fixes the cache on the unmapping? I didn't see anything..

Jason