Received-SPF: pass (google.com: domain of linux-kernel+bounces-19801-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <c68cfc31-317c-4709-a2e5-3729a137b1bb@huawei-partners.com>
Date: Mon, 8 Jan 2024 16:46:35 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] swiotlb: check alloc_size before the allocation of a new
 memory pool
To: Peng Zhang <zhangpeng362@huawei.com>, <hch@lst.de>,
	<m.szyprowski@samsung.com>, <robin.murphy@arm.com>, <iommu@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
CC: <wangkefeng.wang@huawei.com>, <sunnanyong@huawei.com>
References: <20240108140005.3355316-1-zhangpeng362@huawei.com>
Content-Language: en-US
From: Petr Tesarik <petr.tesarik1@huawei-partners.com>
In-Reply-To: <20240108140005.3355316-1-zhangpeng362@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 1/8/2024 3:00 PM, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@huawei.com>
> 
> The allocation request for swiotlb contiguous memory greater than
> 128*2KB cannot be fulfilled because it exceeds the maximum contiguous
> memory limit. If the swiotlb memory we allocate is larger than 128*2KB,
> swiotlb_find_slots() will still schedule the allocation of a new memory
> pool, which will increase memory overhead.
> 
> Fix it by adding a check with alloc_size no more than 128*2KB before
> scheduling the allocation of a new memory pool in swiotlb_find_slots().
> 
> Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
> ---
>  kernel/dma/swiotlb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 33d942615be5..cc92cff02c60 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -1126,6 +1126,9 @@ static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr,
>  	u64 phys_limit;
>  	int index;
>  
> +	if (alloc_size > IO_TLB_SEGSIZE * IO_TLB_SIZE)
> +		return -1;
> +
>  	rcu_read_lock();
>  	list_for_each_entry_rcu(pool, &mem->pools, node) {
>  		index = swiotlb_pool_find_slots(dev, pool, orig_addr,

IIUC this such big allocations are not normally required by drivers, but
I have already run into a similar issue with a Raspberry Pi 4 dma-buf
object, so they can be triggered at will by user space. I also believe
this sanity check is a good idea in general, not only when dynamic
SWIOTLB is enabled.

Reviewed-by: Petr Tesarik <petr.tesarik1@huawei-partners.com>

Petr T