Received-SPF: pass (google.com: domain of linux-kernel+bounces-19811-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Michael Kelley <mhklinux@outlook.com>
To: "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>
CC: "tglx@linutronix.de" <tglx@linutronix.de>, "mingo@redhat.com"
	<mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "x86@kernel.org"
	<x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>, "haiyangz@microsoft.com"
	<haiyangz@microsoft.com>, "wei.liu@kernel.org" <wei.liu@kernel.org>,
	"decui@microsoft.com" <decui@microsoft.com>, "luto@kernel.org"
	<luto@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>, "urezki@gmail.com"
	<urezki@gmail.com>, "hch@infradead.org" <hch@infradead.org>,
	"lstoakes@gmail.com" <lstoakes@gmail.com>, "thomas.lendacky@amd.com"
	<thomas.lendacky@amd.com>, "ardb@kernel.org" <ardb@kernel.org>,
	"jroedel@suse.de" <jroedel@suse.de>, "seanjc@google.com" <seanjc@google.com>,
	"rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>,
	"sathyanarayanan.kuppuswamy@linux.intel.com"
	<sathyanarayanan.kuppuswamy@linux.intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-coco@lists.linux.dev"
	<linux-coco@lists.linux.dev>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: RE: [PATCH v3 1/3] x86/hyperv: Use slow_virt_to_phys() in page
 transition hypervisor callback
Thread-Topic: [PATCH v3 1/3] x86/hyperv: Use slow_virt_to_phys() in page
 transition hypervisor callback
Thread-Index: AQHaQAVimv7uqsPUukqF0M02BKDa3rDP51qAgAAvjfA=
Date: Mon, 8 Jan 2024 16:00:34 +0000
Message-ID:
 <SN6PR02MB4157369A252497FEEEBD5B83D46B2@SN6PR02MB4157.namprd02.prod.outlook.com>
References: <20240105183025.225972-1-mhklinux@outlook.com>
 <20240105183025.225972-2-mhklinux@outlook.com>
 <20240108130757.xryzva4fkmgeekhu@box.shutemov.name>
In-Reply-To: <20240108130757.xryzva4fkmgeekhu@box.shutemov.name>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?o6mTGdGDfMO+r4Y2QGOvqTMd6dFeCVvVwP+4jlOy60NcLccOt5iV09lxKWYV?=
 =?us-ascii?Q?bGfNauX0Anl8EGmX+GB9EerusjMiVwf6nQOQrhQDjSBtVu2SbvpwCZ/O2gFm?=
 =?us-ascii?Q?lc/r+xfR30SKqhvR2geLTBXZlKuYGS8Ktm7KdVpel9WcnXkc+u2FWgiSitAr?=
 =?us-ascii?Q?FaZfyBBBsul2YlhMkRawuAp6g+9qGic09U3Cv2mH0KckuTSrULyWhCeEWrCk?=
 =?us-ascii?Q?FboQxO/zkb6XB2ABeBsxjv4EvR9HbF9TuJNTcx/VLl9FDzO5w8BoTn1zDnuo?=
 =?us-ascii?Q?KGjWYHG23uazcYIdBD4L1wSYn428Upix/6MIdOXuDKYVM4b35crv4NRox1Uh?=
 =?us-ascii?Q?NoZZLfv8L7Ci4fC31Ony2RA8j63mEW5Ry8GIzmxOhsEkuEj73SsI1534qyH4?=
 =?us-ascii?Q?Rpzs5+ThKHi35WEnCg8p/E29sEO5AyRFiQqfhQ5blAYk/CEMDTQ/u4WXvoju?=
 =?us-ascii?Q?aYnuTQBUEc19WK0RgeGaCXQFB1kaB0cuSy1BQO+QtRO+Bq8cL5aGTptvekS/?=
 =?us-ascii?Q?8N6DkvOFwE4kL9mE3MMJmpyrukD+LRZ/zm7zK9RVq9OLFoesyFh0JmLL1WZN?=
 =?us-ascii?Q?r9X5ue/VUQPU7vFK8dBLwSWu8RJgHFO182N7aOIvq0lA/GY8CBWneSe6jCVn?=
 =?us-ascii?Q?AQl+42ycWyiS5aZjcMBLhTOP9b6KnU0O760U41ypt/U3MRW29ryuAdNdxYYz?=
 =?us-ascii?Q?OkCWZaugbilR5DS1q1YaZhHUKnuqNjIIGgycnfZeiNx/x+1mg6SQXWMrcS/9?=
 =?us-ascii?Q?YwPry3Odbdq4B4ffiRP17ZLXVC8waojBlftiuQPB1LKOzNUajhyGBFnXBy7i?=
 =?us-ascii?Q?U6b3TGiPCsnnhexY/Lnl581Ud6ioLTHr4YT8wd6xGY1v4KVo+CdJzcpl9RzR?=
 =?us-ascii?Q?Ek5y5CJVi0bwuELBZGwyqhtulQZr6BVClIhlRearE+99Kq1wwxSgigzzZG62?=
 =?us-ascii?Q?5DNnXaKHB6xwkcBULp5FA6j21ERULo+qho95Sg1SQYytd6nW3zb3VrWQHQYX?=
 =?us-ascii?Q?yaqNH5APiU2Edn6t9zQ6BMernwmNH9wRgLNTgVLgy1WKcuJVLMhF8tEDDMzT?=
 =?us-ascii?Q?S/jiLajm7wCbEMtcls+toal0ZvwseTxRNuUFKzxu4tVtBudTgoj2By25vAQ/?=
 =?us-ascii?Q?rGBKumWqde8JaxhoxTNooboQYKOUjpJk48jBucK1mK5Ne6Ik9Z7E3ossxUUP?=
 =?us-ascii?Q?4X0Yb83rd0kP3thnYij8CXyqVPv3+ubPnYWRsQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: b9f1c699-f464-4563-c59a-08dc1062f284
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 16:00:34.1180
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR02MB9970

From: kirill.shutemov@linux.intel.com <kirill.shutemov@linux.intel.com> Sen=
t: Monday, January 8, 2024 5:08 AM
>=20
> On Fri, Jan 05, 2024 at 10:30:23AM -0800, mhkelley58@gmail.com wrote:
> > From: Michael Kelley <mhklinux@outlook.com>
> >
> > In preparation for temporarily marking pages not present during a
> > transition between encrypted and decrypted, use slow_virt_to_phys()
> > in the hypervisor callback. As long as the PFN is correct,
> > slow_virt_to_phys() works even if the leaf PTE is not present.
> > The existing functions that depend on vmalloc_to_page() all
> > require that the leaf PTE be marked present, so they don't work.
> >
> > Update the comments for slow_virt_to_phys() to note this broader usage
> > and the requirement to work even if the PTE is not marked present.
> >
> > Signed-off-by: Michael Kelley <mhklinux@outlook.com>
> > ---
> >  arch/x86/hyperv/ivm.c        |  9 ++++++++-
> >  arch/x86/mm/pat/set_memory.c | 13 +++++++++----
> >  2 files changed, 17 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
> > index 02e55237d919..8ba18635e338 100644
> > --- a/arch/x86/hyperv/ivm.c
> > +++ b/arch/x86/hyperv/ivm.c
> > @@ -524,7 +524,14 @@ static bool hv_vtom_set_host_visibility(unsigned
> long kbuffer, int pagecount, bo
> >  		return false;
> >
> >  	for (i =3D 0, pfn =3D 0; i < pagecount; i++) {
> > -		pfn_array[pfn] =3D virt_to_hvpfn((void *)kbuffer + i * HV_HYP_PAGE_S=
IZE);
> > +		/*
> > +		 * Use slow_virt_to_phys() because the PRESENT bit has been
> > +		 * temporarily cleared in the PTEs.  slow_virt_to_phys() works
> > +		 * without the PRESENT bit while virt_to_hvpfn() or similar
> > +		 * does not.
> > +		 */
> > +		pfn_array[pfn] =3D slow_virt_to_phys((void *)kbuffer +
> > +					i * HV_HYP_PAGE_SIZE) >> HV_HYP_PAGE_SHIFT;
>=20
> I think you can make it much more readable by introducing few variables:
>=20
> 		virt =3D (void *)kbuffer + i * HV_HYPPAGE_SIZE;
> 		phys =3D slow_virt_to_phys(virt);
> 		pfn_array[pfn] =3D phys >> HV_HYP_PAGE_SHIFT;
>=20

Agreed.  I'll do this in the next version.

Michael