Received-SPF: pass (google.com: domain of linux-kernel+bounces-19812-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <49f86f3c-2476-4991-b01c-171a54258994@intel.com>
Date: Mon, 8 Jan 2024 17:01:05 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC net-next 00/34] Christmas 3-serie XDP for idpf
 (+generic stuff)
Content-Language: en-US
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	Michal Kubiak <michal.kubiak@intel.com>, Larysa Zaremba
	<larysa.zaremba@intel.com>, Alexei Starovoitov <ast@kernel.org>, "Daniel
 Borkmann" <daniel@iogearbox.net>, <intel-wired-lan@lists.osuosl.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231223025554.2316836-1-aleksander.lobakin@intel.com>
 <658b364d56c6e_5c2a929468@willemb.c.googlers.com.notmuch>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <658b364d56c6e_5c2a929468@willemb.c.googlers.com.notmuch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V25IS3h2UlUrNHlLYmZrQ3dyRHk1MUV5WXV5a0t5WFYxZzJDcjVwQlRCSFJn?=
 =?utf-8?B?Nll2cVVacEVrM3cwR2lxYWt0cmdycElTMkZ5dEg1TEJRdStheHlTYmQ2NjBv?=
 =?utf-8?B?VHgvZ3ZmTEZyUmw4eWF5Y1JsRk1jaythQjI0cWIvNk56ZHBQbndqVTZGRjFQ?=
 =?utf-8?B?cE1LaHVaNEx0VWE3d0lZM25Yc0lnd3ZhQTBadnZhV1U5WUJmUENueU1jM2xW?=
 =?utf-8?B?b3ZucFFXV0FhNkc2L0VFSlE5c2NQbVhvSEsySXRTb1NNTGVONHF5eWttVzJY?=
 =?utf-8?B?UDAyYXNtTFRqdFVzTWRtT1pBQjJ0ZHl1NEhKTXpaU1Y5R1lsMXVEQW0xWnQv?=
 =?utf-8?B?cldoSnRvT0VQT1d2UGdVcFNVSFlKbFpGR1RSVjVPSTZadnNJcU1URzMrS0cw?=
 =?utf-8?B?SXMyNkloMGQxS2pTUTYyRTZJT3BrdTRGZUNmQ1A3V0RvVi9aMUVtcWYxUkUz?=
 =?utf-8?B?bHo3TlJESHM0cCt3UUcvSWRzSHVDcUdadHZ4cmMyQlhHNzJxdlpTMFJGbGVO?=
 =?utf-8?B?YW45dEZjN2RHQ1pIR0JlR2VZc1BlSjIvZ3k5dzBsbDc1eXVrcnNISTU5NWl2?=
 =?utf-8?B?eWY5eEpYTHdWVWs3cTdaREFTL2JFVFg0NUJQajJEbDBhaXByb0I5dDhCd3BH?=
 =?utf-8?B?SW9lY2Zna0RPREtnK3dQQ095U2ZuNHEvemhiTkkzL0NNektTTi9aNGNQSWRI?=
 =?utf-8?B?UWFXWVZCME50QW90Y0tGWVJUbzZ4Tk9iTmZ6Q1h1eWYxNUhoUmZGS1ZaVTY5?=
 =?utf-8?B?L2JtdjJrS1FnMVZIS2lqV1VwZDA3N0N4bkJNVXdESWNBYWJBa2tzRjNaYU9N?=
 =?utf-8?B?d2s1Tnhza3RlbmoveDNXeGRUekZCV01wZEJQRnZxMTAzcUlRb3ZXR0kwY3dm?=
 =?utf-8?B?WndnM2RJa3R5RmN3WmNoMFpsN0YzSndFa09mUkFYU1BCM3R0UFBaU2lHUDhI?=
 =?utf-8?B?c1grRzJoQm0xNVNVZ1VlYVpMM2VZcHVJQmJDaXFPTGtXZ1B4MnA1Nzg1cTVi?=
 =?utf-8?B?czhzT2NDK3JGNFIyL283R0tPODlGSVBidTgrN0V5bktBcW9JRVVJSit5dWNn?=
 =?utf-8?B?MUVNSmZKM3VseFU3RHh4NHh6VWJjU1BsMWVjTUVVUmFLRHpsdm5SWWowQTh5?=
 =?utf-8?B?Ny90czkxeU14ZVovcjViZXFkaDNBSjNaVTlPR0pJVFBzd3JtdjdLOWxkNjh4?=
 =?utf-8?B?aWlyYW84VEQyc0tRVlpjM24vMXRMcEdEWGV3OWhXOTFsSXd2OVo1Z0tYUHJx?=
 =?utf-8?B?bG41TWd1dm5xZEVlQ09UUHZVL1BIL09VbTkvWnZrLzRiVUx4dnNYNEl1ZENS?=
 =?utf-8?B?QmxLQjZhWW5pL2tLbnpMOS9PendpVmdhYTYyR24wbDFjNlZ6UWc0S1dtZEsv?=
 =?utf-8?B?V013d29Vb2V6OXNjdVhzMjdkUWxuYnQrR2p5RDI1MzdxWUdjU2lYdm9UTk9P?=
 =?utf-8?B?ZGtNRUt1UTFYS1BOQ1RnbEE5ZU9laWRvaDYzTnptemdYWlAyR2QrcTBCZHc3?=
 =?utf-8?B?ak8xS3lzRklUM1NVRkJ0Tnd0OCswd3BHYlYrbzRHK0NNNW1zMHJYbklNREhT?=
 =?utf-8?B?eDdBQmhBWElxZ2pZZXFNbU5md2hsaFdmTWZFdllwaWpTTzlPUmIzVjc4RmFj?=
 =?utf-8?B?S3dkMEtBbFIwZytlYzdBOWpUY3V4VE95dndhZ2ZhYjBkVm5oa1VNWFYyUmtQ?=
 =?utf-8?B?ZmFibEFUQnNLc1lpc2ZmUjNrMVVIeFl6ZkZTV3JicW03eG5JbmxsbFh6TWhy?=
 =?utf-8?B?T0RXNUVUS2VPWlJ2VzgwUXNCUDl0V3l5eWVQK3kvaUhkRi9vYVBvQWVXSjVw?=
 =?utf-8?B?RkVuN1ZkeGQwTEdISVZrR0pOZlRoUE9Tem5nK1N6YlFDTzdqcWJXa09LOEd3?=
 =?utf-8?B?ZU82TWx0MWlzK0M1Z29LVEFhQzkrQ3JRcnludXZncThUSjVYcUFEbTlIclBN?=
 =?utf-8?B?a2VRSG8yUjRoWkZvVGJJUmkvM1BzQm9lRGhESzE1b3loY3JUeFRoYmg3Rk94?=
 =?utf-8?B?K2FIb2oyS3A5dk9DcGNwSlRjVVRER1EwZWpVeGpudzdYd3Jxa0pzbkpKSkc4?=
 =?utf-8?B?NDkzQ1VCazdYanZTaGliMVlCU0JrbTk0QS8rTzhzWVlUOWZuSFhvdFZOeHdp?=
 =?utf-8?B?THRrKzJpTE1RejlsT3kzeVg1WUZaUjNHSUlWazhvdC9zcnhBaVlQQnlRblRZ?=
 =?utf-8?B?Y3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ecf80b3f-1a54-460c-0682-08dc10630836
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 16:01:10.7697
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VDUmLqp35FQmuPSqO/piGDWY+2GGshdd9KfbLipN9Xq1HSrn7o2qCNdASLaZ/kseT1i0sEdlUW+jzw0cEUr4dnCM/c8rB3WTk0ScsH7IIek=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5601
X-OriginatorOrg: intel.com

From: Willem De Bruijn <willemdebruijn.kernel@gmail.com>
Date: Tue, 26 Dec 2023 15:23:41 -0500

> Alexander Lobakin wrote:
>> I was highly asked to send this WIP before the holidays to trigger
>> some discussions at least for the generic parts.
>>
>> This all depends on libie[0] and WB-on-ITR fix[1]. The RFC does not
>> guarantee to work perfectly, but at least regular XDP seems to work
>> for me...
>>
>> In fact, here are 3 separate series:
>> * 01-08: convert idpf to libie and make it more sane;
>> * 09-25: add XDP to idpf;
>> * 26-34: add XSk to idpf.
>>
>> Most people may want to be interested only in the following generic
>> changes:
>> * 11: allow attaching already registered memory models to XDP RxQ info;
>> * 12-13: generic helpers for adding a frag to &xdp_buff and converting
>>   it to an skb;
>> * 14: get rid of xdp_frame::mem.id, allow mixing pages from different
>>   page_pools within one &xdp_buff/&xdp_frame;
>> * 15: some Page Pool helper;
>> * 18: it's for libie, but I wanted to talk about XDP_TX bulking;
>> * 26: same as 13, but for converting XSK &xdp_buff to skb.
>>
>> The rest is up to you, driver-specific stuff is pretty boring sometimes.
>>
>> I'll be polishing and finishing this all starting January 3rd and then
>> preparing and sending sane series, some early feedback never hurts tho.
>>
>> Merry Yule!
>>
>> [0] https://lore.kernel.org/netdev/20231213112835.2262651-1-aleksander.lobakin@intel.com
>> [1] https://lore.kernel.org/netdev/20231215193721.425087-1-michal.kubiak@intel.com
> 
> This is great. Thanks for sharing the entire series.
> 
> Which SHA1 should we apply this to? I'm having a hard time applying
> cleanly.
> 
> The libie v7 series applied cleanly on bc044ae9d64b. Which I chose
> only based on the follow-on page pool patch.
> 
> But that base commit causes too many conflicts when applying this.
> Patch 6 had a trivial one in idpf_rx_singleq_clean (`skb = rx_q->skb`).
> But patch 14 has so many conflicts in page_pool.c, that I'm clearly
> on the wrong track trying to fix up manually.

net-next was updated while I was preparing the series. I also did a
couple changes in the basic libie code, but a new rev wasn't sent.
Please just use my open GH[0].

[0] https://github.com/alobakin/linux/tree/idpf-libie

Thanks,
Olek