Received-SPF: pass (google.com: domain of linux-kernel+bounces-19813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6bf7da8b-6a0b-4c0d-959e-329d7cbd8cea@amd.com>
Date: Mon, 8 Jan 2024 10:01:48 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT
 MODEL section
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
 Elena Reshetova <elena.reshetova@intel.com>, Jonathan Corbet
 <corbet@lwn.net>, linux-doc@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
 Jakub Kicinski <kuba@kernel.org>
References: <20240108140852.20533-1-lukas.bulwahn@gmail.com>
Content-Language: en-US
From: Carlos Bilbao <carlos.bilbao@amd.com>
In-Reply-To: <20240108140852.20533-1-lukas.bulwahn@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N21taWNacE5oNHhwc0p5SUhCMjVCMFRDZUxWaTkvZnB2Z0p4Z3lOWGFqYy9L?=
 =?utf-8?B?d0J6SzNESlNJMGxyL0NWS01VTjZHV09SbVBUZVBvZjByYy9LSkdyV2JWR1lQ?=
 =?utf-8?B?blgzQW9XM3VsYWRBUU5EN2k1S05rTU5qS1lQZGNsWmptNHRpQktsb2hmbXZu?=
 =?utf-8?B?NFpqYThnV1dXeW1HOWczK1RVZTYyZEQrSCsyWWMwNUp4V0NVdnlMeXJIZGtZ?=
 =?utf-8?B?TWM1dXoxRVlpYXpJQmVlZDVXRDZaL0svQjk4N0hXc2ZNczcrcEhzSk40a1Yx?=
 =?utf-8?B?c2MrcCt6dEg0bzZFN2lkQThlV3VNclRsMkRXKzZ0NDh5Z1g2L3VQbk53NG5I?=
 =?utf-8?B?UCtJaWs0bXp3QktvSUQ5b1NVaTB0aUFjUy9ZdUxqanFyenpRN1N3VVBLdnFO?=
 =?utf-8?B?UWpFU3BkcEE4eXVrQ01kRWtpM0Jub3FZMHZ4SHF3Vjl5czhIRVpvT0d3M2dx?=
 =?utf-8?B?QXljT3pFNFJNU1JjZjFKR2tkMXZZRmdIRFJ4clBJT3g1Zm9iaXB0UkFCVDBv?=
 =?utf-8?B?WEE5dE9rdWJvNTU4VTdaUXlRbTRmaTNMSmJiSlpyT0pYaHBJd0JibWF3dENp?=
 =?utf-8?B?NjBZQkRjVUY1KzE2OTFJeVA3ZFJuQ3dtYTNsZ09SQlRPVE1lZEpEQS9NMC9h?=
 =?utf-8?B?Ti9Sdi9MaEV2anVxL0FpL2t3bW5nUW1KQWcxeGQyRXpZUzkrNFhFRWhBVWU3?=
 =?utf-8?B?ZCtpSklDM2ZmbDJPU3lEWW1mbHdmNjB5UG4wc3F5ZVZDaTBWeDY0Y1E0N1pu?=
 =?utf-8?B?UDhXL1Z4SmNwSTc3ejJIYXNLQnREU2l6Wm4rRWdQUGdjVWhBWnBJZGlYV3h3?=
 =?utf-8?B?emxLOUU3YXBiMlpIc24zQ01kaDczSXNPSmtrS2pjT2Z2eDZTMWM5SStOamlN?=
 =?utf-8?B?b1dvK1U1OU43WXpIN1JzY2xmbkRwNjNVWG5zZ1hLMkdiZVd5N05yNkROQVUx?=
 =?utf-8?B?Mnh1SmVrK1NOOUkySEtqN3QxOU4rWU1NUTkxTm9yRGxsU0ZEcUc0L2dSOEtt?=
 =?utf-8?B?RGtJYVpZeGJCRklHSm4vVTRlKzlKaG5vc3g0bDBYWDBjVU1XNkpQWFYxTlo4?=
 =?utf-8?B?Q0JtaWhpeTlrUGVwZnBWSGxYNkZDdnZpM2ZzemtLZGtiRDNvalJkaHlPTjBG?=
 =?utf-8?B?SVFHQ0lORjZhMGJFOGtqRGNWTytTUXhJanJvbGZIaVZEUHhmdjl5RUtVYUUw?=
 =?utf-8?B?OWYwanZYMlhRZG5FQ3JMRWJDUnpkQVFvMGhIZDQ3OHhnY2ZQYjlSdFh0NlBT?=
 =?utf-8?B?Qi9TRTNSekpVNmZOb2R2dVZxVmwvckhSK2hpZU8renhWeEd5amVWTWpBRGhu?=
 =?utf-8?B?Zm1xcVFaRlJTVlVneExScmo0c3BzMXVKWFJWTFgvMjdldnY0eHBzMldWeG1a?=
 =?utf-8?B?cnhNcTd2Zk5oU1ZETmdvdmRuUkNMdXlJM1BtaTczWHREQk9DQVM1bklaZ2Jz?=
 =?utf-8?B?ak45MnQzNUQzbHhMbUt4azdYdkp5Nm83QWhjZ0t3ZzVwMDdrUUdlVHlYNFJG?=
 =?utf-8?B?TnlDUEs1NjBlZk5EVlczVWhSbVFlTWwwdzl6MnBSZW1nNXhUUHNha2VQaEtm?=
 =?utf-8?B?bkN2cHFrc2xKaGdrM2h4ZlhvdkcwU01QZ3RrZFVqNFUraUVtU29MTTFKRHBI?=
 =?utf-8?B?T0cydk4vUkFZcGFaMjN5TVlJVG1ZNWpLdUQrbzcwdGZWaWlwNldGUU11emM4?=
 =?utf-8?B?ZDVHZWduYXZ6TXN0KzFETmRRbUMwbzdsTVZEdTlIbitQSDdUL21EVkdkclpM?=
 =?utf-8?B?MVJyVDdSdGhmakRGZldUczhzdUJZSE1pSzkya2tYQzBnSDFFb3pXc2dTVmFi?=
 =?utf-8?B?TnIwQk51Q1FYS3RBd3g4SnAzVUxxYlU4Ym9TZmpFa3l5dElVSUx0YUdYRDlo?=
 =?utf-8?B?YkpQa1JRSWZmNitseHBHMnhpSHE3akdsKzZPd29OOGw5TDYzRjNyaXRFdjFi?=
 =?utf-8?B?SGZwVUY2WEpDUWdKdWlHYndyS1kvZjVyMDdjcmUvbjd6N1c4SXFUR2twNllD?=
 =?utf-8?B?UGN1OUh0RFdFRmZTSFhiMUE2RmlFVHdjeEVvM1M0bXhGVStkQmxOTzV6QXIx?=
 =?utf-8?B?eFpkQmFpakw1OTh6U2FVYXE1VUp3d0NUaGhvU0RBM2c0azdGQjVHUGtNdDN4?=
 =?utf-8?Q?xD469kikV8LGDHc1z/Kj495Fm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85fbea4f-4964-45ad-aa17-08dc10631fd0
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 16:01:50.2918
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZSUytYNrL8O6xIe/8EZLB6aonKPemU4VzZyiIlaNtt3NfteKRz2YNDG80nSr4Cdc7MwvrHyf2HY4TVhw3KZIeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4902

Hello,

On 1/8/24 08:08, Lukas Bulwahn wrote:
> Commit 1f597b1a6ec2 ("docs: security: Confidential computing intro and
> threat model for x86 virtualization") adds new documentation and a
> corresponding MAINTAINERS section. It however uses spaces instead of a
> single tab for all the entries in that MAINTAINERS section.
> 
> Although, the get_maintainer.pl script handles spaces instead of tabs
> silently, the MAINTAINERS will quickly get into a messy state with
> different indentations throughout the file. So, the checkpatch.pl script
> complains when spaces instead of a single tab are used.
> 
> Fix this recently added section using tabs instead of spaces.
> 
> Fixes: 1f597b1a6ec2 ("docs: security: Confidential computing intro and threat model for x86 virtualization")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Jakub has already addressed this issue with the patch "[PATCH docs]
MAINTAINERS: use tabs for indent of CONFIDENTIAL COMPUTING THREAT MODEL"
from 1/3/24. Also, I recommend refraining from using the 'Fixes' tag for
things of this nature. NACK.

> ---
>   MAINTAINERS | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fa67e2624723..c76884e40434 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5296,10 +5296,10 @@ W:	http://accessrunner.sourceforge.net/
>   F:	drivers/usb/atm/cxacru.c
>   
>   CONFIDENTIAL COMPUTING THREAT MODEL FOR X86 VIRTUALIZATION (SNP/TDX)
> -M:    Elena Reshetova <elena.reshetova@intel.com>
> -M:    Carlos Bilbao <carlos.bilbao@amd.com>
> -S:    Maintained
> -F:    Documentation/security/snp-tdx-threat-model.rst
> +M:	Elena Reshetova <elena.reshetova@intel.com>
> +M:	Carlos Bilbao <carlos.bilbao@amd.com>
> +S:	Maintained
> +F:	Documentation/security/snp-tdx-threat-model.rst
>   
>   CONFIGFS
>   M:	Joel Becker <jlbec@evilplan.org>

Thanks,
Carlos