Received-SPF: pass (google.com: domain of linux-kernel+bounces-19845-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240108033138.217032-1-wangrui@loongson.cn>
In-Reply-To: <20240108033138.217032-1-wangrui@loongson.cn>
From: Nick Desaulniers <ndesaulniers@google.com>
Date: Mon, 8 Jan 2024 08:31:45 -0800
Message-ID: <CAKwvOd=ygyfAzmk=1TTf+U62U8wkvpFYCJo-Ci--6rs5nSoT0A@mail.gmail.com>
Subject: Re: [PATCH] scripts/min-tool-version.sh: Raise min clang version to
 18.0.0 for loongarch
To: WANG Rui <wangrui@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>, WANG Xuerui <kernel@xen0n.name>, llvm@lists.linux.dev, 
	linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, 
	loongson-kernel@lists.loongnix.cn, Nathan Chancellor <nathan@kernel.org>, 
	Tiezhu Yang <yangtiezhu@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 7, 2024 at 7:32=E2=80=AFPM WANG Rui <wangrui@loongson.cn> wrote=
:
>
> The existing mainline clang development version encounters diffculties

s/diffculties/difficulties/

> compiling the LoongArch kernel module. It is anticipated that this issue
> will be resolved in the upcoming 18.0.0 release. To prevent user
> confusion arising from broken builds, it is advisable to raise the
> minimum required clang version for LoongArch to 18.0.0.
>
> Suggested-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Signed-off-by: WANG Rui <wangrui@loongson.cn>

Thanks for all of the work here; it's nice to observe the progress.

Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1941

> ---
>  scripts/min-tool-version.sh | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> index c62066825f53..9faa4d3d91e3 100755
> --- a/scripts/min-tool-version.sh
> +++ b/scripts/min-tool-version.sh
> @@ -26,6 +26,8 @@ gcc)
>  llvm)
>         if [ "$SRCARCH" =3D s390 ]; then
>                 echo 15.0.0
> +       elif [ "$SRCARCH" =3D loongarch ]; then
> +               echo 18.0.0
>         else
>                 echo 11.0.0
>         fi
> --
> 2.43.0
>
>


--=20
Thanks,
~Nick Desaulniers