Received-SPF: pass (google.com: domain of linux-kernel+bounces-19855-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 8 Jan 2024 09:37:59 -0700
From: Nathan Chancellor <nathan@kernel.org>
To: WANG Rui <wangrui@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>, WANG Xuerui <kernel@xen0n.name>,
	llvm@lists.linux.dev, linux-kernel@vger.kernel.org,
	loongarch@lists.linux.dev, loongson-kernel@lists.loongnix.cn,
	Tiezhu Yang <yangtiezhu@loongson.cn>
Subject: Re: [PATCH] scripts/min-tool-version.sh: Raise min clang version to
 18.0.0 for loongarch
Message-ID: <20240108163759.GA2899468@dev-arch.thelio-3990X>
References: <20240108033138.217032-1-wangrui@loongson.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240108033138.217032-1-wangrui@loongson.cn>

On Mon, Jan 08, 2024 at 11:31:38AM +0800, WANG Rui wrote:
> The existing mainline clang development version encounters diffculties
> compiling the LoongArch kernel module. It is anticipated that this issue
> will be resolved in the upcoming 18.0.0 release. To prevent user
> confusion arising from broken builds, it is advisable to raise the
> minimum required clang version for LoongArch to 18.0.0.
> 
> Suggested-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Signed-off-by: WANG Rui <wangrui@loongson.cn>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

Thanks a lot for all the work driving getting everything to work
properly with LLVM!

> ---
>  scripts/min-tool-version.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> index c62066825f53..9faa4d3d91e3 100755
> --- a/scripts/min-tool-version.sh
> +++ b/scripts/min-tool-version.sh
> @@ -26,6 +26,8 @@ gcc)
>  llvm)
>  	if [ "$SRCARCH" = s390 ]; then
>  		echo 15.0.0
> +	elif [ "$SRCARCH" = loongarch ]; then
> +		echo 18.0.0
>  	else
>  		echo 11.0.0
>  	fi
> -- 
> 2.43.0
> 
>