Received-SPF: pass (google.com: domain of linux-kernel+bounces-19858-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <c290495d-fd4d-644b-7dc9-47a6273e7e26@linux.ibm.com>
Date: Mon, 8 Jan 2024 10:39:35 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v1] fsi: run clock at 100MHz
To: Lakshmi Yadlapati <lakshmiy@us.ibm.com>, joel@jms.id.au,
        ninad@linux.ibm.com, alistair@popple.id.au
Cc: linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20231214171042.3889056-1-lakshmiy@us.ibm.com>
Content-Language: en-US
From: Eddie James <eajames@linux.ibm.com>
In-Reply-To: <20231214171042.3889056-1-lakshmiy@us.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 12/14/23 11:10, Lakshmi Yadlapati wrote:
> Adjust FSI speed to 100MHz for improved stability and optimized
> data transmission.


Reviewed-by: Eddie James <eajames@linux.ibm.com>


>
> Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
> ---
>   drivers/fsi/fsi-master-aspeed.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c
> index f0a19cd451a0..b065e1bb9054 100644
> --- a/drivers/fsi/fsi-master-aspeed.c
> +++ b/drivers/fsi/fsi-master-aspeed.c
> @@ -87,7 +87,7 @@ static const u32 fsi_base = 0xa0000000;
>   #define FSI_LINK_ENABLE_SETUP_TIME	10	/* in mS */
>   
>   /* Run the bus at maximum speed by default */
> -#define FSI_DIVISOR_DEFAULT            1
> +#define FSI_DIVISOR_DEFAULT            2
>   #define FSI_DIVISOR_CABLED             2
>   static u16 aspeed_fsi_divisor = FSI_DIVISOR_DEFAULT;
>   module_param_named(bus_div,aspeed_fsi_divisor, ushort, 0);