Received-SPF: pass (google.com: domain of linux-kernel+bounces-19869-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 8 Jan 2024 16:58:55 +0000
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Ira Weiny <ira.weiny@intel.com>
CC: Dan Williams <dan.j.williams@intel.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>, Shiju Jose <shiju.jose@huawei.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>, "Davidlohr Bueso" <dave@stgolabs.net>,
	Dave Jiang <dave.jiang@intel.com>, "Alison Schofield"
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, Ard
 Biesheuvel <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>, "Rafael J.
 Wysocki" <rafael@kernel.org>, "Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v5 0/9] efi/cxl-cper: Report CPER CXL component events
 through trace events
Message-ID: <20240108165855.00002f5a@Huawei.com>
In-Reply-To: <20231220-cxl-cper-v5-0-1bb8a4ca2c7a@intel.com>
References: <20231220-cxl-cper-v5-0-1bb8a4ca2c7a@intel.com>
Organization: Huawei Technologies Research and Development (UK) Ltd.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

On Wed, 20 Dec 2023 16:17:27 -0800
Ira Weiny <ira.weiny@intel.com> wrote:

> Series status/background
> ========================
> 
> Smita has been a great help with this series.  Thank you again!
> 
> Smita's testing found that the GHES code ended up printing the events
> twice.  This version avoids the duplicate print by calling the callback
> from the GHES code instead of the EFI code as suggested by Dan.

I'm not sure this is working as intended. 

There is nothing gating the call in ghes_proc() of ghes_print_estatus()
and now the EFI code handling that pretty printed things is missing we get
the horrible kernel logging for an unknown block instead.

So I think we need some minimal code in cper.c to match the guids then not
log them (on basis we are arguing there is no need for new cper records).
Otherwise we are in for some messy kernel logs

Something like:

{1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 1
{1}[Hardware Error]: event severity: recoverable
{1}[Hardware Error]:  Error 0, type: recoverable
{1}[Hardware Error]:   section type: unknown, fbcd0a77-c260-417f-85a9-088b1621eba6
{1}[Hardware Error]:   section length: 0x90
{1}[Hardware Error]:   00000000: 00000090 00000007 00000000 0d938086  ................
{1}[Hardware Error]:   00000010: 00100000 00000000 00040000 00000000  ................
{1}[Hardware Error]:   00000020: 00000000 00000000 00000000 00000000  ................
{1}[Hardware Error]:   00000030: 00000000 00000000 00000000 00000000  ................
{1}[Hardware Error]:   00000040: 00000000 00000000 00000000 00000000  ................
{1}[Hardware Error]:   00000050: 00000000 00000000 00000000 00000000  ................
{1}[Hardware Error]:   00000060: 00000000 00000000 00000000 00000000  ................
{1}[Hardware Error]:   00000070: 00000000 00000000 00000000 00000000  ................
{1}[Hardware Error]:   00000080: 00000000 00000000 00000000 00000000  ................
cxl_general_media: memdev=mem1 host=0000:10:00.0 serial=4 log=Informational : time=0 uuid=fbcd0a77-c260-417f-85a9-088b1621eba6 len=0 flags='' handle=0 related_handle=0 maint_op_class=0 : dpa=0 dpa_flags='' descriptor='' type='ECC Error' transaction_type='Unknown' channel=0 rank=0 device=0 comp_id=00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 validity_flags=''

(I'm filling the record with 0s currently)