Received-SPF: pass (google.com: domain of linux-kernel+bounces-19881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 8 Jan 2024 17:15:04 +0000
From: Conor Dooley <conor@kernel.org>
To: Elad Nachman <enachman@marvell.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: Add Marvell ac5
Message-ID: <20240108-zoning-tactical-20501dccfac1@spud>
References: <20240107152557.3561341-1-enachman@marvell.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="6iyG8MMvMc6OIxx2"
Content-Disposition: inline
In-Reply-To: <20240107152557.3561341-1-enachman@marvell.com>


--6iyG8MMvMc6OIxx2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
>=20
> Add Marvell ac5 device tree bindings to generic EHCI.
> This compatible enables the Marvell Orion platform code
> to properly configure the DMA mask for the Marvell AC5 SOC.
>=20
> Signed-off-by: Elad Nachman <enachman@marvell.com>

Maybe I am dumb, but I don't understand how this does what the commit
message says. There's no fallback to generic-ehci or any other
compatible that is already understood by the driver.

What am I missing?

> ---
>  Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Do=
cumentation/devicetree/bindings/usb/generic-ehci.yaml
> index 87986c45be88..2ed178f16a78 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> @@ -77,6 +77,7 @@ properties:
>            - const: usb-ehci
>        - enum:
>            - generic-ehci
> +          - marvell,ac5-ehci
>            - marvell,armada-3700-ehci
>            - marvell,orion-ehci
>            - nuvoton,npcm750-ehci
> --=20
> 2.25.1
>=20

--6iyG8MMvMc6OIxx2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZZwtlwAKCRB4tDGHoIJi
0nBJAP4o/0qhPq4HtmdsxfHorOUEO80CKUFL3HXLYzUxlZHosAD8DiDNiPaTSdiS
O5zbOzfcM8wJIj8Ig6kekoZkw0HTgg8=
=ikmD
-----END PGP SIGNATURE-----

--6iyG8MMvMc6OIxx2--