Received-SPF: pass (google.com: domain of linux-kernel+bounces-19896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <77fd81ae-269c-42c5-9788-dbbee31c05db@acm.org>
Date: Mon, 8 Jan 2024 09:31:18 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] ufs:mcq:Use ufshcd_mcq_req_to_hwq() to simplify
 updating hwq.
Content-Language: en-US
To: Chanwoo Lee <cw9316.lee@samsung.com>, alim.akhtar@samsung.com,
 avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com,
 stanley.chu@mediatek.com, quic_cang@quicinc.com, mani@kernel.org,
 quic_asutoshd@quicinc.com, powen.kao@mediatek.com, quic_nguyenb@quicinc.com,
 yang.lee@linux.alibaba.com, peter.wang@mediatek.com, athierry@redhat.com,
 linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: grant.jung@samsung.com, jt77.jang@samsung.com, dh0421.hwang@samsung.com,
 sh043.lee@samsung.com
References: <20240105021041.20400-1-cw9316.lee@samsung.com>
 <CGME20240105021138epcas1p3fdfa70996ddbd282c1067de02e39dbd4@epcas1p3.samsung.com>
 <20240105021041.20400-2-cw9316.lee@samsung.com>
From: Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20240105021041.20400-2-cw9316.lee@samsung.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 1/4/24 18:10, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
> Use ufshcd_mcq_req_to_hwq() to remove unnecessary variables and simplify.
> 
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
> ---
>   drivers/ufs/core/ufshcd.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 30df6f6a72c6..c9d122302889 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5597,7 +5597,6 @@ static void ufshcd_mcq_compl_pending_transfer(struct ufs_hba *hba,
>   	struct ufshcd_lrb *lrbp;
>   	struct scsi_cmnd *cmd;
>   	unsigned long flags;
> -	u32 hwq_num, utag;
>   	int tag;
>   
>   	for (tag = 0; tag < hba->nutrs; tag++) {
> @@ -5607,9 +5606,7 @@ static void ufshcd_mcq_compl_pending_transfer(struct ufs_hba *hba,
>   		    test_bit(SCMD_STATE_COMPLETE, &cmd->state))
>   			continue;
>   
> -		utag = blk_mq_unique_tag(scsi_cmd_to_rq(cmd));
> -		hwq_num = blk_mq_unique_tag_to_hwq(utag);
> -		hwq = &hba->uhq[hwq_num];
> +		hwq = ufshcd_mcq_req_to_hwq(hba, scsi_cmd_to_rq(cmd));
>   
>   		if (force_compl) {
>   			ufshcd_mcq_compl_all_cqes_lock(hba, hwq);

Reviewed-by: Bart Van Assche <bvanassche@acm.org>