Received-SPF: pass (google.com: domain of linux-kernel+bounces-19898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <175cf5c2-0bf2-48f4-8f48-a9589b6ad916@acm.org>
Date: Mon, 8 Jan 2024 09:32:39 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] ufs:mcq:Remove unused parameters
Content-Language: en-US
To: Chanwoo Lee <cw9316.lee@samsung.com>, alim.akhtar@samsung.com,
 avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com,
 stanley.chu@mediatek.com, quic_cang@quicinc.com, mani@kernel.org,
 quic_asutoshd@quicinc.com, powen.kao@mediatek.com, quic_nguyenb@quicinc.com,
 yang.lee@linux.alibaba.com, peter.wang@mediatek.com, athierry@redhat.com,
 linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: grant.jung@samsung.com, jt77.jang@samsung.com, dh0421.hwang@samsung.com,
 sh043.lee@samsung.com
References: <20240105021041.20400-1-cw9316.lee@samsung.com>
 <CGME20240105021223epcas1p156208a9a445b5e0b527a9eb2d2589ed3@epcas1p1.samsung.com>
 <20240105021041.20400-3-cw9316.lee@samsung.com>
From: Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20240105021041.20400-3-cw9316.lee@samsung.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 1/4/24 18:10, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
> The 'hwq' parameter is not used in this function.
> So, remove unused parameters.
> 
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
> ---
>   drivers/ufs/core/ufs-mcq.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index edc752e55878..8db81f1a12d5 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -258,9 +258,7 @@ EXPORT_SYMBOL_GPL(ufshcd_mcq_write_cqis);
>    * Current MCQ specification doesn't provide a Task Tag or its equivalent in
>    * the Completion Queue Entry. Find the Task Tag using an indirect method.
>    */
> -static int ufshcd_mcq_get_tag(struct ufs_hba *hba,
> -				     struct ufs_hw_queue *hwq,
> -				     struct cq_entry *cqe)
> +static int ufshcd_mcq_get_tag(struct ufs_hba *hba, struct cq_entry *cqe)
>   {
>   	u64 addr;
>   
> @@ -278,7 +276,7 @@ static void ufshcd_mcq_process_cqe(struct ufs_hba *hba,
>   				   struct ufs_hw_queue *hwq)
>   {
>   	struct cq_entry *cqe = ufshcd_mcq_cur_cqe(hwq);
> -	int tag = ufshcd_mcq_get_tag(hba, hwq, cqe);
> +	int tag = ufshcd_mcq_get_tag(hba, cqe);
>   
>   	if (cqe->command_desc_base_addr) {
>   		ufshcd_compl_one_cqe(hba, tag, cqe);

Reviewed-by: Bart Van Assche <bvanassche@acm.org>