Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1779405rdb; Mon, 8 Jan 2024 09:55:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFVLdDar5TcMyRjXQ4FrDDx0cS3Qmk+jMCZWKEEXD919Q3cx4id0cn2LKvrySUaxjuunVQW X-Received: by 2002:a62:ed11:0:b0:6da:c8b7:d58d with SMTP id u17-20020a62ed11000000b006dac8b7d58dmr1457085pfh.15.1704736536044; Mon, 08 Jan 2024 09:55:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704736536; cv=none; d=google.com; s=arc-20160816; b=Tqs+Es9ohhrb+gkfAJUUIT33W9dT6ng1ZiLnBTTzUhzCvPZJH5H+z+UOI1miweFmaZ /Oz0oBm4jjyHOvdnGi7vZeosVjLEZrZvZwVNQSQqd1mdDRjVvS57BcDImhs5E546+W3r LWYpg3wsg6ZHJRUwXGPBLYMjIjvaape0tbtxvsiAyyFzTOLT1qyCSLPpulrDmR2Q0LQ8 H6d1WfEHc/HrsDgVPCdxH+KXz1FdvgD37XhD16Rd18+ibeLeacY7VqBvaW0WXD0T1/WM 2xTBeBWCnofCWyCq6+n0alBXEVutu+d2DRUqZQ/TiBuABSr78C176TDKkxGuehwSk+43 HfTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KvM31lHrbY0IYTP66VwCdFD5764FawK2e4zToIrza1E=; fh=xTmBiPH9RAY8vjB5TZrKcuxK73alOFpb2OyPxjgYu5U=; b=qqi9cJcbmVM4ERPibJQ/xAdDW2UvOGQokrDa7hK1Hp1hMYbemLnBF881R79mfA0xDs BFgEs5nou0jqY3N53MKMRzT373t10N2sttEkJTjqrF6rrX9oheSp8SkkHnjASGM9Igjl o+poxt348MtFKJLwGgk0jpsOkIZ42FZJyqBASTYPr5fUIBbCNT6YhuURHjCXP/oVeK2M EKn4uUOpgu3tJldyUKJSqSSZJAin08cE5ie9Meblw+9poPQDUilbkAHHRf+HyNv7Q6VU dg1zIn8NLiSorS29ok7FPziqBYfzAj0+MyemLLmc9LQX8WDq4LpUvS4hjxrmYQoWBqtm tWng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pankajraghav.com header.s=MBO0001 header.b=qCceLeGd; spf=pass (google.com: domain of linux-kernel+bounces-19916-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19916-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id ih15-20020a056a008c0f00b006d0a6b4b95dsi159013pfb.384.2024.01.08.09.55.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 09:55:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19916-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@pankajraghav.com header.s=MBO0001 header.b=qCceLeGd; spf=pass (google.com: domain of linux-kernel+bounces-19916-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19916-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0FA7AB217DD for ; Mon, 8 Jan 2024 17:55:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EE2C055E5C; Mon, 8 Jan 2024 17:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pankajraghav.com header.i=@pankajraghav.com header.b="qCceLeGd" X-Original-To: linux-kernel@vger.kernel.org Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2840D55C02; Mon, 8 Jan 2024 17:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pankajraghav.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pankajraghav.com Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4T81jG5dJHz9scW; Mon, 8 Jan 2024 18:47:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1704736034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KvM31lHrbY0IYTP66VwCdFD5764FawK2e4zToIrza1E=; b=qCceLeGdiZhgaizFv5Xsp1MaepPiryhwzoz+gwItMof9jkuiDwXJ02ggjwpSy+hTDSXhiL HpRG/Iig99jjZQLa/xdK+Dz1Ikz/0SG72FBry6lWBnnyacNxLRZsObkmOWVZRVpdj4dii9 kbS7v1sRPZEZjgojfnH46yY5kya/jNLKn7cTrgDlze3/DwcpKO9xoIthHoFLL/eTkJpR2b zYyHGVJPSE4Yf0FzHeEhZ5DPxfOO78Xc8jNf3u6M9D6LTBzzYJj5gHPGWgKZ/M5VMyOReG hnn6rTwyR0+xfGL9AaC/yBpbabgpd6w/SL2sTm50Sd1Emt9bLLQlZocpvPQh2g== Date: Mon, 8 Jan 2024 18:47:11 +0100 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: Jonathan Corbet , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] buffer: Add kernel-doc for block_dirty_folio() Message-ID: <20240108174711.3woihy7ho47bckng@localhost> References: <20240104163652.3705753-1-willy@infradead.org> <20240104163652.3705753-3-willy@infradead.org> <20240108133117.xtkbzeiqq6dtesm5@localhost> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4T81jG5dJHz9scW > Actually, how about: > > * If the folio has buffers, the uptodate buffers are set dirty, to > * preserve dirty-state coherency between the folio and the buffers. > * Buffers added to a dirty folio are created dirty. This looks good to me :) > > I considered deleting the sentence entirely as it's not actually related > to what the function does; it's just a note about how the buffer cache > behaves. That said, information about how buffer heds work is scant > enough that I don't want to delete it.