Received-SPF: pass (google.com: domain of linux-kernel+bounces-19918-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Elad Nachman <enachman@marvell.com>
To: Conor Dooley <conor@kernel.org>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>,
        "linux-usb@vger.kernel.org"
	<linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5
Thread-Topic: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5
Thread-Index: AQHaQX3VP+0+HUIapEqUlXjf5E6jabDQKXQAgAAIUMA=
Date: Mon, 8 Jan 2024 17:47:24 +0000
Message-ID: 
 <BN9PR18MB425195C57E2FC24D5F331C19DB6B2@BN9PR18MB4251.namprd18.prod.outlook.com>
References: <20240107152557.3561341-1-enachman@marvell.com>
 <20240108-zoning-tactical-20501dccfac1@spud>
In-Reply-To: <20240108-zoning-tactical-20501dccfac1@spud>
Accept-Language: he-IL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?udVK4FPHe8ArnD8BYOdZui1K+QgAc3tNVSaoEj1gzLn2srObsY075NqKr2/B?=
 =?us-ascii?Q?BB3AIO9iOYOMHIa6R7RnEUi02QwrO9LBlzZkQS5flRqg0qsJ2m9JGwwAW+Cz?=
 =?us-ascii?Q?/Ebfs+V1l6SzZEmo6jOFoo8Rz53FT+sFih8+r8SlJg1Ky53763VVodUNx7Tc?=
 =?us-ascii?Q?+vIdnPzB0QpbHQPOR+rNjmWk5fqp9A3813dyCwI+Ty22JVKYHI10WAwFmfli?=
 =?us-ascii?Q?xH3kDYz7Pj0AMul/kig2DzuRlb+WCtwmqIO4J5YpWrjGD+66XtGVizSPh1qJ?=
 =?us-ascii?Q?ObYNzkN9vldXxac4vWOYy7jlBhD1AmDeUXE4YO1ce+iu7lv+GIp8809P2dwl?=
 =?us-ascii?Q?I4ALfmUBTJiWWSKVERyT2ewFERx/tqUxImcRjfers3gLET+4c3fp6yeJAL24?=
 =?us-ascii?Q?j6QWYSjscNAuZxu6bE4p9Q9bfzcsecslOV2HqSjQQhq+dLRKjABzRUWB3kLA?=
 =?us-ascii?Q?Oh27LDwm2zC3qgLXwnu/zef7/1v5ZXlmqDr+fTZ4gMPJGdOhDKw4oWPDJlVV?=
 =?us-ascii?Q?RC5nc+P4GCW0R1VsekVALm+q1g65JlIQwUahFede9uQtZnUvWh6WMU3TLnZz?=
 =?us-ascii?Q?2OVpkn052JA1r8FY6SQAVWrtiasHMRswMjeSzLVDcpVgtjp5P+NgyU37YZar?=
 =?us-ascii?Q?xyr2CjO6umdsVKY+XdCaCPnNChTlU+Og3C/f5bplkZhAK3Nbwctbgqdm2JVs?=
 =?us-ascii?Q?i06njWfvEUZWl+fUcH0w6RJ0/6i3sVsOw2BAiNLK2KnJneLR7yhRkl5NXCKX?=
 =?us-ascii?Q?6tPRbfOD/u7igLn2vzlBq1MH0dwgCHBBhQFg+b3MxAnPyNbrxKJ4Jvis5QG6?=
 =?us-ascii?Q?de7onhHnvpCSo7J5pE884BBGvn0PDnkiKZjyJ8IKvDM9AjX/jJSKggxiK5rf?=
 =?us-ascii?Q?xSZ0xrGO2v43izolhBLIBCXVzZcLcHdOJfD1htT3PQMzdGV7biSRNZF7dE51?=
 =?us-ascii?Q?yGyBcGnU50tK3ccNRheczLDJ3+IN8Ei3lm6TE+FrYbb/WMgzCAVBZw36eog9?=
 =?us-ascii?Q?FUg3Fn43hTpE7SwjwGl7HHJfUZMNAL3K8IblSYdOH4F/aTv1i/0bHkXT8TVK?=
 =?us-ascii?Q?TktNQL8szjpHlpWmZHSr5NtohMnAzCpU2PizptKkxBY0Tzu2AZ8uI+PDV7Yg?=
 =?us-ascii?Q?z5gktu0c8IXwtUd4P9oGKYG4tAaV35O65UMnbpbbz8QQwBH8EaD9oTH/y8uX?=
 =?us-ascii?Q?wKZ6vRIZ5LgD78QFPNOT9ILVg8SGyAZlxFbVq7EXxkTUB4+JpkFPzfDJSqyX?=
 =?us-ascii?Q?dY4I2pwbAd2t6jfhbfM0pV6GZJy0MMu+XCIi4wn2FkIICSrzbq6gn3FU1kCn?=
 =?us-ascii?Q?X2NzuJsHBGkt9zmafh2CcRumedSP7gwhG7JQAvOBmZ0weUhPnN8YKDso5j/W?=
 =?us-ascii?Q?sMb5gtFb98KDALgbYMmuHQ+7N6bj1rxjzMjIkVB/7GK2ugTWIbctlSUYwdS9?=
 =?us-ascii?Q?WuJdrn6FYDXyItM0sohqu74xGhOep1U4jrD9YEfJtFNXwCi1Z9mRPSjyw87W?=
 =?us-ascii?Q?LFo0GJFVew6W6qO2jVISGqY8EnS+4X8WDRZWuCsMgM25c0IjU1EMCqt1kvh6?=
 =?us-ascii?Q?vVOB+M3iDZo3bW1/35VDlYyTSSFZua5BEgHF8wm7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR18MB4251.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 883a91ec-4195-4639-626b-08dc1071df47
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 17:47:24.3022
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hE9EsXcpTWKrXUX6cINcPNXlvo9dj4X6iCH32+PtGfiUrKS2atJgfhtQpC91lmMVD4YjMEYLUrqolGuflV1d8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR18MB4529
X-Proofpoint-ORIG-GUID: AeT2zlNWvbOVril_FFN1obxSae-ZW3PL
X-Proofpoint-GUID: AeT2zlNWvbOVril_FFN1obxSae-ZW3PL
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02


> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Monday, January 8, 2024 7:15 PM
> To: Elad Nachman <enachman@marvell.com>
> Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> devicetree@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote:
> > From: Elad Nachman <enachman@marvell.com>
> >
> > Add Marvell ac5 device tree bindings to generic EHCI.
> > This compatible enables the Marvell Orion platform code to properly
> > configure the DMA mask for the Marvell AC5 SOC.
> >
> > Signed-off-by: Elad Nachman <enachman@marvell.com>
>=20
> Maybe I am dumb, but I don't understand how this does what the commit
> message says. There's no fallback to generic-ehci or any other compatible
> that is already understood by the driver.
>=20
> What am I missing?

Following guidance by Andrew Lunn on my mmc patchset, I have split the patc=
hset
Into a single patch for dt-bindings review and another for USB driver revie=
w.

The USB driver patch utilizing this new dt bindings compatible string is he=
re:

https://patchwork.kernel.org/project/linux-usb/patch/20240107163307.3677347=
-1-enachman@marvell.com/

>=20
> > ---
> >  Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > index 87986c45be88..2ed178f16a78 100644
> > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > @@ -77,6 +77,7 @@ properties:
> >            - const: usb-ehci
> >        - enum:
> >            - generic-ehci
> > +          - marvell,ac5-ehci
> >            - marvell,armada-3700-ehci
> >            - marvell,orion-ehci
> >            - nuvoton,npcm750-ehci
> > --
> > 2.25.1
> >

Elad.