Date: Wed, 12 Dec 2007 11:23:21 -0800 (PST)
Message-Id: <20071212.112321.250771549.davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: marcin.slusarz@gmail.com, linux-kernel@vger.kernel.org, adaplas@gmail.com
Subject: Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' symbol
From: David Miller <davem@davemloft.net>
In-Reply-To: <20071211165700.fb20c939.akpm@linux-foundation.org>
References: <20071209213429.GE9440@joi>
	<20071211165700.fb20c939.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1501
Lines: 43

From: Andrew Morton <akpm@linux-foundation.org>
Date: Tue, 11 Dec 2007 16:57:00 -0800

> On Sun, 9 Dec 2007 22:34:33 +0100
> Marcin __lusarz <marcin.slusarz@gmail.com> wrote:
> 
> > fbcon: fix sparse warning about shadowing 'p' symbol
> > 
> 
> Please always quote error messages and warnings in the changelog when
> fixing them, thanks.
> 
> > ---
> >  drivers/video/console/fbcon.c |   10 +++++-----
> >  1 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> > index 0f32f4a..849e114 100644
> > --- a/drivers/video/console/fbcon.c
> > +++ b/drivers/video/console/fbcon.c
> > @@ -2795,7 +2795,7 @@ static int fbcon_scrolldelta(struct vc_data *vc, int lines)
> >  {
> >  	struct fb_info *info = registered_fb[con2fb_map[fg_console]];
> >  	struct fbcon_ops *ops = info->fbcon_par;
> > -	struct display *p = &fb_display[fg_console];
> > +	struct display *disp = &fb_display[fg_console];
> 
> We have a global symbol called "p"?  That would be bad.  Where is it?

I'm curious about this too.

Ahh, I see, look down a few lines in fbcon_scrolldelta(), we have:

			if (logo_shown == vc->vc_num) {
				unsigned long p, q;
				int i;

and that's where the warning is coming from.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/