Received-SPF: pass (google.com: domain of linux-kernel+bounces-19939-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Elad Nachman <enachman@marvell.com>
To: Conor Dooley <conor@kernel.org>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>,
        "linux-usb@vger.kernel.org"
	<linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5
Thread-Topic: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5
Thread-Index: AQHaQX3VP+0+HUIapEqUlXjf5E6jabDQKXQAgAAIUMCAAASlAIAAA88g
Date: Mon, 8 Jan 2024 18:15:51 +0000
Message-ID: 
 <BN9PR18MB42513EDDDA454FA50249205BDB6B2@BN9PR18MB4251.namprd18.prod.outlook.com>
References: <20240107152557.3561341-1-enachman@marvell.com>
 <20240108-zoning-tactical-20501dccfac1@spud>
 <BN9PR18MB425195C57E2FC24D5F331C19DB6B2@BN9PR18MB4251.namprd18.prod.outlook.com>
 <20240108-chariot-thinner-7a86808a0571@spud>
In-Reply-To: <20240108-chariot-thinner-7a86808a0571@spud>
Accept-Language: he-IL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?/N3ktLklnrCRSHPdoxiR5SHKUaM3/PgACvgohMxFhBCT5f4OugbmXdlNHSSL?=
 =?us-ascii?Q?fGKZNB1YVDc9fNonsS7FtkLTEanN7UljlfctHUOvFfcEQ0PgmvBoOZqOCr/+?=
 =?us-ascii?Q?0wgZpLfMyiXcqn6pAfnFm1jauzYCuk6zCqCKw7iuYsjxi4J+WBo+BFa956Ub?=
 =?us-ascii?Q?meTexbhEUvFiON8QGSyB+iGDdeInPLl0Iyv6ztWLwOYibDssRnCZQE50DHuL?=
 =?us-ascii?Q?2WHurW0GLAgf9jHsLjYjRnqJcOeaZl/7fDHhjW1g0voK+CIdkQIS4nI9Hv6m?=
 =?us-ascii?Q?IOJKR+gBiEn71NMkUWQeEfFCXnTKDFGwXe3KzNZk8SoRhef9eRsXJlIQPib3?=
 =?us-ascii?Q?3UEXZzN1Crsb2035QB6KJXa16F8AeYQzHfJsdTU/MhffNyuQ7czKxJsipqeR?=
 =?us-ascii?Q?jumHVszWUqgoliZlMBuZBr/zACKlwHc+YpJ20yoH+Gsl44gqe1WVAPdqkXG5?=
 =?us-ascii?Q?L0GqHias2cLdwBp6BEvBPs4A+aPpniISLT53rzLZlp2iCmgX+6HrVSq1/vEb?=
 =?us-ascii?Q?h/oVVai6YTusOaMO2w9tB35T0i3Lfuvic6VjpC4OZa0LM1zSf9IkmY24YRqR?=
 =?us-ascii?Q?2fTPU73kn2HcJlXSc8gljX7saNKEUVfGumceJmGecVxOK4ILlMyXGyo2gjDR?=
 =?us-ascii?Q?rWqcXl6WyRdFDFr5yvq4Khi+A9915hAT8MwFLBnOLfduwy6WGK15Yx3tCrtg?=
 =?us-ascii?Q?cG+7JIAcKFjtgfkPYGZKIrHeXAoPB5cclcd8w2II/Eda2laJpywc/5n4z3ME?=
 =?us-ascii?Q?rz6CZ3oouI0TmbXXfHOim42r2pkNU0sYtboDFBC0UKGocPseyxMu6nvAulDV?=
 =?us-ascii?Q?zMWlv2tr9lC7jBK8MkgVWQGSt/gXVd9flzhKjjV+/rlqEBlmqtyVl2ojV8nn?=
 =?us-ascii?Q?a8q8kfZhmNYk1LC0FCE4IhKj68W2u1XSlWYyjIxDK6x7WAqDe+N+mmnfcKgK?=
 =?us-ascii?Q?GLLOZle7YVMTmn0EyECJbBsXCYlkFf+jfZt7yP02KLJH9ZgFbUG98NU5jCRM?=
 =?us-ascii?Q?Nkezz7dYE4BiXrYlpn7/I8ttLr40Dct1IffO4vDQw8O3UyDBcydN3kNzBlfD?=
 =?us-ascii?Q?Tjep3pCUC6jQppgg8vqdllALkMz4CnsF+S6bnjuCG2nsxXXPaBQyDGYFSN0L?=
 =?us-ascii?Q?7t8ie+MplgjjUMRW04Qe46ON1i01lMFAlzcQUJ+2rmzQJZ/iB/g2GQf9A94P?=
 =?us-ascii?Q?d3PVedzvqhpI/uCDdEkeRl1FYMIqR/VWp8G1djGBC/BIjDj5en00MRXLbgs/?=
 =?us-ascii?Q?DCobvVMN7xoAYUPvIhhNCvEBi4Ode1XxCnfMcfa+v3TL0DmDLIw6GK+3wkRU?=
 =?us-ascii?Q?M6P4z7rpVQKHTQxGKy8kw80XU50ZM47HYxNK2v8ZF6fXh2DyRpZgoxnnQ8o/?=
 =?us-ascii?Q?87T9jloC1wniGX/opHoFW7UBhrSUT0I6L4MiWbneVZ2RJvSrMFJJJpppTBdA?=
 =?us-ascii?Q?DFt0Y9IZGwIAC5YwYBAfjQMZC8KXXYbuIsA3dHRo9ryQ4qs27Bw/+JhToW72?=
 =?us-ascii?Q?2KXogEo/ipPxtMbTm2T94yjd7SPbgcToQdIczqQ/vA7ijx0Zhvc/Ph/s3Mep?=
 =?us-ascii?Q?t226lRzQp6wthFKXAZSSZnejItvN9uXPa8R7tPym?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR18MB4251.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aeaf429c-ded4-44a9-3935-08dc1075d8b8
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 18:15:51.2440
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8ECKiU4sk9YwHvRwzf5rEejzqVcJkdFDsG0xn9WklRSI13iMXdPL02JAalkcH0Bm2qPkxAjAugHXGs5+CFdf2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4409
X-Proofpoint-GUID: maxn0hWB4wuIub9UgVELeQwhKEwgiMIP
X-Proofpoint-ORIG-GUID: maxn0hWB4wuIub9UgVELeQwhKEwgiMIP
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02


> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Monday, January 8, 2024 8:01 PM
> To: Elad Nachman <enachman@marvell.com>
> Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> devicetree@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5
>=20
> On Mon, Jan 08, 2024 at 05:47:24PM +0000, Elad Nachman wrote:
> >
> >
> > > -----Original Message-----
> > > From: Conor Dooley <conor@kernel.org>
> > > Sent: Monday, January 8, 2024 7:15 PM
> > > To: Elad Nachman <enachman@marvell.com>
> > > Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org;
> > > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> > > devicetree@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> > > kernel@vger.kernel.org
> > > Subject: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5
> > >
> > > External Email
> > >
> > > --------------------------------------------------------------------
> > > -- On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote:
> > > > From: Elad Nachman <enachman@marvell.com>
> > > >
> > > > Add Marvell ac5 device tree bindings to generic EHCI.
> > > > This compatible enables the Marvell Orion platform code to
> > > > properly configure the DMA mask for the Marvell AC5 SOC.
> > > >
> > > > Signed-off-by: Elad Nachman <enachman@marvell.com>
> > >
> > > Maybe I am dumb, but I don't understand how this does what the
> > > commit message says. There's no fallback to generic-ehci or any
> > > other compatible that is already understood by the driver.
> > >
> > > What am I missing?
> >
> > Following guidance by Andrew Lunn on my mmc patchset, I have split the
> > patchset Into a single patch for dt-bindings review and another for USB
> driver review.
>=20
> I don't understand that advice. dt-bindings should (almost) always be wit=
h
> the driver. Otherwise you just confuse people like me.
>=20
> Perhaps Andrew meant sending dt*s* patches separately from the driver &
> bindings?

The rational was different people making the actual merge, into different i=
ntermediate git REPOs, before mering into linux-next.

>=20
> Cheers,
> Conor.
>=20
> >
> > The USB driver patch utilizing this new dt bindings compatible string i=
s here:
> >
> > https://patchwork.kernel.org/project/linux-usb/patch/20240107163307.36
> > 77347-1-enachman@marvell.com/
> >
> > >
> > > > ---
> > > >  Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > > > b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > > > index 87986c45be88..2ed178f16a78 100644
> > > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> > > > @@ -77,6 +77,7 @@ properties:
> > > >            - const: usb-ehci
> > > >        - enum:
> > > >            - generic-ehci
> > > > +          - marvell,ac5-ehci
> > > >            - marvell,armada-3700-ehci
> > > >            - marvell,orion-ehci
> > > >            - nuvoton,npcm750-ehci
> > > > --
> > > > 2.25.1
> > > >
> >
> > Elad.

Elad.