Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1800793rdb; Mon, 8 Jan 2024 10:33:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfY8pSUBqekaIGt7fleGmdQzKYCsIf1cptvaaeHRJEGVN9d9CovC5TzHiuaxkuafCtIAtj X-Received: by 2002:a17:90a:4944:b0:28c:f473:23c9 with SMTP id c62-20020a17090a494400b0028cf47323c9mr1481998pjh.11.1704738787844; Mon, 08 Jan 2024 10:33:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704738787; cv=none; d=google.com; s=arc-20160816; b=OSqg7b2N6cyDFUU9hrtdVYV7NQWkZ+UZQo8k0wynlMN7fcLlU+6NXhz+6TtHGE8TsA 4SyZx/1iKZ7Zd83/JkX2JmI1Iqc3eYi+/gLOe+eylnOqaWj/NO9PdAptlwXx07auun/l MtgJroVklC2U0qD0KCdpJyXiPKoH3cM3V/2WrcWwauzdGKEBSh5NHa1sw1RaDURZOhV4 QqdRoofDWfdZSiWm8xHiD6dD7IEImuCgoXNob/gBdYOIg02O8a4YJdwZfIoC6z0xbjo+ qd3nb0apnFg4UNxdp+iDJZwbMlsEW+aopYLU5MkWhJFBtGuKEH5dRveKH3CGhhzNzMAT CqNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nCXFqFh1N8Z9iVe4ZoL40JShS1Yrz8GTKzYcsOx6688=; fh=WI2J2hjrxPzoOHrCVYTE8o9L7dK7Ov/h6PX+i7038V8=; b=WPWtqEoY8GCSVmLHvbFpadBhlKRWGc9frfkgmD/iS1vmqDc+8D+WNA1PI2nA1uDn4v a2I5t8xyRiomEQQKDfHTeuxdqcUTxMDhJbDZ02GZ3t1APWkBY44yzGMsGg5UMwT9kEbS z9eFHeGO96A2lCRjiqg3CZeaiUk2gtD74L5mXCBVv4Ndxe9fF+/jdNHuYG+ZQJ9HNeOR aMSe4QWunpvxwR2T6yOMCMLQzVwD/SrRkZq4VJ5qBxMH9usrfQ0PgUgCdwuteQiS0Bu6 qOK8saHeUZI3XeLAXwDRLG071fjFUxxKiCkUUVTSQXfAjqaQNyye4ytIDdS7HrKd8KJg um2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="leA/eWMR"; spf=pass (google.com: domain of linux-kernel+bounces-19961-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19961-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id na4-20020a17090b4c0400b0028b9ab6be8esi280853pjb.61.2024.01.08.10.33.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 10:33:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-19961-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="leA/eWMR"; spf=pass (google.com: domain of linux-kernel+bounces-19961-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-19961-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6E4E42848A8 for ; Mon, 8 Jan 2024 18:33:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7437C52F9B; Mon, 8 Jan 2024 18:33:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="leA/eWMR" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA3B654F80; Mon, 8 Jan 2024 18:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704738778; x=1736274778; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=F+MtWtXNmcKgKfhazz5ks8Nh+6BaSWwtIMg/qzqL/8A=; b=leA/eWMRG1IX/4G6jy/EM0GsCF0bYqpkn1c9Gc1YpHmyBuy739gcHVRz OWkXwLdOLdduZNLEPuXfgHpnR7TYPEkEo6VmTHKg9AQpuarTxZVlpXjK9 lG4FAXTuw1vo8q/iw4aB7NGG+yAFOsKRWbTsxXLdpDOnmpFkN7HSYJjwd YDtm0GmDrNB1W1PuwsyXPLYNA2HUS4oPPB/KIssG/KicXsB829EdWkPFX uWgXZh6TJ5+9/GYNGfCwXP6J48tJRm2G5pg8+FykdUmK0+8fvnBuGgCUS 0G5ZsUNSOs9J40HS5qzPaexi4WOL2lF4EVyTYAcCry7UL4qbeVpeSsS5v Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="484147853" X-IronPort-AV: E=Sophos;i="6.04,180,1695711600"; d="scan'208";a="484147853" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2024 10:32:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="1112807511" X-IronPort-AV: E=Sophos;i="6.04,180,1695711600"; d="scan'208";a="1112807511" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2024 10:32:54 -0800 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 5021A11F7E4; Mon, 8 Jan 2024 20:32:51 +0200 (EET) Date: Mon, 8 Jan 2024 18:32:51 +0000 From: Sakari Ailus To: Mark Hasemeyer Cc: LKML , Sudeep Holla , AngeloGioacchino Del Regno , Rob Herring , Andy Shevchenko , Krzysztof Kozlowski , Konrad Dybcio , Raul Rangel , Tzung-Bi Shih , Andy Shevchenko , Daniel Scally , Greg Kroah-Hartman , Heikki Krogerus , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org Subject: Re: [PATCH v4 22/24] device property: Update functions to use EXPORT_SYMBOL_GPL() Message-ID: References: <20240102210820.2604667-1-markhas@chromium.org> <20240102140734.v4.22.I186bc5737c5ac4c3a5a7a91e9ec75645e723ca7b@changeid> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240102140734.v4.22.I186bc5737c5ac4c3a5a7a91e9ec75645e723ca7b@changeid> Hi Mark, On Tue, Jan 02, 2024 at 02:07:46PM -0700, Mark Hasemeyer wrote: > Some of the exported functions use EXPORT_SYMBOL() instead of > EXPORT_SYMBOL_GPL() and are inconsistent with the other exported > functions in the module. The underlying APCI/OF struct fwnode_operations > implementations are also exported via EXPORT_SYMBOL_GPL(). > > Update them to use the EXPORT_SYMBOL_GPL() macro. > > Suggested-by: Sakari Ailus > Reviewed-by: Andy Shevchenko > Signed-off-by: Mark Hasemeyer Thanks! Reviewed-by: Sakari Ailus -- Regards, Sakari Ailus