Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1824782rdb; Mon, 8 Jan 2024 11:20:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHB4Qt7zGz3AxFRUMi+kFZJz+RxTNqmBgRPehvZH36QwwffVlFq8NyrwgfviOhDyH/WpyjC X-Received: by 2002:a05:620a:294a:b0:783:1498:2769 with SMTP id n10-20020a05620a294a00b0078314982769mr5252111qkp.123.1704741616963; Mon, 08 Jan 2024 11:20:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704741616; cv=none; d=google.com; s=arc-20160816; b=bMUqLcHm8sdYNxN9O6YG61iVusDN+WCENB/N572nN1cv0nY3okLeYTNQj8NOV04Cng cXKyRDfg1EINe417vmQ4ySNn5M9d1pfFTyhWif+gJ6vRS/wFX23Y1cFegEoFbTelscLe RyPtgSNTnG6ynZoaHjI2L+CpkvM1TMuQYg92ghaG7aB+1rA0meejs4Cb2ALvbJ+JryQs DPmmqXVwgo8qdfV54FAvcaYH/90GpC4roE0wB1WYdTqKFnzP/SLeeCAgzOseWE1p0qlL OMa+DJOlXmWNBK/oMf2lpLEAej0E2JqwJ+Kx23JEDTnacUosV/71OTjKG4qenrDvlSoF pN8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=+oXQEvZyRm83EC0SdphMRj69tozvt9DFLasvJhLf/LE=; fh=y9wjkdK45QeiG2fPhAX5gQm8OI29SrCRYPvNoWySsZE=; b=PQ+UQ9kqJUVNPAN6fC4K8BOf2qTZI+JJHfbibkATNRpUGIlfmgJQAvaZmjj84RMLTV DEQDuELbYpkO9ckWOlKZxGMy/H4uUYrFzDAWwRjdCbMDiM1Lg39+gWQ1MH/wIL5Vse6w R1SaaDm/933YrTXmTzvtlJjU7JWofKUK3gtwrdjVaZmvFY706l7zJm18jY7SI7ybzTrO 2ronVOvs3ymJ9HSuV+kH+xYgyw20hhQ0mM187HIapBG89IYOnjeM06rJjoA2zQEN1dDO 6oHaRAfo64WcAIEgfdYFR+zZQKBaxtiMsY81L94w3uS+RvAISVN1V7jXJOh4cLuY0G/Y SF5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=KccVwIMV; spf=pass (google.com: domain of linux-kernel+bounces-20013-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20013-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o17-20020a05620a229100b0078193bdd6aesi322731qkh.503.2024.01.08.11.20.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 11:20:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20013-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=KccVwIMV; spf=pass (google.com: domain of linux-kernel+bounces-20013-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20013-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 53EE61C235B6 for ; Mon, 8 Jan 2024 19:13:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 103CA54FA3; Mon, 8 Jan 2024 19:13:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KccVwIMV" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C64DA5576D for ; Mon, 8 Jan 2024 19:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-557a615108eso2309a12.0 for ; Mon, 08 Jan 2024 11:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1704741224; x=1705346024; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+oXQEvZyRm83EC0SdphMRj69tozvt9DFLasvJhLf/LE=; b=KccVwIMVrYMTbAd5xZYhE4O3dGD63qx+gbJodl3V2UFPJ2j360qi+l+uhuxP6UTQ3N 5oeUDc0ioui0Kxio+fUtFhvg3Yf50B3burL/QshR01HEclBM2/aPFNCexSYLrV4gAKYa HssAnQ9cP0Q7VeGFJlc4FyD8G3TR29l7NHX5k2sbr1ONWroubiymSCMPhDSZTxhllXmv KDiLMCuameKwYFSd2b9tebKLGywjymFS3MuiMiJR7QMDFGSvqhT9mM1YvoIrqKHJQput L+c974SjSYOFkAKZ1RLKE8+lN67jdrrApw4bmUFHEprnbN7jZuljDWOL57G5hgKcl/3E LBRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704741224; x=1705346024; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+oXQEvZyRm83EC0SdphMRj69tozvt9DFLasvJhLf/LE=; b=jg291gKICmQqH+R52MQgwMEizVzExEur8WCmct6a0vgQ5o/dC07fzKpxm0renAt0d3 aGY9hzTZSakllh+5MUgGv8746fQXTxIKMin+bv2VGHwIRFJ4MscE11F4csNLpU9k20rV a7uKqEHClXeuLh1AhCnB9n/FKsN+Oui+c9hRtRqzYQI0OWH4SbvCzq0+e2q7OWX6BUCZ iuX3jIuK3H/kDexceOfZRRx1eCyk+9pfscd1f1/Zq1la08mmO4oMQdGymp01kJ2FCkUF bz0R5nAhpjHfN4q6D/gAN7Hr8glNa2ek7HwBlX/5RJyIyFqzTmVnprGCcQ2hJj+BH6KB OKtA== X-Gm-Message-State: AOJu0YzMT7JU10sieE/imauZRy07YQDfo9lNAEzlWFEn2tuO6PKMzkZ2 ///gnaZvAfBjFc+knANO6KTI7+e73Tmx9Z9Z8Miep2YvUqA5 X-Received: by 2002:a50:cc87:0:b0:557:15d:b784 with SMTP id q7-20020a50cc87000000b00557015db784mr1775edi.2.1704741223938; Mon, 08 Jan 2024 11:13:43 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231214230850.379863-14-rdbabiera@google.com> <20231214230850.379863-19-rdbabiera@google.com> In-Reply-To: From: RD Babiera Date: Mon, 8 Jan 2024 11:13:32 -0800 Message-ID: Subject: Re: [PATCH v2 05/12] usb: typec: tcpm: process receive and transmission of sop' messages To: Heikki Krogerus Cc: linux@roeck-us.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, badhri@google.com, bryan.odonoghue@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 19, 2023 at 6:07=E2=80=AFAM Heikki Krogerus wrote: > Why not just fall through? > > case TCPC_TX_SOP: > default: > negotiated_rev =3D port->negotiated_rev; > break; > Will do, thanks for the advice! best, rd