Received-SPF: pass (google.com: domain of linux-kernel+bounces-20032-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <716b825f-67b7-4d08-9bd6-41c9bc4deb3d@kernel.org>
Date: Mon, 8 Jan 2024 12:20:11 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 1/2] net/ipv6: Remove unnecessary pr_debug() logs
Content-Language: en-US
To: Breno Leitao <leitao@debian.org>, weiwan@google.com, kuba@kernel.org,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Paolo Abeni <pabeni@redhat.com>
Cc: leit@meta.com, "open list:NETWORKING [IPv4/IPv6]"
 <netdev@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>
References: <20240108191254.3422696-1-leitao@debian.org>
From: David Ahern <dsahern@kernel.org>
In-Reply-To: <20240108191254.3422696-1-leitao@debian.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 1/8/24 12:12 PM, Breno Leitao wrote:
> In the ipv6 system, we have some logs basically dumping the name of the
> function that is being called. This is not ideal, since ftrace give it
> to us "for free". Moreover, checkpatch is not happy when touching that
> code:
> 
> 	WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> 
> Remove debug functions that only print the current function name.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  net/ipv6/ip6_fib.c | 4 ----
>  1 file changed, 4 deletions(-)
> 

net-next is currently closed; repost in 2 weeks once it is re-opened.
You can add this to both patches:

Reviewed-by: David Ahern <dsahern@kernel.org>