Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1828767rdb; Mon, 8 Jan 2024 11:30:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHl4bfC71HUsGCvnoA31pjyihLkOrjqYXgR1S6fmL6I3L33sAFZnZ5a/ZXx9xd3N5DNA1Wz X-Received: by 2002:a05:620a:2947:b0:783:1395:3ce7 with SMTP id n7-20020a05620a294700b0078313953ce7mr5027422qkp.98.1704742212309; Mon, 08 Jan 2024 11:30:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704742212; cv=none; d=google.com; s=arc-20160816; b=sNBeYborPjjVyGkCCWASHJq5/5WM4HayLUpy0cufCJIL8DHCjT99la1o9aq3osgJY/ SZ5VLU/69Jk9zY0hQr87WUVHNtpsoDNCr3NbbIVZimLycIAFVDreLoPd3DEOkIL9THuR iIVElGFyFc+9A2YZLAiWUeeqCHlAb3MiaT5RjBP6Tnk+ZAF4NmMCujrFuytOTG3+GSzm LV5966CD0ANNGgWXdcma3usdsggCtqmTkCYI32MnRMo3O+Y50GcdFj+E9PB7e4hjF3m9 6weLhj0HkgmeWc2727tv/05hGAzXXLOYVEhmGwhup77kCEdH3yN4IYe23w0aaQ/ndYlv VnGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=fQIGvC3B84QK5cy6jpGTUHpfklayyMVGJTSNMpLqXZU=; fh=1WU4STQYYHTDJM+DTP2/xK1mp9I7i6BWK+QyqIvGzH8=; b=QMFnE+xTWzPh8pPiKQl2X4HMhgS1swrEtYI1+D6gYbeLso86RZTMk0VYCcN1413CNi U3iWTMssrVqMuI8fFKnZ5awm4IkndD+9s33WML9ZvK7Xp3Z+QxA4wSvxze9COEh35pu4 RFke+d0D+7EglWCKSy2pDuV4y0OmY25p1z9eAZ30CSRvKS3lOYtIhv2gabelryPcsaYw DGigehBtRvYPm4KsVgury9oTJr7s7AxfLh33fGpFwMouIQS7hRuDUHbvebKU2KYbMVuM kFU0ZIi5hDp/dG2pbnuforZ6UL/mMJZlkdbsMgL7691Wh3gY4rgEX6M5xW+qBlV/Mysm byEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=boh5onHu; spf=pass (google.com: domain of linux-kernel+bounces-20044-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20044-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id bj36-20020a05620a192400b00781e1bde7fcsi393892qkb.264.2024.01.08.11.30.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 11:30:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20044-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=boh5onHu; spf=pass (google.com: domain of linux-kernel+bounces-20044-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20044-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 020C11C21FFE for ; Mon, 8 Jan 2024 19:30:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7994A5576E; Mon, 8 Jan 2024 19:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="boh5onHu" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC5BB53804 for ; Mon, 8 Jan 2024 19:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5578485fc0eso1430885a12.1 for ; Mon, 08 Jan 2024 11:30:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704742199; x=1705346999; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fQIGvC3B84QK5cy6jpGTUHpfklayyMVGJTSNMpLqXZU=; b=boh5onHu4tQDLYH3f7Z2hFYQX4G/njtR0zBB7iVYd2gZDuAWKZ3D7epRmnya9sdFGr OFO2sIn9pecuwSkSOdmdGDJywaw+gvDfkLCgbcv/6vX/NDtzMT4KqRXrrERNUw6neQO5 lEBW0IS/BA+8M9Rg1SmourwTV4nMO8OSakjZHrFi9DED5GyYd8BtCIDtuVIQTjklmeWT q7Vku0LmqHKNo+T+pe8tH4hOcMptt+nNWkHpQAkfcusMTpiJ8tCSgXjNxLic3oZ/zr5g qPwbVvO53Ik9vkm8dAs+gptZgOWQqySLZ3jkukJtlaQWwUatIPqiHv+YCW4Zgv1gexej 8eOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704742199; x=1705346999; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fQIGvC3B84QK5cy6jpGTUHpfklayyMVGJTSNMpLqXZU=; b=kYlGR5Hevg1Sa3FToxNjYmUfZZh/CK65PvysMpElLwtE6z6bpMo2sqpeslPr2hrXZa EXeFtjf2vWQJmhfMX1I06RonjuWKfiOuncUPnEqIZ3YEdkJjOK6t8E6QqCXz1VeYti+D vI8K/ctm9DRWqD0HN3/j5ek9dMV2gkTtqYHAq2m8r+aVXGzE8X3eWempqWk9I8Ehcjqf 0oakW65YPBN1diBHbqSZ47BjRxmfwHjjBV9qg2p+eqSwsfTL6EPgE7pXXxzqdGy5trf/ mIoJPFZMGZ5wW0dWkZHrhowLCviA15I0OPe1Q1JsDOCSEOpWPRg2m6x8B2o2TPHfuH+Q 3Gsw== X-Gm-Message-State: AOJu0YyAH8ZHbN/DxbPnEHI7LJRrfXUkmitVVZOBDM012iHt1d/4Wfnw eoWrbcXqBlWiD5RQMPb2zMrr2NAJZNpuJA== X-Received: by 2002:a50:d59a:0:b0:554:5ab4:85a0 with SMTP id v26-20020a50d59a000000b005545ab485a0mr2715915edi.81.1704742199074; Mon, 08 Jan 2024 11:29:59 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.112]) by smtp.gmail.com with ESMTPSA id e11-20020a056402104b00b0055534d5e75csm148417edu.6.2024.01.08.11.29.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jan 2024 11:29:58 -0800 (PST) Message-ID: <069b44ce-5d95-4d39-91f0-5167a5d941b1@linaro.org> Date: Mon, 8 Jan 2024 20:29:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] w1: add UART w1 bus driver Content-Language: en-US To: Christoph Winklhofer , Jiri Slaby Cc: Rob Herring , Conor Dooley , Rob Herring , Greg Kroah-Hartman , Krzysztof Kozlowski , Jonathan Corbet , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org References: <20240106-w1-uart-v4-0-7fe1378a8b3e@gmail.com> <20240106-w1-uart-v4-3-7fe1378a8b3e@gmail.com> <5ff1d706-9f06-4eb6-bc86-75f933e54118@kernel.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08/01/2024 19:03, Christoph Winklhofer wrote: > ... >>> +static int w1_uart_serdev_receive_buf(struct serdev_device *serdev, >>> + const unsigned char *buf, size_t count) >> >> serdev already uses u8 * here. You are basing on the top of some old tree. Old? Your change came for v6.8 and this was sent when all trees were based on v6.7-rc1. What newer tree could have this been? > Yes, this patch is based on the w1-next branch of > git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-w1.git > was not sure from where to start. I guess that this change is probably in > the w1-tree after the next stable release. That's a timing issue. For that particular case, where this was targeting next-next cycle, you should have based this on linux-next. In other cases this would require cross-tree merging due to dependencies which none of us were aware, so no harm. Best regards, Krzysztof