Received-SPF: pass (google.com: domain of linux-kernel+bounces-20149-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <65e7aab3-ac50-442e-b559-00f2345c8a29@intel.com>
Date: Mon, 8 Jan 2024 14:31:50 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/4] selftests/resctrl: Add test groups and name L3 CAT
 test L3_CAT
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>, Fenghua Yu
	<fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
CC: <ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>
References: <cover.1702392177.git.maciej.wieczor-retman@intel.com>
 <de2ea86256f0026989e6836f9e731be3667c7afe.1702392177.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <de2ea86256f0026989e6836f9e731be3667c7afe.1702392177.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2dJWGdNTXl4WWVwODlyVWEzT0NBWVNRRklxRkN5cUFhZWJRT0VXTkp2QnFj?=
 =?utf-8?B?LytwcXgvUXJzRFk5QWhJRVJhbXMyMGpzZnMyZmFYYjRrMFJPMjlxaXFTVmkx?=
 =?utf-8?B?WDRBWHdHMVdpZjZPWTFlVnlqYUJCcFNsYjhlUFJHV1lvSVFsN3pkR1dXR3B3?=
 =?utf-8?B?WGlpSzY2bmRSK2pSL3FNSzV6S3FSb1A5MlpoTmVlSlF6Y1BESzBHZUg5eGZn?=
 =?utf-8?B?ZjluNVRlMkZoTzdPOEtiVHIveDF3eU5YTGFpcnVpQUNRa0Fua3Ard2VPNHNU?=
 =?utf-8?B?bGtTaDYwbG1FSDQ2WENIelZOTnBxTmFpT0o2aVVhMGp5Z1dld25qbFZSVXB1?=
 =?utf-8?B?U1lFOFVYeGVRL3N6djFxWUlSSmRmdW0rZzRXSDVhdHE2OG15d1FJQzE2bWRH?=
 =?utf-8?B?Y1l3eDc5Z2xUZmVhS0hMR3FBc3dvUjl4enV2all4ZW1Ma2ZpcUwyY1VadW8x?=
 =?utf-8?B?Y1hyaWpSL0ZTRVczVGsvbGFwcWJLZWp5anlqZ3oxVDJWaTJqaUh2ZFptM3FH?=
 =?utf-8?B?dGZIUWM1ZXk2bUhMVVQraWhGbWZBTWplbUFYSEluUkloclEveGpOZ1NsVlNo?=
 =?utf-8?B?VW9UMWhjZnBlZEp1Z0g3eHZ6QUlEYWVkdk9uQTJMcHJYUkZvSG1KT1NGMkN3?=
 =?utf-8?B?ditXT1BINDMraW5QcE9nSVhIY2xqT1NrZUZFcGFsek9mUm5qdXlyTTVZN0Yv?=
 =?utf-8?B?RW1ERTljVC9MV1JwWVdPUlloMktmUHlpd2ZXUGZoWTRUa2xyajNBdUF0Mm5H?=
 =?utf-8?B?dDFFS00xM0lCcFAvQVdIeEs2SjFzQW4ycGpXNzk4SDc2MmsxZlZpclZaNTcx?=
 =?utf-8?B?UUpVaWlHblg5RDkyZTc3WEpCcDR4cU5TNEEzVnF2Q0lhTTNrQzBKL0dGZ3pS?=
 =?utf-8?B?eXBDelZNT2RUdjlBRVpaQkdvTDRweW5NeC81WEs5Yms4TllGUm5SSDNsZExZ?=
 =?utf-8?B?QVJFMXhzdENEZXlaN2ppY0UrMHhPOW9wSmlYbjZrallYSmNMT0Rlb1RrK01R?=
 =?utf-8?B?UnlLeDRSTEs1dkJZZHVxblBuWDFZanRBZUhvMytEamljRlhwK24wdlU3MUUz?=
 =?utf-8?B?K00vVjdWTU1xSVBoenhRMkZxWlFITEsrWjY1bTZ4VDljMDZ2Rjd5UFd0MU8x?=
 =?utf-8?B?MTNMTmVBM0UrVldCckE0SU55MzBHVUpjMTBlUW0vcUJKcGIvWExYbzc2c2xU?=
 =?utf-8?B?VS93Vzdma0R6Q3BTS1BKbkRUZGNqSVdCVDIwQ0JUOVB5TFVCVzVzYzVYOFJa?=
 =?utf-8?B?ZzNNL014TjZnaGlLVWVZaUJFczkxQ0dzYXl4NXdTZmlHekFVNUNrRkE4VGww?=
 =?utf-8?B?QjYxMXdqV3BueHhKVG91bllSTVcvdFlxbDBXRlRsc2t3eURpMVpUcFdmeWFH?=
 =?utf-8?B?Qjh5QjcvdmV0YTVXUUhpK25xUUl5RmtQN0xWMDdpQldSS0pFNGlsV1VkK3E3?=
 =?utf-8?B?NWVOSXhVZVRKR09JdHJBYTVZU1ZCOVBSTnl0S1RYZkU0bTdCUnlUZDA2RndE?=
 =?utf-8?B?V0d3elZ1NTg2T3FMWm9qYU9MeUJPNjErcGhCc2Z5UHp3djV3dkUrUnh6eUNa?=
 =?utf-8?B?a3hqTEkvMUJac0VDd3BMK2dYWjZyR25iN0tqeGlhbG5uVGIvalhMM1o4ZEFv?=
 =?utf-8?B?bjBIMGJDbktWdmFxb011WHg5Y0NmSEljYUZ2OEVQd3BlMkF3MjJHN1hSZVRD?=
 =?utf-8?B?UUZCY0JpSnQzSy9zN1FxSE9kNlo2S0IwNDN0VVQzUS9PTEZqd1NrbHVGUXZl?=
 =?utf-8?B?UXBnSkpsd2x3bHMvTjJTYlRBYlZVdzZqb0hXSGRpbHA4aUpZUTdGRlM4NHJ4?=
 =?utf-8?B?V2FJbGJoZnpwSTZmZjVKSmVOeTEvc0dkRVhIck13TGJkWk5lbndYYzBmRWlK?=
 =?utf-8?B?QitHekhzc1ExaVBFM3FDRWRSYUx6aU1vMFNKK2Q1dVkzaTE5ZlY3UWE5ZnQ3?=
 =?utf-8?B?QTI2NjBWOWlTR2RtUHJFQmlQdkxXaFp2N2laSHVOWVdIVGlNcVpTTWJ5YXBL?=
 =?utf-8?B?RDhVeWpaT2k1dGI2RkNtVDQ5bTA0WEwxSmE5MzlYb3hjaFJaNUJxYjcwVHRN?=
 =?utf-8?B?TUxVWlpLUVFMbVc4Zi9vdkFrNUdnVm9aWUpDY1R6RWVMc0JsZE5RSFI4Z1k0?=
 =?utf-8?B?dFRGZFd2aFVvdTZwY0VLRmx0OFpORVd6SDVOWGhpNEVYdjZwcU9JczJuOGpO?=
 =?utf-8?B?K1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4362ca3d-d730-4363-a086-08dc10999cc7
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 22:31:52.8084
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nmmNe/aziEB95rtpe1aankZVssmv7ZplM2fF50u9GwfvECRUvMZIGYGIEoa0Zv6cxe1H/M+vaCWECgQ397NsuHmpBrBhT7CcNBE22pNcn1Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7707
X-OriginatorOrg: intel.com

Hi Maciej,

On 12/12/2023 6:52 AM, Maciej Wieczor-Retman wrote:
> From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 
> To select test to run -t parameter can be used. However, -t cat
> currently maps to L3 CAT test which is confusing after more CAT related
> tests are added.
> 
> Allow selecting tests as groups and call L3 CAT test "L3_CAT", "CAT"
> group will enable all CAT related tests.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---
> Changelog v2:
> - Move this patch from Ilpo's series here (Ilpo).
> 
>  tools/testing/selftests/resctrl/cat_test.c      |  3 ++-
>  tools/testing/selftests/resctrl/resctrl.h       |  2 ++
>  tools/testing/selftests/resctrl/resctrl_tests.c | 16 +++++++++++-----
>  3 files changed, 15 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
> index 24af8310288a..39fc9303b8e8 100644
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -295,7 +295,8 @@ static int cat_run_test(const struct resctrl_test *test, const struct user_param
>  }
>  
>  struct resctrl_test l3_cat_test = {
> -	.name = "CAT",
> +	.name = "L3_CAT",
> +	.group = "CAT",
>  	.resource = "L3",
>  	.feature_check = test_resource_feature_check,
>  	.run_test = cat_run_test,
> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
> index c54efcf1412a..739e16d08a7b 100644
> --- a/tools/testing/selftests/resctrl/resctrl.h
> +++ b/tools/testing/selftests/resctrl/resctrl.h
> @@ -65,6 +65,7 @@ struct user_params {
>  /*
>   * resctrl_test:	resctrl test definition
>   * @name:		Test name
> + * @group:		Test group (e.g., L2 and L3 CAT test belong to CAT group), can be NULL

Could you please remove references to L2 CAT test that is not available yet? A
detailed description of what a test group is will be helpful.

Reinette