Received-SPF: pass (google.com: domain of linux-kernel+bounces-20152-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ddc900a6-7337-4721-ab0f-917c32e917ff@intel.com>
Date: Mon, 8 Jan 2024 14:36:36 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/4] selftests/resctrl: Add helpers for the
 non-contiguous test
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>, Fenghua Yu
	<fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
CC: <ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>
References: <cover.1702392177.git.maciej.wieczor-retman@intel.com>
 <c7b66a4682829894ec72d8a1f78e324233ef0535.1702392177.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <c7b66a4682829894ec72d8a1f78e324233ef0535.1702392177.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkwyUUlabXZOOWdhR2pDaVJrOWE1d2JEMG8yUjVCMTkxQm9oUGFmeUJacmxI?=
 =?utf-8?B?NmswaEpPYXVHa3ZmN21TSnZRZnEzRXJxbTRaMG9ITWRMQnQ0OXlCZkdaajM2?=
 =?utf-8?B?eXE2bGdOaHVmVFc0TGFWbGJRSnFxZVZ5dDVYaVBNeTFESzhndFUreEc4eTZQ?=
 =?utf-8?B?bVRHVE9wVjlJRSthSHp4SzBSVS93eGFKUnE5ZmpmYUp0ckxsMzJXZEI4MUg4?=
 =?utf-8?B?VlBaRXZxS2RjVi9CYkt1SnVtR3pDdHE1TnN0SVZTUmk4RlVFcDlmUGMvL08x?=
 =?utf-8?B?U0FWQjZyRzA5L2pjNGdEWG41WDBjZnYzSFZlMURPTnpMSUFMcTVrUGpxODlZ?=
 =?utf-8?B?TkNDelE5SWNVK3lUNWNGTzR4bGdzZUpvby9uSDBCTlpwbTlxblA0ZmdJVklv?=
 =?utf-8?B?MTQ0ZWpzTVZ2TWNKZ0o3b3IwSWZ1Umhsd0gwVmZpSlpHOE5ha0tPSFNzU25w?=
 =?utf-8?B?SEZpZ1NjQjhHRHUyb3NaR3B5Y1Zzbmt5OHlYcytQaE9qTGI5ckc5cWVRSTRC?=
 =?utf-8?B?bHp2T0JSdk9ISWkwSUhTdFRNSVpLZnZWa1FkZmFoSjE0cmNyb3FjZGYvVDBI?=
 =?utf-8?B?YTZTZW81aEVMTlpiUnNjdFlyTTZjT3Nzc0ZFZjlkYTJHaFZLakRqWEUxRW5T?=
 =?utf-8?B?ZmxFSkt3bmJNbWF2WTJiSmFFTStSRTR4UmVIcm1ORzVDZTgyWDNjSzYxeWJ6?=
 =?utf-8?B?d0thaUMzbi9qQTU1TytLejZ3SzM5MUVXblhpSHRJbkd4dFV3ZVREbGlxZnpW?=
 =?utf-8?B?TXliSTZqWGh2K0hCdkFYd2RVNE93cG9XQW9TMVR0Sm9WcGMvc1FVbTVndm1C?=
 =?utf-8?B?OU81bDFLRHB6bjNoVGgvRkxsNkZXZk8vVk1pb09RRUZoQXRtYTIzOUZMVlZ4?=
 =?utf-8?B?SHhONnB1dXBJdVdvb0dHcFVKUEpDcmVmYStsVDE3ZUxBOVhKbVozRG00dnNM?=
 =?utf-8?B?dFBncmFJWE5PWmJHRHF0bitPd2dUZHVlTU1KU0JMd2dRTy9zUHRPcUNxL25x?=
 =?utf-8?B?YWk1RU04a014QTRMVmtqVVdBcEU4MEJIQThkN2pqQmEvdyt3TEgzSjk3dVY0?=
 =?utf-8?B?cGVxL1ZBejdPdVFCMEZhaDkrU1ZEMngwdEZmMmtsb1c3TmJzQytZeVhnZzNZ?=
 =?utf-8?B?enNGOUJiWUdKYnRYOHpvRStONnBVUGh6aWZxWi9LSUJaYVZuNjl2ZXR1N2N2?=
 =?utf-8?B?N3RKSFhFS2RvNWpTWjRNMUF2cHE1RnVyYWZoaVdwUmdUUERxeTl0anZlaFBu?=
 =?utf-8?B?R1pYZzEzZkh5anVsaENEeFhRT3FIYUZENFlUSWNUVmZWWk5SZll5emZPVUZI?=
 =?utf-8?B?ODFld3FGQWVNcmFhODF2eC82QVR5UnVock4ydDlwSVg1RlY5MzRLcEVjQ2oy?=
 =?utf-8?B?S0xwWHJiNnlsbFV2dUdjMkNMNXB3M3YwOXd0NXZMV1FldXhRQ1lHK0hzdmpy?=
 =?utf-8?B?Q24vK0J4R0Nmc3NMMkRjRkd5L1Z6MkZBOWRZVG50MkU5UlNBbjJGclZ1b0h4?=
 =?utf-8?B?TmpKMDZQN1FkekdMM1d5MlUrVENhOWMyTFY4Mks5TzVMRXFDM3c1S2RUc3NS?=
 =?utf-8?B?bThSeHVQZnpORFhOTW83WjQzMk42cEN0NHpjK2tYNVo0Snp3dS9uSUJ5SXlQ?=
 =?utf-8?B?cE5ORG51OElWeFUrbzJHZTZ4OUpBQjY4a0dIZEJnV1VxS25STVZmSzhoQXNW?=
 =?utf-8?B?TzdpSllsVGRSNW9kWUNvckRCOTZkL25zSVhXaXdJUUJ3N2lkbFBsNlVYazNG?=
 =?utf-8?B?ZWsvNDFwYXdmNFZ6bXhtZE15K1YrNnMvb3dVcG8yL2JXQ1JxWGhZU2pRTnB6?=
 =?utf-8?B?TTgrazZ1UEJ2TlpqNnJxZmQ3cmdDOWdOeUdpNXBlSEREOTU1QzdLQnZLcWp0?=
 =?utf-8?B?VXBqZkFXNVFBekZOOEtYS042T0VXQng1ZDcvdEt5N1lyMmxTbktLU3JUM25G?=
 =?utf-8?B?TDlRM0ROZmhmNWw4TVFIY0M3WFRlT2FyeEVXMVg1TWwvS25PWGdjVittU2hI?=
 =?utf-8?B?RExWWStudlRhVW1sZWphVFpNb2JuK2Q1eUV4dS9mL1lqRWNHSGk4dHEvZnM2?=
 =?utf-8?B?Q1J3dWlqam5menpVZDBDR3lmNE5sdUxyRnlNaWFmakJGbXpvejZRNFhFVXJw?=
 =?utf-8?B?bXhsM3R3dmhTSzRSZWZ0ejM1T21Gd3FCQkpwV3VkNWVkeThZWG5yZW8xelVL?=
 =?utf-8?B?S1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e54ceda-c7ab-4f1e-1780-08dc109a4729
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 22:36:38.6203
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: stTTszMmRQUEnZdUKlRBjDjN/7yuKak9NzxO8J1qsJ8o7XZ627QOC5JeiHmOEF47Onb9/otZMIkiOtz61gSyMWv6rg/JzcBNR8+Yr15FBL4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6524
X-OriginatorOrg: intel.com

Hi Maciej,

On 12/12/2023 6:52 AM, Maciej Wieczor-Retman wrote:
> The CAT non-contiguous selftests have to read the file responsible for
> reporting support of non-contiguous CBMs in Intel CAT. Then the test

"in Intel CAT" -> "in kernel (resctrl)"

> compares if that information matches what is reported by CPUID output.
> 
> Add a generic helper function to read a chosen functionality support
> information.

Since this is a generic function that just reads a value from a file it
cannot be assumed that the value represents functionality support.

> 
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---
> Changelog v2:
> - Added this patch.
> 
>  tools/testing/selftests/resctrl/resctrl.h   |  1 +
>  tools/testing/selftests/resctrl/resctrlfs.c | 25 +++++++++++++++++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
> index 739e16d08a7b..8f72d94b9cbe 100644
> --- a/tools/testing/selftests/resctrl/resctrl.h
> +++ b/tools/testing/selftests/resctrl/resctrl.h
> @@ -161,6 +161,7 @@ unsigned int count_contiguous_bits(unsigned long val, unsigned int *start);
>  int get_full_cbm(const char *cache_type, unsigned long *mask);
>  int get_mask_no_shareable(const char *cache_type, unsigned long *mask);
>  int get_cache_size(int cpu_no, const char *cache_type, unsigned long *cache_size);
> +int read_info_res_file(const char *resource, const char *filename);
>  void ctrlc_handler(int signum, siginfo_t *info, void *ptr);
>  int signal_handler_register(void);
>  void signal_handler_unregister(void);
> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
> index 0e97036a64b8..70333440ff2f 100644
> --- a/tools/testing/selftests/resctrl/resctrlfs.c
> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> @@ -249,6 +249,31 @@ static int get_bit_mask(const char *filename, unsigned long *mask)
>  	return 0;
>  }
>  
> +int read_info_res_file(const char *resource, const char *filename)

Considering that this is intended to be a new generic utility, could you
please add some function documentation?

> +{
> +	char file_path[PATH_MAX];
> +	FILE *fp;
> +	int ret;
> +
> +	snprintf(file_path, sizeof(file_path), "%s/%s/%s", INFO_PATH, resource,
> +		 filename);
> +
> +	fp = fopen(file_path, "r");
> +	if (!fp) {
> +		perror("Error in opening sparse_masks file\n");

The error messages do not match the goal of this function to be generic.
Also, please note the recent cleanup done by Ilpo to replace the perror()
by ksft_perror().

> +		return -1;
> +	}
> +
> +	if (fscanf(fp, "%u", &ret) <= 0) {

I find this to be potentially confusing. The function claims to be a generic
utility to read a value from a resctrl file ... but hidden within is that the
value is required to be unsigned, which is then cast into an int. This could be
made more specific and robust with something like below:
	int resource_info_unsigned_get(const char *resource, const char *filename,
					unsigned int *val)

The return value will be the result of the request. If resource_info_unsigned_get()
returns 0 then @val will contain the value read. 

> +		perror("Could not get sparse_masks contents\n");
> +		fclose(fp);
> +		return -1;
> +	}
> +
> +	fclose(fp);
> +	return ret;
> +}
> +
>  /*
>   * create_bit_mask- Create bit mask from start, len pair
>   * @start:	LSB of the mask

Reinette