Received: by 2002:a05:7412:d394:b0:fa:1366:e242 with SMTP id bq20csp1106442rdb; Mon, 8 Jan 2024 15:16:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQZ3SNn+PGB/pL5OoqgIyT4ZSeSaO2QECQ+toKoCAxR1+ycM0e0CMynEvPznR8brKhjTIT X-Received: by 2002:a05:6a00:138f:b0:6d9:e7d0:327f with SMTP id t15-20020a056a00138f00b006d9e7d0327fmr5258609pfg.23.1704755807198; Mon, 08 Jan 2024 15:16:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704755807; cv=none; d=google.com; s=arc-20160816; b=kKE0cEft8HBPFFyDIs6WXuiyG0eSl+ljAr/O84/0GgibA6jkCSCRFy74ce9ynYLWtP VOQX2F/za3h+zy22/JSdCqvqMPmV/lW2mE/czlMjjdZoUUeEzEDIsagq5kbfzLSTq0AX fIgtHxUQq9E1Wdsvz1yFwih2iAQCFnupcu9g5cFu+EPamW7sTnk11l34fdYP+Y2PQgqj X0Yqj/GEB8dtsa6xfcYBq88rZgI5c1lh4/9SoG3cj5ItOBuoCVRVMlFCYrza+JjIMgW4 YBr5RN/AecBw6x0/nhrGkLVIlJYIwGiX9bM3XE4RQ9YwGJl8UbqzkH1Q5iVGBg7TPCzm loOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9jvC0ZseLyZgnJyGaQkGzxAFiwtUf83guqMQ4grVe94=; fh=DXklw9DYxQfpB1QxDcp/lomnYCpvoiqhRy72EMvSJtg=; b=iwgr+YXPRHt/ZSKSY12K4QuCXcXzQ6WRk/BXFA351C3oY17eRhKk3LwHHAEjM9Up33 qziFlZgII/3L/RxT90gEjWFKVsZpRL+/Tol/n6gZYgmfCbARyg5dGO30RS+0QwPn0/X9 UcYk4s/Yo6E05o8pd0MpkIk53l6zTTePYt3JmDdRfF4djUB1DkNHuwgdT1UrrV37qvWx ktKgOjo2xbuS6R5b9yFHpT0kSSwKzaT7yfGVIW+WbmCWj7VEPWHM6ViemU5X0zvbKfSU GLKICw18+nXjYUPvDc2Lm3d5Hr8B+3fWYMQJnBGoH+XqkL4O+V6PlgnKqh8eN88j64Sb Ncgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=mQBGoEXb; spf=pass (google.com: domain of linux-kernel+bounces-20173-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20173-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e5-20020aa78c45000000b006d9b4294509si503809pfd.200.2024.01.08.15.16.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 15:16:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20173-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=mQBGoEXb; spf=pass (google.com: domain of linux-kernel+bounces-20173-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20173-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DF6342850E0 for ; Mon, 8 Jan 2024 23:16:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1AB0056467; Mon, 8 Jan 2024 23:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="mQBGoEXb" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C74EB672; Mon, 8 Jan 2024 23:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9jvC0ZseLyZgnJyGaQkGzxAFiwtUf83guqMQ4grVe94=; b=mQBGoEXbf54zNBQdFS06MzrkdA lXxnEANfpQxtRGBUbocCKLxl3268+HSTslshaDre0Mam8GaS8v7n9LVURGM7exKr0nnUlM1LF24S5 TqP6RanW/Hsg252imdkyEcszPkGctZs1/qPQOZCaYowXP9pYO5qAlMprjCWGYElxyhcCY9HMU1b5Q CmPFhwmBDXeO+9d9nZe5CWjmN4+f/6gQv6fEi6jmuL8UaqoEfTOTAaHwUIbLXwCZ/Se9crw4y/m/U E7ZFyiExS0o0iA/1CCvrljXMyEBZr9IjdoI9NKcguRqaryBwU1TrfXdxb6jasX0Sj2WIvvQ2iPwcX BOlLqjSQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rMyr6-008kQd-Ve; Mon, 08 Jan 2024 23:16:29 +0000 Date: Mon, 8 Jan 2024 23:16:28 +0000 From: Matthew Wilcox To: David Howells Cc: Lukas Bulwahn , linux-cachefs@redhat.com, linux-fsdevel , Linux Kernel Mailing List Subject: Re: Reference to non-existing CONFIG_NETFS_FSCACHE Message-ID: References: <1542013.1704750095@warthog.procyon.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1542013.1704750095@warthog.procyon.org.uk> On Mon, Jan 08, 2024 at 09:41:35PM +0000, David Howells wrote: > netfs_writepages_begin() has the wait on the fscache folio conditional on > CONFIG_NETFS_FSCACHE - which doesn't exist. > > Fix it to be conditional on CONFIG_FSCACHE instead. Why is it conditional at all? Why don't we have a stub function if CONFIG_FSCACHE is not defined?