Received-SPF: pass (google.com: domain of linux-kernel+bounces-20187-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Frank Li <Frank.Li@nxp.com>
To: krzysztof.kozlowski@linaro.org
Cc: Frank.Li@nxp.com,
	bhelgaas@google.com,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	festevam@gmail.com,
	helgaas@kernel.org,
	hongxing.zhu@nxp.com,
	imx@lists.linux.dev,
	kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org,
	kw@linux.com,
	l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-imx@nxp.com,
	linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org,
	lpieralisi@kernel.org,
	manivannan.sadhasivam@linaro.org,
	robh@kernel.org,
	s.hauer@pengutronix.de,
	shawnguo@kernel.org
Subject: [PATCH v8 13/16] PCI: imx6: Clean up get addr_space code
Date: Mon,  8 Jan 2024 18:21:42 -0500
Message-Id: <20240108232145.2116455-14-Frank.Li@nxp.com>
In-Reply-To: <20240108232145.2116455-1-Frank.Li@nxp.com>
References: <20240108232145.2116455-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?K/SZ5BkdA+5vW5+Yd0EhvyETMueHkGyAc0jRp2OY5s7dOopl5X0TEqUtZfmp?=
 =?us-ascii?Q?ACtFO3yOmoGDSPXPdL7pWEeS4u7NXTzoSa6JKfB/vEUyUv5UGcaUhb75Flfm?=
 =?us-ascii?Q?A16FV6VP9VzgrDH08yOOKuKLZ6uSF2iWBQRSoJ+Rx8Btq0ZSVn0Zcy5R3c2a?=
 =?us-ascii?Q?3D4dzKLCPv+yIO76+foiYNfya92vTE1EtrcuPatKADhZSaRvf1Gn34HerkWv?=
 =?us-ascii?Q?L5e6wD7vyUkrqf7x+8evUB0oUOU/Eby5rWcuMXZZZc7s59o6DAKYM0/Hk24b?=
 =?us-ascii?Q?Yd9cLKdoBfQDuMoRV1BcV2XUnQjt6DVPPNfyEebmqRtl0/x43ncA1gDRTQ3A?=
 =?us-ascii?Q?28MVeUI3qsohGjmQWMw+4jjgG7hBUtkXgD0kENn5jT/WBWqjMQGQLKSLlKfx?=
 =?us-ascii?Q?7xOKhiTzEU2VdcYlnflgUB6cMqpklKbGJKWH29YnXsSAxZIzIWn7A9d4oVOc?=
 =?us-ascii?Q?pYF1vxTozcODV1OKLkihWL6Z3ayaCkQ1n3luQjjlJVHG2IdpVtRnKfnPoay3?=
 =?us-ascii?Q?Rr+sIoiUDrA2hA22ssIFnO4/fqV4cp9QnrOgXrGTg3nDMRpKE7ap0IYpu/zq?=
 =?us-ascii?Q?fsmLKzo5nZrFCJAcIbEHbp5rlV8NUNS8E2erP7Btq/NQZTLcoNhJkGDI2+e+?=
 =?us-ascii?Q?Aljd5m8ynxldyPwWJXQvi98Auitob6alZZIZhXYIbOklQ/HKiV8No5Hd+CTU?=
 =?us-ascii?Q?CIkpIBniPDQEz579t2d0P0i/B6rY2t5XrHnDdZIN7Hr10hybePU67hL8l0pt?=
 =?us-ascii?Q?w+S1piySygmY/yGvbDM2pV+UYuH4jikTyQdYVh2mtZ0W+Nrt6XlmQbqZA6t4?=
 =?us-ascii?Q?F9wcgbpb+Gy1uHwZeURTQXlvPl6+BSVnvgRMkLHcFX1SCPmVXHI3GC+6rnzI?=
 =?us-ascii?Q?j7Eqe3Uvr9xSIauZv1IGrOqHC1HUS0LyfP+yV82BLIsoM88tY3BreTtVC8eE?=
 =?us-ascii?Q?N6AGGdA3Mh8JB7EB00sbztwpuzvG3ux3sKp/StVvEFL84WlqJNjxyqVqW0cZ?=
 =?us-ascii?Q?wZwID48BNHavG+RAvGQGMVJvTQo3LDGIlYsp90iE7aBQv+Ydl5r3rTF0AqSp?=
 =?us-ascii?Q?mVcBOl5oP4U40QKlrFXWayy7/66pZQtDYVbw4TQuLdROpUrInV5UWvAx2HTE?=
 =?us-ascii?Q?vEqFxDTygaaRBkwHkvhma5eBs6x2BsWlk96aE2gDvC7e3OAb8uRXgEUKaSy4?=
 =?us-ascii?Q?n4tzmd8rpUA/FwrcjBR62tumqZr0eyYmzoZtSqGDwQtdNWs8TdtZudRwbza0?=
 =?us-ascii?Q?lNPHZ41U61rkLJazL+8CX4ezkFLTlPwQhPb/ZvNpIOs9Rb0Lnfxu3brj/hNv?=
 =?us-ascii?Q?zwY96sybSf1u0zikePWS05+v5zkyT8vvXRuVTAX5hEY1Y1MFv2EbH7jPUCqc?=
 =?us-ascii?Q?xUjRwgkvXVarGDZFdzUCBRABPWG4LWqsYYSPvuTVms22fOgP903Cl5RE6ctR?=
 =?us-ascii?Q?WDjVl9vgiv4dd6kDJQcbbvND+xAmxJqTvBx2yGhecJ2woEVHF4wUAWmXSXG8?=
 =?us-ascii?Q?Od5q+NQKMHL9H3VPJydasCBe+N/xUdqC7Ff3QxHs5I1P2efjW1zb2k09IKvT?=
 =?us-ascii?Q?osdIXg+l3BDgloFV4uGVSJqUR5D+dNqj5YDcP3/t?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9010b052-e6f6-4825-22e3-08dc10a0ca0a
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB7511.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 23:23:15.1813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +39VItxanu+vlhWtxQ5XPWCTNhMrR1CRXEk2teC58qAMQfSuM7HRYPCg9Yp/f1WwJ8mFhiSbF8YzutWKaJEmaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9338

Since the dw_pcie_ep_init() function is already fetching the 'addr_space'
region, no need to do the same in this driver.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v7 to v8
    - update commit message
    - Add Manivannan Sadhasivam's review tag
    Change from v4 to v7
    - none
    Change from v1 to v3
    - new patches

 drivers/pci/controller/dwc/pci-imx6.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index c0d08cd55d681..1741af88040be 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1067,7 +1067,6 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
 	int ret;
 	unsigned int pcie_dbi2_offset;
 	struct dw_pcie_ep *ep;
-	struct resource *res;
 	struct dw_pcie *pci = imx6_pcie->pci;
 	struct dw_pcie_rp *pp = &pci->pp;
 	struct device *dev = pci->dev;
@@ -1086,14 +1085,8 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
 		pcie_dbi2_offset = SZ_4K;
 		break;
 	}
-	pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
-	if (!res)
-		return -EINVAL;
 
-	ep->phys_base = res->start;
-	ep->addr_size = resource_size(res);
-	ep->page_size = SZ_64K;
+	pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
 
 	ret = dw_pcie_ep_init(ep);
 	if (ret) {
-- 
2.34.1