Subject: Re: [PATCH 1/1] fix 2.6.24-rc1 nfs_file_mmap change for NOMMU
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "Berkhan, Enrik (GE Infra, Oil & Gas)" <enrik.berkhan@ge.com>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <050A770C1DB41144817F02E395E493105257D4@FLRMLVEM02.e2k.ad.ge.com>
References: <050A770C1DB41144817F02E395E493104CE014@FLRMLVEM02.e2k.ad.ge.com>
	 <1197427230.27750.3.camel@heimdal.trondhjem.org>
	 <050A770C1DB41144817F02E395E493105257D4@FLRMLVEM02.e2k.ad.ge.com>
Content-Type: text/plain
Date: Wed, 12 Dec 2007 15:03:24 -0500
Message-Id: <1197489804.9042.9.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1289
Lines: 35


On Wed, 2007-12-12 at 08:29 +0100, Berkhan, Enrik (GE Infra, Oil & Gas)
wrote:
> Trond Myklebust wrote:
> > On Sun, 2007-12-09 at 19:52 +0100, Berkhan, Enrik (GE Infra, Oil & Gas)
> > wrote:
> >> - generic_file_mmap returns -ENOSYS for NOMMU systems; replicate this  
> >> behaviour 
> > 
> > Why do that after going through the process of revalidating the inode
> > etc.? Just replace nfs_file_mmap() with a function returning ENOSYS in
> > the case of CONFIG_MMU.
> > 
> > Better still, in the case of CONFIG_MMU, instead of having an
> > nfs_file_mmap(), just replace the .mmap field in nfs_file_operations
> > with a call to generic_file_mmap().
> 
> I just tried to make it work without really knowing what I do :)
> 
> I have mailed another patch implementing your second suggestion (the system
> still boots with nfsroot).

Thanks. That patch looks better. I have 2 questions, though:

     1. Is this urgent enough to warrant pushing into 2.6.24?
     2. Are there any filesystems which support mmap() on !CONFIG_MMU?

Cheers
  Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/