Received-SPF: pass (google.com: domain of linux-kernel+bounces-20261-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Feedback-ID: ifd194980:Fastmail
References: <20240108032233.4280-1-garyrookard@fastmail.org>
 <20240108032233.4280-2-garyrookard@fastmail.org>
 <897a8bb4-a1d7-46ab-96cf-fd5ba447d2d8@moroto.mountain>
 <87edesvtrx.fsf@fastmail.org>
 <62836460ae502097ca8307bcee85a5ae3634e1acc74af843ffc466c28d1a0b95@mu.id>
User-agent: mu4e 1.10.8; emacs 29.1
From: Gary Rookard <garyrookard@fastmail.org>
To: Gary Rookard <garyrookard@fastmail.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>, gregkh@linuxfoundation.org,
 philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: rtl8192e: rename variable is40MHz
Date: Mon, 08 Jan 2024 20:25:55 -0500
In-reply-to: <62836460ae502097ca8307bcee85a5ae3634e1acc74af843ffc466c28d1a0b95@mu.id>
Message-ID: <871qarcmzt.fsf@fastmail.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Gary Rookard <garyrookard@fastmail.org> writes:

> Gary Rookard <garyrookard@fastmail.org> writes:
>
>> [[PGP Signed Part:Undecided]]
>>
>> Dan Carpenter <dan.carpenter@linaro.org> writes:
>>
>>> On Sun, Jan 07, 2024 at 10:22:29PM -0500, Gary Rookard wrote:
>>>> Coding style issue, checkpatch avoid CamelCase,
>>>> rename it. is40MHz -> is_40mhz
>>>>=20
>>>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>>>> ---
>>>>  drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++--------
>>>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>>>=20
>>>> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/stagi=
ng/rtl8192e/rtl819x_HTProc.c
>>>> index 6d0912f90198..1b1cb9514028 100644
>>>> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
>>>> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
>>>> @@ -87,36 +87,36 @@ static u16 ht_mcs_to_data_rate(struct rtllib_devic=
e *ieee, u8 mcs_rate)
>>>>  {
>>>>  	struct rt_hi_throughput *ht_info =3D ieee->ht_info;
>>>>=20=20
>>>> -	u8	is40MHz =3D (ht_info->cur_bw_40mhz) ? 1 : 0;
>>>> +	u8	is_40mhz =3D (ht_info->cur_bw_40mhz) ? 1 : 0;
>>>
>>> This should be is_40MHz.  It's metric.  M means Mega.  m means milli.
>>>
>>> regards,
>>> dan carpenter
>> --
>> Okay, stupid me didin't give it to much thought that way,
>> ...wow there's more that way then just mine
>> Good catch!
>> Regards,
>> Gary
=2D-
There's only mine that I can find, I'll fix them up
and resubmit them.

Thanks for your insight.

Regards,
Gary
=2D-=20
Sent with my mu4e on Void GNU/Linux.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJNBAEBCAA3FiEE1kC7bOvmQRqDVDSVKPZpkA66T0EFAmWcoZYZHGdhcnlyb29r
YXJkQGZhc3RtYWlsLm9yZwAKCRAo9mmQDrpPQc37D/0Ubc8io4K+JZLcQR6KDY93
ldeMGQWrWCpffSZxHG2DJJkhO8LOI6ZcWcjeq1B9r8RRRiXwDXYbSXH7Hm9DQCTG
nC3qaJ2gRpk2MA897WdmVrfLGGYtFJB7Z+GkX+JOZGE1y4g/syL54buXq/UQc0GX
e7g7+TG/e2x094BWc54axLJC4xq0PvKYZZCw+yXkInP4f2Nvw5Xz5+3s4qwoOiBd
DB1sx1lHA0ZMNvNuSgF+T7mAeAwHSRBHVFQHUJUGFIvhUIvUH+0YDtNtV9K9vknr
Z6TKvqwSFRx217xjG1ddi7/099rIdXVtbppOaquVU36lvwbyTAsnl/+MlMnBHiLI
TggvSTDXvRKQMX1NP1S5K7MOe09YsCsyunlcRm1HtZGCc3NVvjgR1XT9ysNg0tv2
4rfzQC1XIcrhW+Fnd6p5rZKPXKFR6xdBMr4XuAg+uyJzP0rByh8r03+Vz4jbXpVx
I0D9U6VRpdY2WCjA1lHVGjeyxDFXF3qOCLh72gLHW+cU9MxYFBBoFTJ9EFUawxW2
L6fQMwixnMP+Cv7iyqKWCgGLmDzRs1f3r6cDiGqDJrVezCfDGX6YDbf88ia/3q0A
jJSQqiOoL43Uo1qgyaoRzq5Us3vGcHhGNjR9Jfx9gdL85vfGd4EKBGrPPVpIh1OH
MDbq7ZH1g2r1v9TfXuKRvg==
=4+ac
-----END PGP SIGNATURE-----
--=-=-=--