Received-SPF: pass (google.com: domain of linux-kernel+bounces-20263-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240108033138.217032-1-wangrui@loongson.cn> <20240108163759.GA2899468@dev-arch.thelio-3990X>
In-Reply-To: <20240108163759.GA2899468@dev-arch.thelio-3990X>
From: Huacai Chen <chenhuacai@kernel.org>
Date: Tue, 9 Jan 2024 09:40:06 +0800
Message-ID: <CAAhV-H7Qu9yj1d+fAcE3vL0=1FUOD8x0v+AhCr7Bj5yuQstndQ@mail.gmail.com>
Subject: Re: [PATCH] scripts/min-tool-version.sh: Raise min clang version to
 18.0.0 for loongarch
To: Nathan Chancellor <nathan@kernel.org>
Cc: WANG Rui <wangrui@loongson.cn>, WANG Xuerui <kernel@xen0n.name>, llvm@lists.linux.dev, 
	linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, 
	loongson-kernel@lists.loongnix.cn, Tiezhu Yang <yangtiezhu@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Applied with R-b/A-b tags and fix typo together, thanks.

Huacai

On Tue, Jan 9, 2024 at 12:38=E2=80=AFAM Nathan Chancellor <nathan@kernel.or=
g> wrote:
>
> On Mon, Jan 08, 2024 at 11:31:38AM +0800, WANG Rui wrote:
> > The existing mainline clang development version encounters diffculties
> > compiling the LoongArch kernel module. It is anticipated that this issu=
e
> > will be resolved in the upcoming 18.0.0 release. To prevent user
> > confusion arising from broken builds, it is advisable to raise the
> > minimum required clang version for LoongArch to 18.0.0.
> >
> > Suggested-by: Nathan Chancellor <nathan@kernel.org>
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > Signed-off-by: WANG Rui <wangrui@loongson.cn>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> Thanks a lot for all the work driving getting everything to work
> properly with LLVM!
>
> > ---
> >  scripts/min-tool-version.sh | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> > index c62066825f53..9faa4d3d91e3 100755
> > --- a/scripts/min-tool-version.sh
> > +++ b/scripts/min-tool-version.sh
> > @@ -26,6 +26,8 @@ gcc)
> >  llvm)
> >       if [ "$SRCARCH" =3D s390 ]; then
> >               echo 15.0.0
> > +     elif [ "$SRCARCH" =3D loongarch ]; then
> > +             echo 18.0.0
> >       else
> >               echo 11.0.0
> >       fi
> > --
> > 2.43.0
> >
> >
>