Received-SPF: pass (google.com: domain of linux-kernel+bounces-20304-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Theodore Ts'o" <tytso@mit.edu>
To: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
        Ye Bin <yebin10@huawei.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, linux-kernel@vger.kernel.org,
        jack@suse.cz
Subject: Re: [PATCH v2] ext4: fix inconsistent between segment fstrim and full fstrim
Date: Mon,  8 Jan 2024 21:53:23 -0500
Message-ID: <170476879011.637731.15498657467622683553.b4-ty@mit.edu>
In-Reply-To: <20231216010919.1995851-1-yebin10@huawei.com>
References: <20231216010919.1995851-1-yebin10@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


On Sat, 16 Dec 2023 09:09:19 +0800, Ye Bin wrote:
> Suppose we issue two FITRIM ioctls for ranges [0,15] and [16,31] with
> mininum length of trimmed range set to 8 blocks. If we have say a range of
> blocks 10-22 free, this range will not be trimmed because it straddles the
> boundary of the two FITRIM ranges and neither part is big enough. This is a
> bit surprising to some users that call FITRIM on smaller ranges of blocks
> to limit impact on the system. Also XFS trims all free space extents that
> overlap with the specified range so we are inconsistent among filesystems.
> Let's change ext4_try_to_trim_range() to consider for trimming the whole
> free space extent that straddles the end of specified range, not just the
> part of it within the range.
> 
> [...]

Applied, thanks!

[1/1] ext4: fix inconsistent between segment fstrim and full fstrim
      commit: 3d1aa1169c45aba9d589be1eb4b131f26f0a663c

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>