Received-SPF: pass (google.com: domain of linux-kernel+bounces-20317-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 8 Jan 2024 20:08:40 -0700
From: Rob Herring <robh@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Paolo Abeni <pabeni@redhat.com>, Emil Renner Berthing <kernel@esmil.dk>, devicetree@vger.kernel.org, Alexandre Torgue <alexandre.torgue@foss.st.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, linux-stm32@st-md-mailman.stormreply.com, Jose Abreu <joabreu@synopsys.com>, Conor Dooley <conor+dt@kernel.org>, Jakub Kicinski <kuba@kernel.org>, Samin Guo <samin.guo@starfivetech.com>, linux-arm-kernel@lists.infradead.org, Jacob Keller <jacob.e.keller@intel.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, kernel@collabora.com
Subject: Re: [PATCH v3 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add
 JH7100 SoC compatible
Message-ID: <170476971804.2467890.1994452217560064962.robh@kernel.org>
References: <20231222101001.2541758-1-cristian.ciocaltea@collabora.com>
 <20231222101001.2541758-2-cristian.ciocaltea@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231222101001.2541758-2-cristian.ciocaltea@collabora.com>


On Fri, 22 Dec 2023 12:09:59 +0200, Cristian Ciocaltea wrote:
> The Synopsys DesignWare MAC found on StarFive JH7100 SoC is mostly
> similar to the newer JH7110, but it requires only two interrupts and a
> single reset line, which is 'ahb' instead of the commonly used
> 'stmmaceth'.
> 
> Since the common binding 'snps,dwmac' allows selecting 'ahb' only in
> conjunction with 'stmmaceth', extend the logic to also permit exclusive
> usage of the 'ahb' reset name.  This ensures the following use cases are
> supported:
> 
>   JH7110: reset-names = "stmmaceth", "ahb";
>   JH7100: reset-names = "ahb";
>   other:  reset-names = "stmmaceth";
> 
> Also note the need to use a different dwmac fallback, as v5.20 applies
> to JH7110 only, while JH7100 relies on v3.7x.
> 
> Additionally, drop the reset description items from top-level binding as
> they are already provided by the included snps,dwmac schema.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml   | 11 +--
>  .../bindings/net/starfive,jh7110-dwmac.yaml   | 72 +++++++++++++------
>  2 files changed, 57 insertions(+), 26 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>