Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp91687rdd; Mon, 8 Jan 2024 19:28:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZwcFo3e3uHHX9qBDCmed4ZcNefcnzzT5kZN8m9VRDxeK2NNf54H7hUl+vCElfCo2qzHcQ X-Received: by 2002:a17:907:75f3:b0:a19:a19b:4241 with SMTP id jz19-20020a17090775f300b00a19a19b4241mr100923ejc.172.1704770884417; Mon, 08 Jan 2024 19:28:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704770884; cv=none; d=google.com; s=arc-20160816; b=n+GnJMG9sM8W5SGgcnGnXsA/3keeP5aUFhGrt2KUNb1lkmDGwpDoPDcldAP8hbWO9E pM0nnbtvYkUKWdMHSAhx8XrlOEklkREHLTmuDgemgldCLlKbVrBQyPjEROysDpdA8yhW s6opWKuv7LPQHJVEsjMjyxajgqqCrzMl7YkbrvWAHs05NQs3i9XY1zVnxMs6+9Acdyte FhQQxX8LKH8iWMhJJHWAV6RlBK+jMghtz7noGYnfTKxG9Bf0lCKbq+9aJFPvCZrc8tS9 poWUTlJmGC8Tij8QMLrM9khKSZwUlKemb+/oimIp3IW24jmUKCFO2AklSVq89mgMlrQc mzIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=PXL4Ps3qf8k5Z/Ui1IqX2W2Ns+rNuQpEvgdkOPDwzLU=; fh=CJo3LVWlFx0SSDd2KyAcjEm1J/WSeugOMyqrblhq6c4=; b=PKYTflvyLA8F+QtMyTXTMlJirRrZ9a/1yckV/HVbH8YEXChm1PDA3zVmz8Ckkp3xQT 2k4XHEflAaUFJT67oopbP8QvgC3nfycK+6neDkd6/3jr0TVxJJJMNLU+9Q8LCY8aZBCv q4f7UvqX6LSZ9G1Bo0DABNC63ecjHuSrG+4fIYKDAEhYWOd6IWyRZLcU7fiqGEDXYFxc 9O03WLEP/en5mUbWo9afHQcRs22weC3v4ft1kPCyT5HxOEA1VQBeyGS3eNx6Kb1vOvz4 f9k5JZwyDuKJIHE8fIwMBIoYDQhZ0GtuLPLA8IfGSBYuQvN7fwMwNI9MLg0DXiWjqtLY 0Z1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=GXR7boh0; spf=pass (google.com: domain of linux-kernel+bounces-20324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20324-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id o20-20020a1709061d5400b00a28bf69b055si457172ejh.435.2024.01.08.19.28.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 19:28:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=GXR7boh0; spf=pass (google.com: domain of linux-kernel+bounces-20324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20324-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2EDE51F240DE for ; Tue, 9 Jan 2024 03:28:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 699AE6FBC; Tue, 9 Jan 2024 03:27:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GXR7boh0" Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B884612E for ; Tue, 9 Jan 2024 03:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-28be52a85b9so1559110a91.1 for ; Mon, 08 Jan 2024 19:27:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704770869; x=1705375669; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PXL4Ps3qf8k5Z/Ui1IqX2W2Ns+rNuQpEvgdkOPDwzLU=; b=GXR7boh0iZBGxwgnd//NnkSNimTCzv2aMx9n3eRuvMufloVy6ayrFXua80W2rRuhd7 0c279U17OBlpz8UONaVojKk+kL+WaJlkJSTuwlGrQ+7vWn6oh5TMUKJlAkKJlD4QoALv TFTMPAc5Tjdu6STHNKnnO9VLrnCGtGZqpNkkc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704770869; x=1705375669; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PXL4Ps3qf8k5Z/Ui1IqX2W2Ns+rNuQpEvgdkOPDwzLU=; b=JJ0mjvKbGa4HYA3pqGyrde0cHy4BcYcQ8yrmChVMupx0SqUFFE0EXjlouSW53jCRXa +5sLcFTZDij/7zNiR/DD3Mm/ZBvbAffOhmwDvinvIi10ySnBqglq6qu7SQgi+oNX+NHZ 1DHgSOm0r7r0C9CmW0jkseLdWrfMSpt+opPjyjdG83v3nS6yCTf2BZU7IpkISCNy8IA8 Klcqk7N/JudZg0mqU22o6244mSeXytFT4nm9UzGILtEJjONvZqMa/KMvgc5HW9fTtVxc jWPiQibKdVBNjlKgmfmv/xmLKPVCNPwp9Jg2mDDRQqUy5wWMjux5nWfMKtmzAquUqyuK 4noQ== X-Gm-Message-State: AOJu0YzTtV/nvyGPXhLlqPMWSsB8ZLmMmiJtFKst4yhd4cfsK2TkEHlm CaTEEFePeWXM48v2o4+dpDQP6YJSmB6r4Q2/7H/OHS3jww== X-Received: by 2002:a17:90a:b38c:b0:28c:f509:ed14 with SMTP id e12-20020a17090ab38c00b0028cf509ed14mr1813274pjr.15.1704770869495; Mon, 08 Jan 2024 19:27:49 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:7b29:709a:867f:fec5]) by smtp.gmail.com with ESMTPSA id nd12-20020a17090b4ccc00b0028ce9c709e4sm7238276pjb.26.2024.01.08.19.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 19:27:49 -0800 (PST) Date: Tue, 9 Jan 2024 12:27:47 +0900 From: Hidenori Kobayashi To: Sakari Ailus Cc: Dan Carpenter , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: staging: ipu3-imgu: Set fields before media_entity_pads_init() Message-ID: <20240109032747.64nnee5qo5qyuply@google.com> References: <20231228093926.748001-1-hidenorik@chromium.org> <27f1c487-78cc-4e56-ba79-1434aba131fd@moroto.mountain> <20240105021856.wpzmwtyzxzqfznrp@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Dan, Sakari, On Mon, Jan 08, 2024 at 08:59:37AM +0000, Sakari Ailus wrote: > Hi Dan, Hidenori, > > On Fri, Jan 05, 2024 at 10:34:20AM +0300, Dan Carpenter wrote: > > Hm... I don't know either. Wait for a day and see if anyone else has > > an opinion then listen to your gut and resend with whatever your gut > > says? > > The suggested commit message seems good to me, the Fixes: line is > important. Thanks for digging this up! The patch should go to v6.7, too, so > please add Cc: stable (for v6.7). Thanks for the comments! I'll send v2 with the revised commit message, with Cc: stable. Hidenori