Received-SPF: pass (google.com: domain of linux-kernel+bounces-20423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <124218d0-80c8-4971-8ba4-1ebaf0a5fb1f@virtuozzo.com>
Date: Tue, 9 Jan 2024 14:05:25 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] neighbour: purge nf_bridged skb from foreign device neigh
Content-Language: en-US
To: kernel test robot <lkp@intel.com>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel@openvz.org
References: <20240108085232.95437-1-ptikhomirov@virtuozzo.com>
 <202401091351.CqYRoau7-lkp@intel.com>
From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
In-Reply-To: <202401091351.CqYRoau7-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aEZJYThiNVBCeWpuTUM2aEZGenpQNE9PU0ZLWDJySTZKRzVRWVovS0xZT0lI?=
 =?utf-8?B?bTlYeVJheFBMdlBXTWtrbUMvb2Yxb1NJOVk3bFp6Vnl6V0RSb3p5SmZzY3NL?=
 =?utf-8?B?UkcyZzUxMElXVWt6a3g3aTJBek9PRlUrMUd1eXRhbDhxL3dSWVlJbHo2bnEw?=
 =?utf-8?B?TEFNTWppbEhiRUJuV2piV2lNRGdHSlZzY21yZWRibGs5c2hyMkFwUUY1Lzln?=
 =?utf-8?B?OG1Qa3l2ejhJdURUVWpNcW1YVTJwRFlXTFcxOGtGdlZnUkhkWFhKUEFNaEQx?=
 =?utf-8?B?Q251REhEWHYwZk5iSlNFTkxtQUtSYlRWT0dQOVFxSjljdG1rRFcxNEdsU2Va?=
 =?utf-8?B?Sk1tSnF0ODZ2ZVB1WmZIMis2SVIrV0lsaTZocWhjZXQzRXNrTEY0aGZpS1M3?=
 =?utf-8?B?ZWlpWDZoNEtpR2ZvbDdocVova09WTXR3L205U1crNVBHZmVJNCtYa1FLUTVy?=
 =?utf-8?B?c3FCVXNwS0xzUjlQc3BubEgyOUxrZzhPTG9VUlhpSHZ1Vng3WU9aTy9kYS8x?=
 =?utf-8?B?L2FqWjlPaDY0NjZHRFZXekpyeTg5UCtzL2VuSGNrVDF6LzFjMmt6UzFjYTM3?=
 =?utf-8?B?eXRnTWphRlJWSExMR2xUZEZoMm95ZVJjS05NODRSZHlQbEtTdFFVdzEzeG16?=
 =?utf-8?B?UnZjaU9LZHJ1RmtPbTZRaURzdEtwSkRXSnk1RXBpR3pMR2tvVVB5dG80NU00?=
 =?utf-8?B?NmdZUlZJaHV5NTlucVd0YmdqWklIcDlZWTBDbXVYNHducjJwRnlFZ1RvUzMr?=
 =?utf-8?B?UisySDhXMjl5NEh1OUwyRkZXajdUeC9BZlVLb29temZpenlWT0Zhczg0T0l6?=
 =?utf-8?B?VWtNMVZnYkV1OFlRRCtrVlVFVlJsM1Z1ZjZXOXF1UHRuYjByeUM5Um93ZGNS?=
 =?utf-8?B?cnJZcFZhWGhpUmRDM0NpU1FqVURZLzBkSE5oQUZ2WnB2T2pYQVNnbFpPQjNv?=
 =?utf-8?B?WllLR1NxL3VTRElGY2dVR3NqMVE2WWhIQmtWVkxQRDRBeUN0TGx3cG50UGh0?=
 =?utf-8?B?YVdKRWJ0MXA1RGVKVTZ5dVk2WTVtR0tOZURqeHUrN3Rva2dZVEhTWVdzdy96?=
 =?utf-8?B?bWtXamdqbXNzVDAvNUs0ZkYrdGViNnhmZXRKMUJEbEZTUnlqcEFDWHp3TmVI?=
 =?utf-8?B?QnVnTzMxdHdBS3laWmp1YjJRTTFxRXIxTlRjNlNOZHdidllsenA5ZlpoYTNh?=
 =?utf-8?B?RURjczRhNFFUd1pCVUxPUm1QSUFpRHk4TjROTEl0Wk5ZV0pTaWVuSFQ4L3dz?=
 =?utf-8?B?aXlVVW5nYnBrYUdKblM0Si9nU0hQb0MxZ1NBMHVtNHRaOU1Kd1NEL0FTL0dI?=
 =?utf-8?B?UllhMy9PMDZDRlFrQlhsdFRmKzh6YVY4aEZiLytmZGdhUTc4S3lad3QwQlFB?=
 =?utf-8?B?dlFaWmM3amk4dW5aeDVZMlJxTG9ZVk41NFVSY2M4N1FwTTBhb1hyWGVJSmE3?=
 =?utf-8?B?NUlSQ2d1clZaNWNQUmUvUElTcUFhS3ByYTkyb0YwdTRrUHJ1ZG5CUk1nVWJh?=
 =?utf-8?B?aUVLMit3UnFDR0MvUlJLNnh5cmdNSzlYVnZHdmt2MWVuY1MxMS9DVlNXNW5N?=
 =?utf-8?B?b005bmh3VkJ1V1dqRS9hZkRqSEhZNG8waUhyVUZ2RUJteUwyN1k5ZXBKUGJu?=
 =?utf-8?B?WmNERDREblZzd0FLcTljM0JVNUhNWHlGQXhJUkR5WStvdW52RHl3eFV3RlM5?=
 =?utf-8?B?cEIrVlNKUUxSZHJxdjdyc29vRWVaUWRhZ0dBckxxWklhdHhLUUxGTnU4SE9S?=
 =?utf-8?B?a3FJOTQ3QTJnVjZyb2RhUVBtQndycFR6YUxOUjBkd3JyVVBFOU9EM2FuMU1R?=
 =?utf-8?B?Q3dQamU1N2RTdWNuMFpiOGRIY1JWZDZrQmJnUUNNN2FkQlJrUkN3azRQR0xN?=
 =?utf-8?B?VVlDL3Azb1hjVUZSNFFIMG9XeGVCTVU1a0lmbWs1a2IzQ0tmSGttN3N4UWdX?=
 =?utf-8?B?T3E0Q2RsK2R6VDFPL3pCcGY2VGs0ZTh4OThEM2paV3YyWkQ1MTg2akp2VzFy?=
 =?utf-8?B?L2JCQVViTUtpUUZjdjBqekNWWUd5YkdwQzdJK3pDZkhEeFVScy9TQVN2TG9o?=
 =?utf-8?B?Z3hEdnV3ZEtRaVUwY0xzSXRZYzVjVzdLcVBYMUFYaUp3MktSeTdHaWhCdk0v?=
 =?utf-8?B?RGJhZzRkdmd1ekJKUkI5MUJTWEdiMWJaS1lIUXNQb3o2RFZwRXVXMzhUa2Q0?=
 =?utf-8?B?cUpUN2lGZGhKUmZyOEh3dG5pQXlpZG41Wno4WUtiWmdXYStsYzBmZ3IzdkRK?=
 =?utf-8?B?VnFUeWtZSGlGR3E3RDd5d2FvUUd3PT0=?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a431a1c-dc02-4fbc-abc1-08dc10d8fd0a
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9003.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 06:05:32.6752
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WyjunYUs+xejpDABDG8igb5V5t3rgFedqVZ/Wa8Dyip0jijlIlf4hvMtK7aR8uwQVYkejApCVRpfCRybxzalt8+gNiSm/pIE6gC3dwp0LNU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8636

That problem happens because the patch is not ready to handle the lack 
of CONFIG_BRIDGE_NETFILTER (as Eric already mentioned earlier in this 
thread).

On 09/01/2024 13:38, kernel test robot wrote:
> Hi Pavel,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on net-next/main]
> [also build test WARNING on net/main linus/master horms-ipvs/master v6.7 next-20240108]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Pavel-Tikhomirov/neighbour-purge-nf_bridged-skb-from-foreign-device-neigh/20240108-165551
> base:   net-next/main
> patch link:    https://lore.kernel.org/r/20240108085232.95437-1-ptikhomirov%40virtuozzo.com
> patch subject: [PATCH] neighbour: purge nf_bridged skb from foreign device neigh
> config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20240109/202401091351.CqYRoau7-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240109/202401091351.CqYRoau7-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202401091351.CqYRoau7-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>     net/core/neighbour.c: In function 'neigh_purge_nf_bridge_dev':
>     net/core/neighbour.c:392:29: error: implicit declaration of function 'nf_bridge_info_get' [-Werror=implicit-function-declaration]
>       392 |                 nf_bridge = nf_bridge_info_get(skb);
>           |                             ^~~~~~~~~~~~~~~~~~
>>> net/core/neighbour.c:392:27: warning: assignment to 'struct nf_bridge_info *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>       392 |                 nf_bridge = nf_bridge_info_get(skb);
>           |                           ^
>     net/core/neighbour.c:395:43: error: invalid use of undefined type 'struct nf_bridge_info'
>       395 |                 if (nf_bridge && nf_bridge->physindev == dev) {
>           |                                           ^~
>     cc1: some warnings being treated as errors
> 
> 
> vim +392 net/core/neighbour.c
> 
>     382	
>     383	static void neigh_purge_nf_bridge_dev(struct neighbour *neigh, struct net_device *dev)
>     384	{
>     385		struct sk_buff_head *list = &neigh->arp_queue;
>     386		struct nf_bridge_info *nf_bridge;
>     387		struct sk_buff *skb, *next;
>     388	
>     389		write_lock(&neigh->lock);
>     390		skb = skb_peek(list);
>     391		while (skb) {
>   > 392			nf_bridge = nf_bridge_info_get(skb);
>     393	
>     394			next = skb_peek_next(skb, list);
>     395			if (nf_bridge && nf_bridge->physindev == dev) {
>     396				__skb_unlink(skb, list);
>     397				neigh->arp_queue_len_bytes -= skb->truesize;
>     398				kfree_skb(skb);
>     399			}
>     400			skb = next;
>     401		}
>     402		write_unlock(&neigh->lock);
>     403	}
>     404	
> 

-- 
Best regards, Tikhomirov Pavel
Senior Software Developer, Virtuozzo.