Received-SPF: pass (google.com: domain of linux-kernel+bounces-20439-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231220080147.740134-1-ilias.apalodimas@linaro.org> <20240102153547.58b23d35@kernel.org>
In-Reply-To: <20240102153547.58b23d35@kernel.org>
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: Tue, 9 Jan 2024 09:02:02 +0200
Message-ID: <CAC_iWj+VM1vCDygvXkd6snuSO64iQCm48oahYa4wQQeM3QXiFg@mail.gmail.com>
Subject: Re: [PATCH net-next v2] page_pool: Rename frag_users to pagecnt_bias
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linyunsheng@huawei.com, 
	Jesper Dangaard Brouer <hawk@kernel.org>, "David S. Miller" <davem@davemloft.net>, 
	Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

Hi Jakub,

On Wed, 3 Jan 2024 at 01:35, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 20 Dec 2023 10:01:46 +0200 Ilias Apalodimas wrote:
> > -     long frag_users;
> > +     long pagecnt_bias;
>
> IDK :(
>
> pagecnt to mean suggests this is related to page refcount,
> not page pool specific refcount.
>
> More importantly bias is the large number by which we increment.
> This counter counts how many of the bias references we actually
> consumed. So how about bias_consumed? bias_used? bias_issued?
> frags_alloced?

I had similar concerns, that's why v1 used 'frag_cnt'.
I am fine with either frags_alloced or frag_cnt

Thanks
/Ilias