Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp177193rdd; Mon, 8 Jan 2024 23:57:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IEQUEAoNCuM8zh/XWW4wKl1wbRnyMeXhTOXb0h/eIHrCnSkt8nFpTptRbX0Yjn31VG2YImY X-Received: by 2002:a17:90a:9f48:b0:280:cd7b:1fa5 with SMTP id q8-20020a17090a9f4800b00280cd7b1fa5mr2058142pjv.4.1704787065843; Mon, 08 Jan 2024 23:57:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704787065; cv=none; d=google.com; s=arc-20160816; b=NwJKUZrWNH0oxOcISMRJ/xWdaP+aWBYXIlpNtDNKvqofYTBN6yHItqu5o8GU0gfWNk DJgrq/N1bxe3cthbXjyC44KD1INMlNRAcUNCUXxSM+OEQG08mB09MBKJyv17NHUwCVUT H13JOepWX2PO6W3WJAFPOxj7Toso6zjV9fDSXWWRMscn0HRyXf/FgAXno7W0yJQDQnh4 6SZf9sJW9UBOkweIDTQsdQoG9B4CjYKN+SMjAWNBZtAytp48EnNdQRKB0cSI6RcKSP4A lviMFT8IA8vm8A2xtzANnIzXj4ccVIgLxAy7rwg4VmqmMwm9rJ2f8DZ1hJDl2UgNmy6q SOLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=LRtOm5MD67d/VCeXWUetPCpX2ZVDj114BgVA25SCM0g=; fh=0K7C0KeegvjokdGPTMCU71kh/bNEhzIoybFNwwxwzF4=; b=JnBSnxDgfXn9YPmh94JOM804huPG2tKLcT2RhLAqbkG9WHDQyEGJWdrx2qTBcMGAkA rTOu3GY6WmgGNIg3I7uDSbAA0ZqasSsJ+wPgM3OZ8AYXC4l/L+6zJgD2AOFAzc0vWGYO XMzZUzuFZuWhq0GPmCrB7EtNsdm3eFX37Kjrvogsr4de+ANuJmPWkTobS+gD95Oqj1u6 aRR+KxeN0rWNIQ9vDeHKAmzo5a6aoSqp+tlfsGEVBqvzJ84Z43WFzxe/F1fqA2ZDKooq wPqRPdHxQzDLAUCdtCiS82djtS5ymH7WaNpKhU20VqEUnBxuu2aO+1rRpPyRwvuSQ17e 32TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pYDd13yT; spf=pass (google.com: domain of linux-kernel+bounces-20503-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20503-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b13-20020a17090a6e0d00b0028bc0991858si6833469pjk.165.2024.01.08.23.57.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 23:57:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20503-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pYDd13yT; spf=pass (google.com: domain of linux-kernel+bounces-20503-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20503-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7DC4A287CD5 for ; Tue, 9 Jan 2024 07:57:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 36E6C25750; Tue, 9 Jan 2024 07:57:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pYDd13yT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D825224FC; Tue, 9 Jan 2024 07:57:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E61DBC43390; Tue, 9 Jan 2024 07:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704787024; bh=osEjPHFSBRRETsdDQv26/OIMeyS5BBWg439/b7Ob4A8=; h=From:To:Cc:Subject:Date:From; b=pYDd13yTLCtkfqQoESXCMcWnOzWulKNk0gNlddCa0aVZUdp73YdTPb6zOa+NDYu1U wk2QrfUSBUKYmJwDUkE4hZqOPiU4drhPMeWxRInBVCN3gGpEw3ciEFBE4eZPyhuz+t 5WPB7o7I+QxEc8szDmNMOYcylAEOHfuPQ10YKp2Kj0a1znltyenmmV10G5PDlnlTsh /By3rMemiSg4sqV1FMX8O68Q1wbv0HZUCQ5TV3GuTTzTGncFjtQCKyQ+ibFpU9LMPg S6XzseCo2sbnJU0JJFJVEAbT3dHoVSXz602LCHPpGksRYIx7bbxbZQXHT2th40jGKN b5f99I1NdcA3w== From: Arnd Bergmann To: Jiawen Wu , Mengyuan Lou , Jakub Kicinski Cc: Arnd Bergmann , "David S. Miller" , Eric Dumazet , Paolo Abeni , Russell King , Andrew Lunn , Maciej Fijalkowski , Andy Shevchenko , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wangxunx: select CONFIG_PHYLINK where needed Date: Tue, 9 Jan 2024 08:56:21 +0100 Message-Id: <20240109075656.2656359-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann The ngbe driver needs phylink: arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset': wx_ethtool.c:(.text+0x458): undefined reference to `phylink_ethtool_nway_reset' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_remove': ngbe_main.c:(.text+0x7c): undefined reference to `phylink_destroy' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_open': ngbe_main.c:(.text+0xf90): undefined reference to `phylink_connect_phy' arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.o: in function `ngbe_mdio_init': ngbe_mdio.c:(.text+0x314): undefined reference to `phylink_create' Add the missing Kconfig description for this. Fixes: bc2426d74aa3 ("net: ngbe: convert phylib to phylink") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/wangxun/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig index 23cd610bd376..46630f05d8dd 100644 --- a/drivers/net/ethernet/wangxun/Kconfig +++ b/drivers/net/ethernet/wangxun/Kconfig @@ -26,6 +26,7 @@ config NGBE tristate "Wangxun(R) GbE PCI Express adapters support" depends on PCI select LIBWX + select PHYLINK select PHYLIB help This driver supports Wangxun(R) GbE PCI Express family of -- 2.39.2