Received-SPF: pass (google.com: domain of linux-kernel+bounces-20615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID:
 <MA0P287MB2822C1F51E9F03137EF42093FE6A2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Tue, 9 Jan 2024 16:52:09 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 1/4] dt-bindings: soc: sophgo: Add Sophgo system
 control module
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Chen Wang <unicornxw@gmail.com>, aou@eecs.berkeley.edu, chao.wei@sophgo.com,
 conor@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 mturquette@baylibre.com, palmer@dabbelt.com, paul.walmsley@sifive.com,
 richardcochran@gmail.com, robh+dt@kernel.org, sboyd@kernel.org,
 devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
 haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com, guoren@kernel.org,
 jszhang@kernel.org, inochiama@outlook.com, samuel.holland@sifive.com
References: <cover.1704694903.git.unicorn_wang@outlook.com>
 <acebc88db3e5fcd2a2607b56842af7443a6e1289.1704694903.git.unicorn_wang@outlook.com>
 <cc7cc943-7242-4fd1-9b56-3ece0a418e05@linaro.org>
 <MA0P287MB2822E54A6DD36F914DB56E98FE6B2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
 <1e1ef0a0-6639-4a4d-9b4e-50bcee3fb3c5@linaro.org>
From: Chen Wang <unicorn_wang@outlook.com>
In-Reply-To: <1e1ef0a0-6639-4a4d-9b4e-50bcee3fb3c5@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MA0P287MB2822:EE_|PN3P287MB2314:EE_
X-MS-Office365-Filtering-Correlation-Id: 6f3a94eb-19b2-4bba-a7c0-08dc10f04696
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	96nXshlr0ryDvksM5f0mUwCNlgyCF29fTOPUYMmo1yuV2tQItMUBqmdi3nsqMD04+iw2dW8C29uJ3JMVuJZGwnumHBht9DIG1W1grDPmzRjDjkTd8SNZosMGI/0tQt0x67Z+M67ALDvEr7aUWQHs/Dbvjiyo8udQQPNMfYBkKSjlpqXdzzjMTJgtddBh2noghmQmOUGyB8xgmyDnhX5BUh4BYPwiM7PW2GgvqNh61bSHJp5DSnZji3OgnZUcCbJOjHUogW4uxu+xz2B++m6fC4xREHXbMiOHWrf3ErIG/qPby7Y1v5OXo3iaXieOs80rdE4/HtrF+Qn6Fc6080BGNjvO6C8TF8R2HJPAdy3p1h6zSPBtXeWVpY2P7WVljDkDS4VpeXohbYC1ZWjv68UG7o7+stnyRHPUqEhFw0Kie1POqjxJI4HDcwgNdHIE/Thhqo16+gtD/P0ZxcVMyJ77wN7O9QLi3HV7wQoApKCmv6zgKKhqaHv40PLhsdS6iyumeddvO4dRQacXegF2GERyVQPYjYn5x1rie1g5JzbZZmtMut6eItd2VOcTFrawpUQZRQLUY53UraopYguNnWTdcoDHqKIf5p8sDjE6eoy5m4k5L0mvxJlVUb4HvcYJDqKnABMOA9j9zpnsBF8NiDcoNg==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0NPVDE5RUxEMkFkOHNpMDJJZnMxWHZ3VGxEYi9zTG96YUo3Uy8yU1NaUVZF?=
 =?utf-8?B?STJ1RFBZQ3NqbTFJc2ZwQlRGc1l1SnRoV3JKblVLcmozNGl5d3lYMDdsR1M3?=
 =?utf-8?B?MDVtK1Z2dmpOSjRtNEh1TG50b1pJMGVQaUpDOVdQYllYcFptYlFIanh4QWpl?=
 =?utf-8?B?SDZtUVo0L0lYeTJvUTQ0aFlWN1d0Nm9CR1hyQ2QwN3dycmFVY3hXSEZJamxk?=
 =?utf-8?B?TFFpaXhmd3E4UVcwOG9ud3kxU0pXZDkrVzcvMTRHdHpab2VmUVBwTTRPbE9h?=
 =?utf-8?B?RVVmaFdZdG1BZE1VUms4VnRsZVdTc2RVcnpyY2ZqQzZraE0rTFk0c1BoYzJR?=
 =?utf-8?B?WS9Od2pWYWZZdG0rSGd3L2VjYzlkdWllNlZOL05WNU1WWGdsWmZYV05RQW0z?=
 =?utf-8?B?M1hkWVdOQ0VrYzgwQlh2YVNmR2Y2dDdITG93M000TGFxRWhFbHkyelAyQ1BG?=
 =?utf-8?B?R2pQdGgyT2RMZG9uMTUrS3ZTb1RsbEU1cGRmQ3d5TzZxSHd5SlVjK2tzWFAx?=
 =?utf-8?B?MmVuM0paMnJQZWF1aThCQW8vS202RDhXNjlzS0lTaXV4MkRYbWQxcTJsanU2?=
 =?utf-8?B?Rlp5eTdjdUJ1d2kxMFJTd1FoSnhPUnpDSkFabG1YMDEyWUxlK2JvclQ2YjVD?=
 =?utf-8?B?K2daUzdlMFRib1JuQ0xVbzdhcUFpbkN3ZzBNMm5yaTZGbzZocWRIblVCN2lN?=
 =?utf-8?B?QUl6Mnp4M3ZpVHdkRTB0UHZDK0o0N2tYY1JWNlRYSitJYmw5VEFOK3pmNHdB?=
 =?utf-8?B?emw3R3RTUE5BQ1FwRnpKVDA4YWp6YjI3SWorQmZhMkducjBtZTJhQm9FeERx?=
 =?utf-8?B?V2JnR3NvNmNjWnAvb05YOGNBYXJ0UkZGdStnYTZsc0xrU01idjdESUNwdXJT?=
 =?utf-8?B?S3ZVM3dKUCtkTGRhekRRTGF3MXUxcVBjQnJIVDFUTXRxcEd0akM5WE9VNTlT?=
 =?utf-8?B?YkJGeDNmY0l1RFVtQ0FLd2tld2c1N1YxejM1WmlsOTBQcHU5bksyS1cxZlR4?=
 =?utf-8?B?dDdxUkhROGZEMGZ0bUdrUGhyUVZ1QWNaU29pUlQ3UW05dU9Vd1dNbzFLQk9n?=
 =?utf-8?B?akhPY004ZzFwUVF2MHpZTUVURVcwYm8wcGNjRDhRQlppR2U3Z0NHTjd6WmIz?=
 =?utf-8?B?cGY5anE0OVE5cTBpQWxndlV1OGdhRWNzcWpLcVc2UjhyU1RyK3BiaGI4c3NX?=
 =?utf-8?B?TmdDL09yNzcwbHZPS0s5SHljZGo5UllzbzJ6RGh0Yk1HUmZTVUlDelJuUktV?=
 =?utf-8?B?N0JaRjhZYldwKzZBTUQ1ZTM4aWhSYUsrVC9FNVFxVEJXT2g5QmY1NVVJYVNp?=
 =?utf-8?B?QTNPZ0ZocFJRVERsV2dPMWJGU2ZLVjI3bjdxakN0dE1OdkJ0SnByaW9FUVZY?=
 =?utf-8?B?Z2hyMkZNbFFJRnpiYi8wMEFqYXVKa0ZQZ2psYzgvbWFtN1kvS2xPWG1ySy95?=
 =?utf-8?B?TEZ4UjRzeGdURmYzdEhvYjg2T1RJZjRNNDJtUlVEMU5qbUVpV1MrMm96c0JK?=
 =?utf-8?B?amxVeGR0NkQ3SUx4ZGxUUm0zdUJsKzhvaUpnZkhQcHVwMDV5UWpRTFBMMTZ5?=
 =?utf-8?B?SnBIS3pFRzVRalh6cW8rSG9HRlV0YlZqaVdCcHZLMGZvUVJpelhOZE8ySk9x?=
 =?utf-8?Q?PvvZH1XWzPpeIKDCwCYwgoyaKiKfUF29cx2Z/h6jEcNA=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f3a94eb-19b2-4bba-a7c0-08dc10f04696
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB2822.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 08:52:14.5609
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3P287MB2314


On 2024/1/9 3:36, Krzysztof Kozlowski wrote:
> On 08/01/2024 08:20, Chen Wang wrote:
>> On 2024/1/8 15:03, Krzysztof Kozlowski wrote:
>>> On 08/01/2024 07:48, Chen Wang wrote:
>>>> From: Chen Wang <unicorn_wang@outlook.com>
>>>>
>>>> Add documentation to describe Sophgo System Controller for SG2042.
>>>>
>>>> Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> ---
>>>>    .../soc/sophgo/sophgo,sg2042-sysctrl.yaml     | 34 +++++++++++++++++++
>>>>    1 file changed, 34 insertions(+)
>>>>    create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml b/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml
>>>> new file mode 100644
>>>> index 000000000000..1ec1eaa55598
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml
>>>> @@ -0,0 +1,34 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/soc/sophgo/sophgo,sg2042-sysctrl.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Sophgo SG2042 SoC system controller
>>>> +
>>>> +maintainers:
>>>> +  - Chen Wang <unicorn_wang@outlook.com>
>>>> +
>>>> +description:
>>>> +  The Sophgo SG2042 SoC system controller provides register information such
>>>> +  as offset, mask and shift that can be used by other modules, such as clocks.
>>> "offset, mask and shift" is not a register information stored in
>>> syscons. Are you really sure, that your system controller hardware
>>> stores offsets of some other registers?
>>>
>>> Show as some example of such offsets, masks and shifts provided by this
>>> hardware.
>> The system control module is defined here:
>> https://github.com/sophgo/sophgo-doc/blob/main/SG2042/TRM/source/system-control.rst.
>> It contains some registers related to pll and gates.
> I do not see there registers providing shifts and offsets... just values.
>
>> Some other clocks registars are defined in
>> https://github.com/sophgo/sophgo-doc/blob/main/SG2042/TRM/source/clock.rst.
>>
>> memory-map is defined in
>> https://github.com/sophgo/sophgo-doc/blob/main/SG2042/TRM/source/mmap.rst
>
> Please fix the wording because it does not make sense. System controller
> does not provide register information. Your datasheet provides register
> information.

Could it be that what I said "that can be used by other modules, such as 
clocks." may cause misunderstanding. I plan to change it to "The Sophgo 
SG2042 SoC system controller provides register information such as 
offset, mask and shift to configure related modules such as clock." Is 
this better?


>
> Best regards,
> Krzysztof
>