Received-SPF: pass (google.com: domain of linux-kernel+bounces-20655-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240109083253.3629967-1-lizhijian@fujitsu.com> <20240109083253.3629967-2-lizhijian@fujitsu.com>
In-Reply-To: <20240109083253.3629967-2-lizhijian@fujitsu.com>
From: Greg Sword <gregsword0@gmail.com>
Date: Tue, 9 Jan 2024 17:20:00 +0800
Message-ID: <CAEz=LcvphS6QECpHTFhrRoC=FcSbEU4j_XuqJF7ognjJu+uF6Q@mail.gmail.com>
Subject: Re: [PATCH for-next v4 2/2] RDMA/rxe: Remove rxe_info from rxe_set_mtu
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-rdma@vger.kernel.org, zyjzyj2000@gmail.com, jgg@ziepe.ca, 
	leon@kernel.org, linux-kernel@vger.kernel.org, rpearsonhpe@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 9, 2024 at 4:41=E2=80=AFPM Li Zhijian <lizhijian@fujitsu.com> w=
rote:
>
> commit 9ac01f434a1e ("RDMA/rxe: Extend dbg log messages to err and info")
> newly added this info. But it did only show null device when
> the rdma_rxe is being loaded because dev_name(rxe->ib_dev->dev)
> has not yet been assigned at the moment:
>
> "(null): rxe_set_mtu: Set mtu to 1024"
>
> Remove it to silent this message, check the mtu from it backend link
> instead if needed.
>
> CC: Bob Pearson <rpearsonhpe@gmail.com>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> V4: Remove it rather than re-order rxe_set_mtu() and rxe_register_device(=
)
> ---
>  drivers/infiniband/sw/rxe/rxe.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/=
rxe.c
> index a086d588e159..ae466e72fc43 100644
> --- a/drivers/infiniband/sw/rxe/rxe.c
> +++ b/drivers/infiniband/sw/rxe/rxe.c
> @@ -160,8 +160,6 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int nd=
ev_mtu)
>
>         port->attr.active_mtu =3D mtu;
>         port->mtu_cap =3D ib_mtu_enum_to_int(mtu);
> -
> -       rxe_info_dev(rxe, "Set mtu to %d\n", port->mtu_cap);

I'd like to keep this statement so I can tell if the mtu setup was
successful or not.

>  }
>
>  /* called by ifc layer to create new rxe device.
> --
> 2.29.2
>
>